Re: [PATCH] vdpa: reject F_ENABLE_AFTER_DRIVER_OK if backend does not support it

2023-07-05 Thread Michael S. Tsirkin
On Thu, Jul 06, 2023 at 08:35:30AM +0200, Eugenio Perez Martin wrote: > On Thu, Jul 6, 2023 at 8:07 AM Michael S. Tsirkin wrote: > > > > On Wed, Jul 05, 2023 at 05:07:11PM -0700, Shannon Nelson wrote: > > > On 7/5/23 11:27 AM, Eugenio Perez Martin wrote: > > > > > > > > On Wed, Jul 5, 2023 at 9:50

Re: [PATCH] vdpa: reject F_ENABLE_AFTER_DRIVER_OK if backend does not support it

2023-07-05 Thread Michael S. Tsirkin
On Wed, Jul 05, 2023 at 05:07:11PM -0700, Shannon Nelson wrote: > On 7/5/23 11:27 AM, Eugenio Perez Martin wrote: > > > > On Wed, Jul 5, 2023 at 9:50 AM Jason Wang wrote: > > > > > > On Tue, Jul 4, 2023 at 11:45 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Tue, Jul 04, 2023 at 01:36:1

Re: [PATCH] vdpa: reject F_ENABLE_AFTER_DRIVER_OK if backend does not support it

2023-07-05 Thread Michael S. Tsirkin
On Thu, Jul 06, 2023 at 09:56:29AM +0800, Jason Wang wrote: > On Wed, Jul 5, 2023 at 4:42 PM Michael S. Tsirkin wrote: > > > > On Wed, Jul 05, 2023 at 03:55:23PM +0800, Jason Wang wrote: > > > On Tue, Jul 4, 2023 at 6:38 PM Michael S. Tsirkin wrote: > > > > > > > > On Tue, Jul 04, 2023 at 12:25:3

Re: [PATCH 22/23] i2c: virtio: Remove #ifdef guards for PM related functions

2023-07-05 Thread Viresh Kumar
On 05-07-23, 22:45, Paul Cercueil wrote: > Use the new PM macros for the suspend and resume functions to be > automatically dropped by the compiler when CONFIG_PM or > CONFIG_PM_SLEEP are disabled, without having to use #ifdef guards. > > This has the advantage of always compiling these functions

Re: [PATCH v3 3/3] vduse: Temporarily disable control queue features

2023-07-05 Thread Jason Wang
On Wed, Jul 5, 2023 at 6:04 PM Maxime Coquelin wrote: > > Virtio-net driver control queue implementation is not safe > when used with VDUSE. If the VDUSE application does not > reply to control queue messages, it currently ends up > hanging the kernel thread sending this command. > > Some work is

Re: [PATCH] vdpa: reject F_ENABLE_AFTER_DRIVER_OK if backend does not support it

2023-07-05 Thread Jason Wang
On Wed, Jul 5, 2023 at 4:42 PM Michael S. Tsirkin wrote: > > On Wed, Jul 05, 2023 at 03:55:23PM +0800, Jason Wang wrote: > > On Tue, Jul 4, 2023 at 6:38 PM Michael S. Tsirkin wrote: > > > > > > On Tue, Jul 04, 2023 at 12:25:32PM +0200, Eugenio Perez Martin wrote: > > > > On Mon, Jul 3, 2023 at 4:

Re: [PATCH] vdpa: reject F_ENABLE_AFTER_DRIVER_OK if backend does not support it

2023-07-05 Thread Jason Wang
On Wed, Jul 5, 2023 at 4:41 PM Michael S. Tsirkin wrote: > > On Wed, Jul 05, 2023 at 03:49:58PM +0800, Jason Wang wrote: > > On Tue, Jul 4, 2023 at 11:45 PM Michael S. Tsirkin wrote: > > > > > > On Tue, Jul 04, 2023 at 01:36:11PM +0200, Eugenio Perez Martin wrote: > > > > On Tue, Jul 4, 2023 at 1

Re: [PATCH v2 00/24] use vmalloc_array and vcalloc

2023-07-05 Thread Martin K. Petersen
Julia, > The functions vmalloc_array and vcalloc were introduced in > > commit a8749a35c399 ("mm: vmalloc: introduce array allocation functions") > > but are not used much yet. This series introduces uses of > these functions, to protect against multiplication overflows. Applied #7 and #24 to

Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance

2023-07-05 Thread Liang Chen
On Wed, Jul 5, 2023 at 2:05 PM Jason Wang wrote: > > On Wed, Jul 5, 2023 at 1:41 PM Liang Chen wrote: > > > > On Fri, Jun 9, 2023 at 10:57 AM Liang Chen > > wrote: > > > > > > On Thu, Jun 8, 2023 at 8:38 AM Jason Wang wrote: > > > > > > > > On Thu, Jun 8, 2023 at 4:17 AM Michael S. Tsirkin >

Re: [PATCH] vdpa: reject F_ENABLE_AFTER_DRIVER_OK if backend does not support it

2023-07-05 Thread Shannon Nelson via Virtualization
On 7/5/23 11:27 AM, Eugenio Perez Martin wrote: > On Wed, Jul 5, 2023 at 9:50 AM Jason Wang wrote: On Tue, Jul 4, 2023 at 11:45 PM Michael S. Tsirkin wrote: On Tue, Jul 04, 2023 at 01:36:11PM +0200, Eugenio Perez Martin wrote: On Tue, Jul 4, 2023 at 12:38 PM Michael S. Tsirkin wrote: On

[PATCH] vduse: Use proper spinlock for IRQ injection

2023-07-05 Thread Maxime Coquelin
The IRQ injection work used spin_lock_irq() to protect the scheduling of the softirq, but spin_lock_bh() should be used. With spin_lock_irq(), we noticed delay of more than 6 seconds between the time a NAPI polling work is scheduled and the time it is executed. Fixes: c8a6153b6c59 ("vduse: Introd

[PATCH v3 3/3] vduse: Temporarily disable control queue features

2023-07-05 Thread Maxime Coquelin
Virtio-net driver control queue implementation is not safe when used with VDUSE. If the VDUSE application does not reply to control queue messages, it currently ends up hanging the kernel thread sending this command. Some work is on-going to make the control queue implementation robust with VDUSE.

[PATCH v3 1/3] vduse: validate block features only with block devices

2023-07-05 Thread Maxime Coquelin
This patch is preliminary work to enable network device type support to VDUSE. As VIRTIO_BLK_F_CONFIG_WCE shares the same value as VIRTIO_NET_F_HOST_TSO4, we need to restrict its check to Virtio-blk device type. Acked-by: Jason Wang Reviewed-by: Xie Yongji Signed-off-by: Maxime Coquelin --- d

[PATCH v3 0/3] vduse: add support for networking devices

2023-07-05 Thread Maxime Coquelin
This small series enables virtio-net device type in VDUSE. With it, basic operation have been tested, both with virtio-vdpa and vhost-vdpa using DPDK Vhost library series adding VDUSE support using split rings layout (merged in DPDK v23.07-rc1). Control queue support (and so multiqueue) has also b

[PATCH v3 2/3] vduse: enable Virtio-net device type

2023-07-05 Thread Maxime Coquelin
This patch adds Virtio-net device type to the supported devices types. Initialization fails if the device does not support VIRTIO_F_VERSION_1 feature, in order to guarantee the configuration space is read-only. Acked-by: Jason Wang Reviewed-by: Xie Yongji Signed-off-by: Maxime Coquelin --- dri

Re: [PATCH] vdpa: reject F_ENABLE_AFTER_DRIVER_OK if backend does not support it

2023-07-05 Thread Michael S. Tsirkin
On Wed, Jul 05, 2023 at 03:55:23PM +0800, Jason Wang wrote: > On Tue, Jul 4, 2023 at 6:38 PM Michael S. Tsirkin wrote: > > > > On Tue, Jul 04, 2023 at 12:25:32PM +0200, Eugenio Perez Martin wrote: > > > On Mon, Jul 3, 2023 at 4:52 PM Michael S. Tsirkin wrote: > > > > > > > > On Mon, Jul 03, 2023

Re: [PATCH] vdpa: reject F_ENABLE_AFTER_DRIVER_OK if backend does not support it

2023-07-05 Thread Michael S. Tsirkin
On Wed, Jul 05, 2023 at 03:49:58PM +0800, Jason Wang wrote: > On Tue, Jul 4, 2023 at 11:45 PM Michael S. Tsirkin wrote: > > > > On Tue, Jul 04, 2023 at 01:36:11PM +0200, Eugenio Perez Martin wrote: > > > On Tue, Jul 4, 2023 at 12:38 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Tue, Jul

Re: [PATCH] vdpa: reject F_ENABLE_AFTER_DRIVER_OK if backend does not support it

2023-07-05 Thread Jason Wang
On Tue, Jul 4, 2023 at 6:38 PM Michael S. Tsirkin wrote: > > On Tue, Jul 04, 2023 at 12:25:32PM +0200, Eugenio Perez Martin wrote: > > On Mon, Jul 3, 2023 at 4:52 PM Michael S. Tsirkin wrote: > > > > > > On Mon, Jul 03, 2023 at 04:22:18PM +0200, Eugenio Pérez wrote: > > > > With the current code

Re: [PATCH] vdpa: reject F_ENABLE_AFTER_DRIVER_OK if backend does not support it

2023-07-05 Thread Jason Wang
On Tue, Jul 4, 2023 at 11:45 PM Michael S. Tsirkin wrote: > > On Tue, Jul 04, 2023 at 01:36:11PM +0200, Eugenio Perez Martin wrote: > > On Tue, Jul 4, 2023 at 12:38 PM Michael S. Tsirkin wrote: > > > > > > On Tue, Jul 04, 2023 at 12:25:32PM +0200, Eugenio Perez Martin wrote: > > > > On Mon, Jul 3

Re: [PATCH] mlx5_vdpa: offer VHOST_BACKEND_F_ENABLE_AFTER_DRIVER_OK

2023-07-05 Thread Jason Wang
On Wed, Jul 5, 2023 at 2:16 PM Michael S. Tsirkin wrote: > > On Wed, Jul 05, 2023 at 01:47:44PM +0800, Jason Wang wrote: > > On Wed, Jul 5, 2023 at 1:31 PM Michael S. Tsirkin wrote: > > > > > > On Wed, Jul 05, 2023 at 01:11:37PM +0800, Jason Wang wrote: > > > > On Tue, Jul 4, 2023 at 6:16 PM Mich