Re: [PATCH v1] virtio-pci: Fix legacy device flag setting error in probe

2023-07-24 Thread Feng Liu via Virtualization
On 2023-07-24 p.m.11:41, Jason Wang wrote: External email: Use caution opening links or attachments On Mon, Jul 24, 2023 at 9:14 PM Feng Liu wrote: On 2023-07-20 p.m.1:14, Michael S. Tsirkin wrote: External email: Use caution opening links or attachments On Thu, Jul 20, 2023 at 10:27:

Re: [PATCH v1] virtio-pci: Fix legacy device flag setting error in probe

2023-07-24 Thread Jason Wang
On Mon, Jul 24, 2023 at 9:14 PM Feng Liu wrote: > > > > On 2023-07-20 p.m.1:14, Michael S. Tsirkin wrote: > > External email: Use caution opening links or attachments > > > > > > On Thu, Jul 20, 2023 at 10:27:04AM +0800, Jason Wang wrote: > >> On Wed, Jul 19, 2023 at 11:46 PM Feng Liu wrote: > >>

Re: [PATCH net-next v4 2/2] virtio-net: add cond_resched() to the command waiting loop

2023-07-24 Thread Jason Wang
On Mon, Jul 24, 2023 at 3:17 PM Michael S. Tsirkin wrote: > > On Mon, Jul 24, 2023 at 02:52:05PM +0800, Jason Wang wrote: > > On Sat, Jul 22, 2023 at 4:18 AM Maxime Coquelin > > wrote: > > > > > > > > > > > > On 7/21/23 17:10, Michael S. Tsirkin wrote: > > > > On Fri, Jul 21, 2023 at 04:58:04PM +

Re: [PATCH net-next v4 2/2] virtio-net: add cond_resched() to the command waiting loop

2023-07-24 Thread Jason Wang
On Mon, Jul 24, 2023 at 3:18 PM Michael S. Tsirkin wrote: > > On Mon, Jul 24, 2023 at 02:52:49PM +0800, Jason Wang wrote: > > On Mon, Jul 24, 2023 at 2:46 PM Michael S. Tsirkin wrote: > > > > > > On Fri, Jul 21, 2023 at 10:18:03PM +0200, Maxime Coquelin wrote: > > > > > > > > > > > > On 7/21/23 1

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-07-24 Thread Xuan Zhuo
On Mon, 24 Jul 2023 09:43:42 -0700, Christoph Hellwig wrote: > On Thu, Jul 20, 2023 at 01:21:07PM -0400, Michael S. Tsirkin wrote: > > Well I think we can add wrappers like virtio_dma_sync and so on. > > There are NOP for non-dma so passing the dma device is harmless. > > Yes, please. I am not

Re: [PATCH v1] vdpa: Complement vdpa_nl_policy for nlattr length check

2023-07-24 Thread Michael S. Tsirkin
On Mon, Jul 24, 2023 at 11:42:42AM +, Dragos Tatulea wrote: > On Mon, 2023-07-24 at 05:16 -0400, Michael S. Tsirkin wrote: > > On Mon, Jul 24, 2023 at 08:38:04AM +, Dragos Tatulea wrote: > > > > > > On Mon, 2023-07-24 at 15:11 +0800, Jason Wang wrote: > > > > On Sun, Jul 23, 2023 at 6:02 P

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-07-24 Thread Michael S. Tsirkin
On Thu, Jul 20, 2023 at 03:34:01PM +0800, Xuan Zhuo wrote: > On Wed, 19 Jul 2023 23:57:51 -0700, Christoph Hellwig > wrote: > > On Thu, Jul 20, 2023 at 02:45:14PM +0800, Xuan Zhuo wrote: > > > virtqueue_dma_dev() return the device that working with the DMA APIs. > > > Then that can be used like

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-07-24 Thread Christoph Hellwig
On Thu, Jul 20, 2023 at 01:21:07PM -0400, Michael S. Tsirkin wrote: > Well I think we can add wrappers like virtio_dma_sync and so on. > There are NOP for non-dma so passing the dma device is harmless. Yes, please. ___ Virtualization mailing list Virtual

Re: [PATCH v1] virtio-pci: Fix legacy device flag setting error in probe

2023-07-24 Thread Feng Liu via Virtualization
On 2023-07-20 p.m.1:14, Michael S. Tsirkin wrote: External email: Use caution opening links or attachments On Thu, Jul 20, 2023 at 10:27:04AM +0800, Jason Wang wrote: On Wed, Jul 19, 2023 at 11:46 PM Feng Liu wrote: The 'is_legacy' flag is used to differentiate between legacy vs modern de

Re: [PATCH v2 03/47] mm: shrinker: add infrastructure for dynamically allocating shrinker

2023-07-24 Thread Peter Zijlstra
On Mon, Jul 24, 2023 at 05:43:10PM +0800, Qi Zheng wrote: > +void shrinker_unregister(struct shrinker *shrinker) > +{ > + struct dentry *debugfs_entry; > + int debugfs_id; > + > + if (!shrinker || !(shrinker->flags & SHRINKER_REGISTERED)) > + return; > + > + down_write(

Re: [PATCH v1] vdpa: Complement vdpa_nl_policy for nlattr length check

2023-07-24 Thread Dragos Tatulea via Virtualization
On Mon, 2023-07-24 at 05:16 -0400, Michael S. Tsirkin wrote: > On Mon, Jul 24, 2023 at 08:38:04AM +, Dragos Tatulea wrote: > > > > On Mon, 2023-07-24 at 15:11 +0800, Jason Wang wrote: > > > On Sun, Jul 23, 2023 at 6:02 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Sun, Jul 23, 2023

Re: [PATCH v1] vdpa: Complement vdpa_nl_policy for nlattr length check

2023-07-24 Thread Michael S. Tsirkin
On Mon, Jul 24, 2023 at 08:38:04AM +, Dragos Tatulea wrote: > > On Mon, 2023-07-24 at 15:11 +0800, Jason Wang wrote: > > On Sun, Jul 23, 2023 at 6:02 PM Michael S. Tsirkin wrote: > > > > > > On Sun, Jul 23, 2023 at 05:48:46PM +0800, Lin Ma wrote: > > > > > > > > > Sure, that is another unde

Re: [PATCH v1] vdpa: Complement vdpa_nl_policy for nlattr length check

2023-07-24 Thread Dragos Tatulea via Virtualization
On Mon, 2023-07-24 at 15:11 +0800, Jason Wang wrote: > On Sun, Jul 23, 2023 at 6:02 PM Michael S. Tsirkin wrote: > > > > On Sun, Jul 23, 2023 at 05:48:46PM +0800, Lin Ma wrote: > > > > > > > Sure, that is another undergoing task I'm working on. If the nlattr is > > > > parsed with > > > > NL_VA

Re: [PATCH net-next V3 3/4] virtio_net: support per queue interrupt coalesce command

2023-07-24 Thread Michael S. Tsirkin
On Mon, Jul 24, 2023 at 06:40:47AM +0300, Gavin Li wrote: > Add interrupt_coalesce config in send_queue and receive_queue to cache user > config. > > Send per virtqueue interrupt moderation config to underline device in order > to have more efficient interrupt moderation and cpu utilization of gue

Re: [PATCH net-next v4 2/2] virtio-net: add cond_resched() to the command waiting loop

2023-07-24 Thread Michael S. Tsirkin
On Mon, Jul 24, 2023 at 02:52:49PM +0800, Jason Wang wrote: > On Mon, Jul 24, 2023 at 2:46 PM Michael S. Tsirkin wrote: > > > > On Fri, Jul 21, 2023 at 10:18:03PM +0200, Maxime Coquelin wrote: > > > > > > > > > On 7/21/23 17:10, Michael S. Tsirkin wrote: > > > > On Fri, Jul 21, 2023 at 04:58:04PM

Re: [PATCH net-next v4 2/2] virtio-net: add cond_resched() to the command waiting loop

2023-07-24 Thread Michael S. Tsirkin
On Mon, Jul 24, 2023 at 02:52:05PM +0800, Jason Wang wrote: > On Sat, Jul 22, 2023 at 4:18 AM Maxime Coquelin > wrote: > > > > > > > > On 7/21/23 17:10, Michael S. Tsirkin wrote: > > > On Fri, Jul 21, 2023 at 04:58:04PM +0200, Maxime Coquelin wrote: > > >> > > >> > > >> On 7/21/23 16:45, Michael S

Re: [PATCH v1] vdpa: Complement vdpa_nl_policy for nlattr length check

2023-07-24 Thread Jason Wang
On Sun, Jul 23, 2023 at 6:02 PM Michael S. Tsirkin wrote: > > On Sun, Jul 23, 2023 at 05:48:46PM +0800, Lin Ma wrote: > > > > > Sure, that is another undergoing task I'm working on. If the nlattr is > > > parsed with > > > NL_VALIDATE_UNSPEC, any forgotten nlattr will be rejected, therefore > >