Re: [PATCH net-next v4 0/4] vsock/virtio/vhost: MSG_ZEROCOPY preparations

2023-07-27 Thread Michael S. Tsirkin
On Fri, Jul 28, 2023 at 01:26:23AM +0300, Arseniy Krasnov wrote: > Hello, > > this patchset is first of three parts of another big patchset for > MSG_ZEROCOPY flag support: > https://lore.kernel.org/netdev/20230701063947.3422088-1-avkras...@sberdevices.ru/ overall looks good. Two points I'd like

Re: [PATCH net-next V4 2/3] virtio_net: support per queue interrupt coalesce command

2023-07-27 Thread Michael S. Tsirkin
On Thu, Jul 27, 2023 at 03:28:32PM +0200, Paolo Abeni wrote: > On Tue, 2023-07-25 at 16:07 +0300, Gavin Li wrote: > > Add interrupt_coalesce config in send_queue and receive_queue to cache user > > config. > > > > Send per virtqueue interrupt moderation config to underlying device in > > order to

Re: [PATCH net-next V4 2/3] virtio_net: support per queue interrupt coalesce command

2023-07-27 Thread Jason Wang
On Thu, Jul 27, 2023 at 9:28 PM Paolo Abeni wrote: > > On Tue, 2023-07-25 at 16:07 +0300, Gavin Li wrote: > > Add interrupt_coalesce config in send_queue and receive_queue to cache user > > config. > > > > Send per virtqueue interrupt moderation config to underlying device in > > order to have

Re: [PATCH] vdpa/mlx5: Correct default number of queues when MQ is on

2023-07-27 Thread Jason Wang
On Fri, Jul 28, 2023 at 1:25 AM Dragos Tatulea wrote: > > The standard specifies that the initial number of queues is the > default, which is 1 (1 tx, 1 rx). > > Signed-off-by: Dragos Tatulea > Reviewed-by: Eugenio Pérez Acked-by: Jason Wang Thanks > --- > drivers/vdpa/mlx5/net/mlx5_vnet.c

Re: [PATCH v3 28/49] dm zoned: dynamically allocate the dm-zoned-meta shrinker

2023-07-27 Thread Dave Chinner via Virtualization
On Thu, Jul 27, 2023 at 07:20:46PM +0900, Damien Le Moal wrote: > On 7/27/23 17:55, Qi Zheng wrote: > >>>   goto err; > >>>   } > >>>   +    zmd->mblk_shrinker->count_objects = dmz_mblock_shrinker_count; > >>> +    zmd->mblk_shrinker->scan_objects = dmz_mblock_shrinker_scan; > >>> +   

[PATCH 4/4] vdpa: Enable strict validation for netlinks ops

2023-07-27 Thread Dragos Tatulea via Virtualization
The previous patches added the missing nla policies that were required for validation to work. Now strict validation on netlink ops can be enabled. This patch does it. Signed-off-by: Dragos Tatulea Cc: sta...@vger.kernel.org --- drivers/vdpa/vdpa.c | 6 -- 1 file changed, 6 deletions(-)

[PATCH 3/4] vdpa: Add max vqp attr to vdpa_nl_policy for nlattr length check

2023-07-27 Thread Dragos Tatulea via Virtualization
From: Lin Ma The vdpa_nl_policy structure is used to validate the nlattr when parsing the incoming nlmsg. It will ensure the attribute being described produces a valid nlattr pointer in info->attrs before entering into each handler in vdpa_nl_ops. That is to say, the missing part in

[PATCH 2/4] vdpa: Add queue index attr to vdpa_nl_policy for nlattr length check

2023-07-27 Thread Dragos Tatulea via Virtualization
From: Lin Ma The vdpa_nl_policy structure is used to validate the nlattr when parsing the incoming nlmsg. It will ensure the attribute being described produces a valid nlattr pointer in info->attrs before entering into each handler in vdpa_nl_ops. That is to say, the missing part in

[PATCH 1/4] vdpa: Add features attr to vdpa_nl_policy for nlattr length check

2023-07-27 Thread Dragos Tatulea via Virtualization
From: Lin Ma The vdpa_nl_policy structure is used to validate the nlattr when parsing the incoming nlmsg. It will ensure the attribute being described produces a valid nlattr pointer in info->attrs before entering into each handler in vdpa_nl_ops. That is to say, the missing part in

[PATCH v3 0/4] vdpa: Enable strict validation for netlink ops

2023-07-27 Thread Dragos Tatulea via Virtualization
The original patch from Lin Ma enables the vdpa driver to use validation netlink ops. The patch got split into 3 parts for easier backporting. The last patch simply disables the validation skip which is no longer neccesary. Patchset started of from this discussion [0]. [0]

[PATCH] vdpa/mlx5: Correct default number of queues when MQ is on

2023-07-27 Thread Dragos Tatulea via Virtualization
The standard specifies that the initial number of queues is the default, which is 1 (1 tx, 1 rx). Signed-off-by: Dragos Tatulea Reviewed-by: Eugenio Pérez --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git

Re: [PATCH] vdpa/mlx5: Fix crash on shutdown for when no ndev exists

2023-07-27 Thread Michael S. Tsirkin
On Thu, Jul 27, 2023 at 04:02:16PM +, Dragos Tatulea wrote: > On Wed, 2023-07-26 at 15:26 -0400, Michael S. Tsirkin wrote: > > On Wed, Jul 26, 2023 at 10:07:38PM +0300, Dragos Tatulea wrote: > > > The ndev was accessed on shutdown without a check if it actually exists. > > > This triggered the

Re: [PATCH] vdpa/mlx5: Fix crash on shutdown for when no ndev exists

2023-07-27 Thread Dragos Tatulea via Virtualization
On Wed, 2023-07-26 at 15:26 -0400, Michael S. Tsirkin wrote: > On Wed, Jul 26, 2023 at 10:07:38PM +0300, Dragos Tatulea wrote: > > The ndev was accessed on shutdown without a check if it actually exists. > > This triggered the crash pasted below. This patch simply adds a check > > before using

Re: [PATCH net-next V4 2/3] virtio_net: support per queue interrupt coalesce command

2023-07-27 Thread Paolo Abeni
On Tue, 2023-07-25 at 16:07 +0300, Gavin Li wrote: > Add interrupt_coalesce config in send_queue and receive_queue to cache user > config. > > Send per virtqueue interrupt moderation config to underlying device in > order to have more efficient interrupt moderation and cpu utilization of > guest

Re: [PATCH net-next v4 2/2] virtio-net: add cond_resched() to the command waiting loop

2023-07-27 Thread Michael S. Tsirkin
On Thu, Jul 27, 2023 at 04:59:33PM +0800, Jason Wang wrote: > > They really shouldn't - any NIC that takes forever to > > program will create issues in the networking stack. > > Unfortunately, it's not rare as the device/cvq could be implemented > via firmware or software. Currently that mean

Re: [PATCH net-next v4 2/2] virtio-net: add cond_resched() to the command waiting loop

2023-07-27 Thread Jason Wang
On Thu, Jul 27, 2023 at 2:10 PM Michael S. Tsirkin wrote: > > On Thu, Jul 27, 2023 at 02:03:59PM +0800, Jason Wang wrote: > > On Wed, Jul 26, 2023 at 7:38 PM Michael S. Tsirkin wrote: > > > > > > On Wed, Jul 26, 2023 at 09:55:37AM +0800, Jason Wang wrote: > > > > On Tue, Jul 25, 2023 at 3:36 PM

Re: [PATCH net-next v3 4/4] vsock/virtio: MSG_ZEROCOPY flag support

2023-07-27 Thread Stefano Garzarella
On Thu, Jul 27, 2023 at 11:32:00AM +0300, Arseniy Krasnov wrote: On 25.07.2023 15:28, Stefano Garzarella wrote: On Tue, Jul 25, 2023 at 12:16:11PM +0300, Arseniy Krasnov wrote: On 25.07.2023 11:46, Arseniy Krasnov wrote: On 25.07.2023 11:43, Stefano Garzarella wrote: On Fri, Jul 21, 2023 at

Re: [PATCH RFC net-next v5 00/14] virtio/vsock: support datagrams

2023-07-27 Thread Michael S. Tsirkin
On Wed, Jul 19, 2023 at 12:50:04AM +, Bobby Eshleman wrote: > Hey all! > > This series introduces support for datagrams to virtio/vsock. > > It is a spin-off (and smaller version) of this series from the summer: > >

Re: [PATCH RFC net-next v5 10/14] virtio/vsock: add VIRTIO_VSOCK_F_DGRAM feature bit

2023-07-27 Thread Stefano Garzarella
On Wed, Jul 26, 2023 at 02:38:08PM -0400, Michael S. Tsirkin wrote: On Wed, Jul 19, 2023 at 12:50:14AM +, Bobby Eshleman wrote: This commit adds a feature bit for virtio vsock to support datagrams. Signed-off-by: Jiang Wang Signed-off-by: Bobby Eshleman ---

Re: [PATCH net-next v4 2/2] virtio-net: add cond_resched() to the command waiting loop

2023-07-27 Thread Michael S. Tsirkin
On Thu, Jul 27, 2023 at 02:03:59PM +0800, Jason Wang wrote: > On Wed, Jul 26, 2023 at 7:38 PM Michael S. Tsirkin wrote: > > > > On Wed, Jul 26, 2023 at 09:55:37AM +0800, Jason Wang wrote: > > > On Tue, Jul 25, 2023 at 3:36 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Tue, Jul 25, 2023

Re: [PATCH] virtio-vdpa: Fix cpumask memory leak in virtio_vdpa_find_vqs()

2023-07-27 Thread Jason Wang
On Thu, Jul 27, 2023 at 3:11 AM Dragos Tatulea wrote: > > From: Gal Pressman > > Free the cpumask allocated by create_affinity_masks() before returning > from the function. > > Fixes: 3dad56823b53 ("virtio-vdpa: Support interrupt affinity spreading > mechanism") > Signed-off-by: Gal Pressman >

Re: [PATCH net-next v4 2/2] virtio-net: add cond_resched() to the command waiting loop

2023-07-27 Thread Jason Wang
On Wed, Jul 26, 2023 at 7:38 PM Michael S. Tsirkin wrote: > > On Wed, Jul 26, 2023 at 09:55:37AM +0800, Jason Wang wrote: > > On Tue, Jul 25, 2023 at 3:36 PM Michael S. Tsirkin wrote: > > > > > > On Tue, Jul 25, 2023 at 11:07:40AM +0800, Jason Wang wrote: > > > > On Mon, Jul 24, 2023 at 3:17 PM