Re: [PATCH bpf-next 2/3] net: move struct netdev_rx_queue out of netdevice.h

2023-08-02 Thread Nambiar, Amritha
On 8/1/2023 5:32 PM, Jakub Kicinski wrote: struct netdev_rx_queue is touched in only a few places and having it defined in netdevice.h brings in the dependency on xdp.h, because struct xdp_rxq_info gets embedded in struct netdev_rx_queue. In prep for removal of xdp.h from netdevice.h move all

[PATCH 2/2] vdpa/mlx5: Delete control vq iotlb in destroy_mr only when necessary

2023-08-02 Thread Dragos Tatulea via Virtualization
From: Eugenio Pérez mlx5_vdpa_destroy_mr can be called from .set_map with data ASID after the control virtqueue ASID iotlb has been populated. The control vq iotlb must not be cleared, since it will not be populated again. So call the ASID aware destroy function which makes sure that the right

[PATCH 1/2] vdpa/mlx5: Fix mr->initialized semantics

2023-08-02 Thread Dragos Tatulea via Virtualization
The mr->initialized flag is shared between the control vq and data vq part of the mr init/uninit. But if the control vq and data vq get placed in different ASIDs, it can happen that initializing the control vq will prevent the data vq mr from being initialized. This patch consolidates the control

[PATCH 0/2] vdpa/mlx5: Fixes for ASID handling

2023-08-02 Thread Dragos Tatulea via Virtualization
This patch series is based on Eugenio's fix for handling CVQs in a different ASID [0]. The first patch is the actual fix. The next 2 patches are fixing a possible issue that I found while implementing patch 1. The patches are ordered like this for clarity. [0]

Re: [RFC] iommu/virtio: Use single flush queue (EXPERIMENTAL)

2023-08-02 Thread Jason Gunthorpe
On Wed, Aug 02, 2023 at 01:36:12PM +0100, Jean-Philippe Brucker wrote: > automatically get plugged into a VM without user intervention. Here I > guess the devices we don't trust will be virtual devices implemented by > other VMs. We don't have any method to identify them yet, so > iommu.strict=1

Re: [RFC] iommu/virtio: Use single flush queue (EXPERIMENTAL)

2023-08-02 Thread Jean-Philippe Brucker
Hi Niklas, On Wed, Jul 26, 2023 at 01:14:33PM +0200, Niklas Schnelle wrote: > Just like on paged s390 guests with their virtual IOMMU, syncing > mappings via virtio-iommu is quite expensive. It can thus benefit from > queueing unmapped IOVAs and flushing them in batches but less so from >

Re: [RFC PATCH v1 2/2] test/vsock: shutdowned socket test

2023-08-02 Thread Stefano Garzarella
On Tue, Aug 01, 2023 at 05:17:27PM +0300, Arseniy Krasnov wrote: This adds two tests for 'shutdown()' call. It checks that SIGPIPE is sent when MSG_NOSIGNAL is not set and vice versa. Both flags SHUT_WR and SHUT_RD are tested. Signed-off-by: Arseniy Krasnov --- tools/testing/vsock/vsock_test.c

Re: [PATCH] vdpa/mlx5: Fix crash on shutdown for when no ndev exists

2023-08-02 Thread Dragos Tatulea via Virtualization
On Wed, 2023-08-02 at 10:51 +0800, Jason Wang wrote: > On Tue, Aug 1, 2023 at 4:17 PM Dragos Tatulea wrote: > > > > On Tue, 2023-08-01 at 11:59 +0800, Jason Wang wrote: > > > On Mon, Jul 31, 2023 at 5:08 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Mon, Jul 31, 2023 at 07:15:31AM

Re: [RFC PATCH v1 1/2] vsock: send SIGPIPE on write to shutdowned socket

2023-08-02 Thread Stefano Garzarella
On Tue, Aug 01, 2023 at 05:17:26PM +0300, Arseniy Krasnov wrote: POSIX requires to send SIGPIPE on write to SOCK_STREAM socket which was shutdowned with SHUT_WR flag or its peer was shutdowned with SHUT_RD flag. Also we must not send SIGPIPE if MSG_NOSIGNAL flag is set. Signed-off-by: Arseniy