Re: [PATCH vfio 11/11] vfio/virtio: Introduce a vfio driver over virtio devices

2023-09-24 Thread Zhu, Lingshan
On 9/22/2023 4:55 AM, Michael S. Tsirkin wrote: On Thu, Sep 21, 2023 at 04:51:15PM -0300, Jason Gunthorpe wrote: On Thu, Sep 21, 2023 at 03:17:25PM -0400, Michael S. Tsirkin wrote: On Thu, Sep 21, 2023 at 03:39:26PM -0300, Jason Gunthorpe wrote: What is the huge amount of work am I asking

[PATCH 1/2] virtio_pci: fix the common map size and add check for vq-reset

2023-09-24 Thread Xuan Zhuo
Now, the function vp_modern_map_capability() takes the size parameter, which corresponds to the size of virtio_pci_common_cfg. As a result, the pci_iomap_range() function maps the memory area for virtio_pci_common_cfg. However, if the _F_RING_RESET is negotiated, the extra items will be used.

[PATCH 0/2] strictly check the acccess to the common cfg

2023-09-24 Thread Xuan Zhuo
1. fix the length of the pci_iomap_range() to the common cfg 2. add check to the reset offset 3. add build check to the new common cfg items Xuan Zhuo (2): virtio_pci: fix the common map size and add check for vq-reset virtio_pci: add build offset check for the new common cfg items

[PATCH 2/2] virtio_pci: add build offset check for the new common cfg items

2023-09-24 Thread Xuan Zhuo
Add checks to the check_offsets(void) for queue_notify_data and queue_reset. Signed-off-by: Xuan Zhuo --- drivers/virtio/virtio_pci_modern_dev.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/virtio/virtio_pci_modern_dev.c b/drivers/virtio/virtio_pci_modern_dev.c index

Re: [PATCH vfio 07/11] virtio-pci: Introduce admin commands

2023-09-24 Thread kernel test robot
Hi Yishai, kernel test robot noticed the following build warnings: [auto build test WARNING on awilliam-vfio/for-linus] [also build test WARNING on linus/master v6.6-rc3 next-20230921] [cannot apply to awilliam-vfio/next] [If your patch is applied to the wrong git tree, kindly drop us a note.

Re: [RFC v2 4/4] vduse: Add new ioctl VDUSE_GET_RECONNECT_INFO

2023-09-24 Thread Jason Wang
On Thu, Sep 21, 2023 at 10:07 PM Cindy Lu wrote: > > On Mon, Sep 18, 2023 at 4:49 PM Jason Wang wrote: > > > > On Tue, Sep 12, 2023 at 11:01 AM Cindy Lu wrote: > > > > > > In VDUSE_GET_RECONNECT_INFO, the Userspace App can get the map size > > > and The number of mapping memory pages from the

Re: [PATCH vfio 11/11] vfio/virtio: Introduce a vfio driver over virtio devices

2023-09-24 Thread Jason Wang
On Fri, Sep 22, 2023 at 8:11 PM Jason Gunthorpe wrote: > > On Fri, Sep 22, 2023 at 11:01:23AM +0800, Jason Wang wrote: > > > > Even when it does, there is no real use case to live migrate a > > > virtio-net function from, say, AWS to GCP. > > > > It can happen inside a single cloud vendor. For

Re: [PATCH vfio 11/11] vfio/virtio: Introduce a vfio driver over virtio devices

2023-09-24 Thread Jason Wang
On Fri, Sep 22, 2023 at 8:25 PM Parav Pandit wrote: > > > > From: Jason Gunthorpe > > Sent: Friday, September 22, 2023 5:53 PM > > > > > And what's more, using MMIO BAR0 then it can work for legacy. > > > > Oh? How? Our team didn't think so. > > It does not. It was already discussed. > The

Re: [PATCH net 5/6] virtio-net: fix the vq coalescing setting for vq resize

2023-09-24 Thread Jason Wang
On Fri, Sep 22, 2023 at 5:56 PM Xuan Zhuo wrote: > > On Fri, 22 Sep 2023 15:32:39 +0800, Jason Wang wrote: > > On Fri, Sep 22, 2023 at 1:02 PM Heng Qi wrote: > > > > > > > > > > > > 在 2023/9/22 下午12:29, Jason Wang 写道: > > > > On Tue, Sep 19, 2023 at 3:49 PM Heng Qi > > > > wrote: > > > >>

Re: [PATCH net 5/6] virtio-net: fix the vq coalescing setting for vq resize

2023-09-24 Thread Jason Wang
On Fri, Sep 22, 2023 at 3:58 PM Heng Qi wrote: > > > > 在 2023/9/22 下午3:32, Jason Wang 写道: > > On Fri, Sep 22, 2023 at 1:02 PM Heng Qi wrote: > >> > >> > >> 在 2023/9/22 下午12:29, Jason Wang 写道: > >>> On Tue, Sep 19, 2023 at 3:49 PM Heng Qi wrote: > According to the definition of virtqueue

Re: [PATCH v14 30/42] virtio_pci: introduce helper to get/set queue reset

2023-09-24 Thread Xuan Zhuo
On Fri, 22 Sep 2023 06:46:39 -0400, "Michael S. Tsirkin" wrote: > On Fri, Sep 22, 2023 at 09:49:18AM +0800, Xuan Zhuo wrote: > > On Thu, 21 Sep 2023 10:02:53 -0400, "Michael S. Tsirkin" > > wrote: > > > On Mon, Aug 01, 2022 at 02:38:50PM +0800, Xuan Zhuo wrote: > > > > Introduce new helpers to

Re: virtio-sound linux driver conformance to spec

2023-09-24 Thread Anton Yakovlev via Virtualization
Hello Matias, On 20.09.2023 22:18, Matias Ezequiel Vara Larsen wrote: On Tue, Sep 19, 2023 at 11:52:27AM -0400, Michael S. Tsirkin wrote: On Tue, Sep 19, 2023 at 04:18:57PM +0200, Matias Ezequiel Vara Larsen wrote: On Tue, Sep 19, 2023 at 05:43:56AM -0400, Michael S. Tsirkin wrote: On Wed,

Re: virtio-sound linux driver conformance to spec

2023-09-24 Thread Anton Yakovlev via Virtualization
Hello Michael, On 20.09.2023 00:52, Michael S. Tsirkin wrote: On Tue, Sep 19, 2023 at 04:18:57PM +0200, Matias Ezequiel Vara Larsen wrote: On Tue, Sep 19, 2023 at 05:43:56AM -0400, Michael S. Tsirkin wrote: On Wed, Sep 13, 2023 at 05:04:24PM +0200, Matias Ezequiel Vara Larsen wrote: Hello,

Re: [virtio-comment] Re: virtio-sound linux driver conformance to spec

2023-09-24 Thread Anton Yakovlev via Virtualization
Hello Stefan, On 20.09.2023 00:10, Stefan Hajnoczi wrote: As an aside, here are two other statements that have a similar issue: - 2.6.1.1.2 "the driver MAY release any resource associated with that virtqueue" (instead 2.6.1.1.1 should have something like "After a queue has been reset by the

Re: [virtio-comment] Re: virtio-sound linux driver conformance to spec

2023-09-24 Thread Anton Yakovlev via Virtualization
Hello Paolo, On 19.09.2023 15:58, Paolo Bonzini wrote: On 9/19/23 02:35, Anton Yakovlev wrote: If the Linux virtio sound driver violates a specification, then there must be a conformance statement that the driver does not follow. As far as I know, there is no such thing at the moment. There

Re: [PATCH v2] virtio_balloon: Fix endless deflation and inflation on arm64

2023-09-24 Thread Gavin Shan
Hi David and Michael, On 8/31/23 11:10, Gavin Shan wrote: The deflation request to the target, which isn't unaligned to the guest page size causes endless deflation and inflation actions. For example, we receive the flooding QMP events for the changes on memory balloon's size after a deflation

Re: virtcrypto_dataq_callback calls crypto_finalize_request() from irq context

2023-09-24 Thread Halil Pasic
On Sun, 24 Sep 2023 11:56:25 + "Gonglei (Arei)" wrote: > Hi Halil, > > Commit 4058cf08945 introduced a check for detecting crypto completion > function > called with enable BH, and indeed the virtio-crypto driver didn't disable BH, > which needs > a patch to fix it. > > P.S.: >

RE: virtcrypto_dataq_callback calls crypto_finalize_request() from irq context

2023-09-24 Thread Gonglei (Arei) via Virtualization
Hi Halil, Commit 4058cf08945 introduced a check for detecting crypto completion function called with enable BH, and indeed the virtio-crypto driver didn't disable BH, which needs a patch to fix it. P.S.: https://lore.kernel.org/lkml/20220221120833.2618733-5-cla...@baylibre.com/T/ Regards,

WorldCIST'24 - 12nd World Conference on Information Systems and Technologies | Lodz, Poland

2023-09-24 Thread WorldCIST-24
* CORE Conference ** Google Scholar H5-Index = 25 *** Indexed in Scopus, WoS, DBLP, etc. -- -- -- - WorldCIST'24 - The 12th World Conference on Information Systems and

Re: [PATCH 5/9] drm/nouveau/pm: Annotate struct nvkm_perfdom with __counted_by

2023-09-24 Thread Gustavo A. R. Silva
On 9/22/23 11:32, Kees Cook wrote: Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and