Re: [PATCH v3 5/8] iommufd: Associate fault object with iommufd_hw_pgtable

2024-03-06 Thread Baolu Lu
On 2024/3/7 0:01, Jason Gunthorpe wrote: On Wed, Mar 06, 2024 at 11:15:50PM +0800, Zhangfei Gao wrote: Double checked, this does not send flags, 0 is OK, Only domain_alloc_user in iommufd_hwpt_paging_alloc requires flags. In my debug, I need this patch, otherwise NULL pointer errors happen

Re: [PATCH v3 5/8] iommufd: Associate fault object with iommufd_hw_pgtable

2024-03-06 Thread Jason Gunthorpe
On Wed, Mar 06, 2024 at 11:15:50PM +0800, Zhangfei Gao wrote: > > Double checked, this does not send flags, 0 is OK, > Only domain_alloc_user in iommufd_hwpt_paging_alloc requires flags. > > In my debug, I need this patch, otherwise NULL pointer errors happen > since SVA is not set. This is

Re: [PATCH v3 5/8] iommufd: Associate fault object with iommufd_hw_pgtable

2024-03-06 Thread Zhangfei Gao
Hi, Baolu On Sat, 2 Mar 2024 at 10:36, Zhangfei Gao wrote: > > On Mon, 22 Jan 2024 at 15:46, Lu Baolu wrote: > > > > When allocating a user iommufd_hw_pagetable, the user space is allowed to > > associate a fault object with the hw_pagetable by specifying the fault > > object ID in the page