Re: [vmw_vmci 11/11] Apply the header code to make VMCI build

2012-07-27 Thread Alan Cox
+enum { + VMCI_SUCCESS_QUEUEPAIR_ATTACH = 5, + VMCI_SUCCESS_QUEUEPAIR_CREATE = 4, + VMCI_SUCCESS_LAST_DETACH= 3, + VMCI_SUCCESS_ACCESS_GRANTED = 2, + VMCI_SUCCESS_ENTRY_DEAD = 1, We've got a nice collection of Linux error codes than you, and it would

Re: [PATCH] vhost-net: add module alias (v2.1)

2012-01-16 Thread Alan Cox
ACKs, NACKs? What is happening here? I would like an Ack from Alan Cox who switched vhost-net to a dynamic minor in the first place, in commit 79907d89c397b8bc2e05b347ec94e928ea919d33. Sorry dev...@lanana.org isn't yet back from the kernel hack incident. I don't read netdev so someone

Re: [PATCH] vhost-net: add module alias (v2.1)

2012-01-16 Thread Alan Cox
Also: - use C99 style initialization. - add missing entry in documentation for loop-control Signed-off-by: Stephen Hemminger shemmin...@vyatta.com For the device allocation Acked-by: Alan Cox devi...@lanana.org ___ Virtualization mailing list

Re: [RFC 0/0] Introducing a generic socket offload framework

2011-08-19 Thread Alan Cox
I have no desire to change the 'genericness' of sockets.. just the opposite - i wish to introduce the notion that sockets (can be) completely generic (when offloaded) as far as the guest is concerned. I suppose my concern is that you don't want to design for a specific offload device, your

Re: [RFC 0/0] Introducing a generic socket offload framework

2011-08-18 Thread Alan Cox
The Berkeley sockets coprocessor is a virtual PCI device which has the ability to offload socket activity from an unmodified application at the BSD sockets Ok I think there is an important question here. Why is this being designed for a specific virtual interface. Unix has always had the notion

Re: [RFC 0/0] Introducing a generic socket offload framework

2011-08-18 Thread Alan Cox
Q: whay happens about in process socket syscalls in another thread ? Thats always been the ugly in these cases either by intercepting or by swapping file operations on an object. Sorry I meant in progress 8) ___ Virtualization mailing list

Re: Large Patch Series in Email (was Re: [PATCH 0000/0117] Staging: hv: Driver cleanup)

2011-07-15 Thread Alan Cox
Do not send more than 15 patches at once to the vger mailing lists!!! and, accordingly, I went to the trouble of setting up a GitHub account to host a repo from which I could issue *one* single PULL request email; I get a little miffed every time my inbox gets blasted with hundreds of

Re: [PATCH] virtio_console: Add support for multiple ports for generic guest and host communication

2009-09-21 Thread Alan Cox
Again, this is paravirtual serial device and I think it's entirely reasonable for people to hook up these ports in the guest directly to physical serial devices in the host. virtio doesn't support all those features. I fail to see how this is at all relevant. This is a virtual machine,

Re: [PATCH] virtio_console: Add support for multiple ports for generic guest and host communication

2009-09-16 Thread Alan Cox
This device is very much a serial port. I don't see any reason not to treat it like one. Here are a few - You don't need POSIX multi-open semantics, hangup and the like - Seek makes sense on some kinds of fixed attributes - TTY has a relatively large memory overhead per device - Sysfs is what

Re: [PATCH] virtio_console: Add support for multiple ports for generic guest and host communication

2009-09-11 Thread Alan Cox
The interface presented to guest userspace is of a simple char device, so it can be used like this: fd = open(/dev/vcon2, O_RDWR); ret = read(fd, buf, 100); ret = write(fd, string, strlen(string)); Each port is to be assigned a unique function, for example, the first 4 ports

Re: Extending virtio_console to support multiple ports

2009-08-27 Thread Alan Cox
- Then, are we certain that there's no case where the tty layer will call us with some lock held or in an atomic context ? To be honest, I've totally lost track of the locking rules in tty land lately so it might well be ok, but something to verify. Some of the less well behaved line

Re: [PATCH 4/7] blkio-cgroup: The body of blkio-cgroup

2009-05-04 Thread Alan Cox
few minor coding style issues reported by checkpatch.pl: checkpatch is a *guide* not some dictator of style. If it's more readable the way it is, or it's following existing style (eg with the export symbols in a group at the bottom) then checkpatch is best ignored.

Re: [PATCH] Add I/O hypercalls for i386 paravirt

2007-08-22 Thread Alan Cox
out is usually a single byte. Shouldn't be very expensive to decode. In fact it should be roughly equivalent to your hypercall multiplex. Why is a performance critical path on a paravirt kernel even using I/O instructions and not paravirtual device drivers ? It clearly makes sense to

Re: [PATCH] Add I/O hypercalls for i386 paravirt

2007-08-22 Thread Alan Cox
I still think it's preferable to change some drivers than everybody. AFAIK BusLogic as real hardware is pretty much dead anyways, so you're probably the only primary user of it anyways. Go wild on it! I don't believe anyone is materially maintaining the buslogic driver and in time its going

Re: [PATCH] [545/2many] MAINTAINERS - XEN HYPERVISOR INTERFACE

2007-08-13 Thread Alan Cox
Agreed. But not everyone wants to or should have to use git, so what are the alternatives? Export the recent git history each release into an XML file at known locations on the kernel web site. Wait for tools to appear ___ Virtualization mailing list

Re: [PATCH 23/25] [PATCH] paravirt hooks for arch initialization

2007-08-10 Thread Alan Cox
On Fri, 10 Aug 2007 15:08:35 -0300 Glauber de Oliveira Costa [EMAIL PROTECTED] wrote: On 8/9/07, Alan Cox [EMAIL PROTECTED] wrote: What's the EBDA actually used for? The only place which seems to use ebda_addr is in the e820 code to avoid that area as RAM. It belongs to the firmware

Re: [PATCH 1/7] lguest: documentation pt I: Preparation

2007-07-24 Thread Alan Cox
There once was a virtualization coder, Whose patches kept getting older, Each time upstream would drop, His documentation would slightly rot, SO APPLY MY FUCKING PATCHES OR I'LL KEEP WRITING LIMERICKS. There once was a man they called rusty Who patches were terribly crusty Though his

Re: [PATCH 1/7] lguest: documentation pt I: Preparation

2007-07-24 Thread Alan Cox
On Tue, 24 Jul 2007 20:28:14 +1000 Rusty Russell [EMAIL PROTECTED] wrote: On Tue, 2007-07-24 at 10:52 +0100, Alan Cox wrote: There once was a virtualization coder, Whose patches kept getting older, Each time upstream would drop, His documentation would slightly rot, SO APPLY