Re: [PATCH v4 11/11] rpmsg: Fix kfree() of static memory on setting driver_override

2022-03-13 Thread Bjorn Andersson
d helper to set driver_override properly. > > Fixes: 950a7388f02b ("rpmsg: Turn name service into a stand alone driver") > Fixes: c0cdc19f84a4 ("rpmsg: Driver for user space endpoint interface") > Cc: > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bjorn

Re: [PATCH v3 11/11] rpmsg: Fix kfree() of static memory on setting driver_override

2022-03-11 Thread Bjorn Andersson
d helper to set driver_override properly. > > Fixes: 950a7388f02b ("rpmsg: Turn name service into a stand alone driver") > Fixes: c0cdc19f84a4 ("rpmsg: Driver for user space endpoint interface") > Cc: > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bjorn

Re: [PATCH v2 4/4] bus: Make remove callback return void

2021-07-06 Thread Bjorn Andersson
On Tue 06 Jul 13:43 CDT 2021, Uwe Kleine-K?nig wrote: > Hello Bjorn, > > On Tue, Jul 06, 2021 at 01:08:18PM -0500, Bjorn Andersson wrote: > > On Tue 06 Jul 10:48 CDT 2021, Uwe Kleine-K?nig wrote: > > > diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c

Re: [PATCH v2 4/4] bus: Make remove callback return void

2021-07-06 Thread Bjorn Andersson
ted buses return an ignored error code and so don't anticipate > wrong expectations for driver authors. > Thanks for doing this! Acked-by: Bjorn Andersson (rpmsg and apr) [..] > diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c > index c1404d3dae2c..7f6fac618

Re: [PATCH V3 1/3] gpio: Add virtio-gpio driver

2021-06-21 Thread Bjorn Andersson
On Wed 16 Jun 10:52 CDT 2021, Enrico Weigelt, metux IT consult wrote: > On 16.06.21 05:30, Bjorn Andersson wrote: > > > Combined with the virtio-i2c effort this could provide an alternative by > > simply tunneling the busses and GPIOs into Linux and use standard iio > >

Re: [PATCH V3 1/3] gpio: Add virtio-gpio driver

2021-06-15 Thread Bjorn Andersson
On Thu 10 Jun 15:46 CDT 2021, Linus Walleij wrote: [..] > Yet another usecase would be to jit this with remoteproc/rpmsg > and let a specific signal processor or real-time executive on > another CPU with a few GPIOs around present these to > Linux using this mechanism. Well that would certainly

Re: [PATCH] virtio_ring: switch to dma_XX barriers for rpmsg

2018-06-04 Thread Bjorn Andersson
On Thu 19 Apr 10:48 PDT 2018, Paolo Bonzini wrote: > On 19/04/2018 19:46, Michael S. Tsirkin wrote: > >> This should be okay, but I wonder if there should be a virtio_wmb(...) > >> or an "if (weak_barriers) wmb()" before the "writel" in vm_notify > >> (drivers/virtio/virtio_mmio.c). > >> > >>

Re: [PATCH] virtio_ring: switch to dma_XX barriers for rpmsg

2018-06-04 Thread Bjorn Andersson
ex filename > 11392 820 0 122122fb4 drivers/virtio/virtio_ring.o > > After > mst@tuck linux]$ size drivers/virtio/virtio_ring.o >textdata bss dec hex filename > 11284 820 0 121042f48 drivers/virtio/virtio_ring.o > > Cc

Re: [PATCH v5 4/4] virtio_remoteproc: correct put_device virtio_device.dev

2018-01-02 Thread Bjorn Andersson
On Thu 21 Dec 04:40 PST 2017, weiping zhang wrote: > rproc_virtio_dev_release will be called iff virtio_device.dev's > reference count drops to 0. Here we just put vdev.dev, and then > rproc->dev's cleanup will be done in rproc_virtio_dev_release. > > Signed-off-by: weiping zhang

Re: [PATCH 1/6] virtio: wrap find_vqs

2017-04-01 Thread Bjorn Andersson
On Wed 29 Mar 13:48 PDT 2017, Michael S. Tsirkin wrote: > We are going to add more parameters to find_vqs, let's wrap the call so > we don't need to tweak all drivers every time. > > Signed-off-by: Michael S. Tsirkin <m...@redhat.com> Acked-by: Bjorn Andersson <bjorn

Re: [PATCH v9 17/19] drm/virtio: kconfig: Fix recursive dependency issue.

2016-09-27 Thread Bjorn Andersson
On Wed 21 Sep 05:09 PDT 2016, Emil Velikov wrote: > On 20 September 2016 at 09:32, Peter Griffin wrote: > > Hi Emil, > > > > On Tue, 20 Sep 2016, Emil Velikov wrote: > > > >> On 5 September 2016 at 14:16, Peter Griffin > >> wrote: > >> >

Re: [PATCH v9 00/19] Add support for FDMA DMA controller and slim core rproc found on STi chipsets

2016-09-13 Thread Bjorn Andersson
On Tue 13 Sep 02:31 PDT 2016, Peter Griffin wrote: > Hi Vinod & Bjorn, > > [..] > > On Mon, 05 Sep 2016, Peter Griffin wrote: > > > v8 actions some review feedback from Bjorn to the slim rproc driver, and > > also includes > > a patch which fixes a recursive Kconfig error which is triggered

Re: [PATCH v9 01/19] remoteproc: st_slim_rproc: add a slimcore rproc driver

2016-09-13 Thread Bjorn Andersson
fully with fdma driver. > > Signed-off-by: Peter Griffin <peter.grif...@linaro.org> Acked-by: Bjorn Andersson <bjorn.anders...@linaro.org> Regards, Bjorn > --- > drivers/remoteproc/Kconfig | 4 + > drivers/remoteproc/Makefile | 1 + >

Re: [PATCH v8 01/18] remoteproc: st_slim_rproc: add a slimcore rproc driver

2016-08-30 Thread Bjorn Andersson
On Tue 30 Aug 05:34 PDT 2016, Lee Jones wrote: Thanks for your review Lee. > On Fri, 26 Aug 2016, Peter Griffin wrote: [..] > > diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig > > index 1a8bf76a..06765e0 100644 > > --- a/drivers/remoteproc/Kconfig > > +++

Re: [PATCH] virtio: make find_vqs() checkpatch.pl-friendly

2015-12-28 Thread Bjorn Andersson
virtgpu_kms.c, and virtio_rpmsg_bus.c to use the checkpatch.pl-friendly > type. > > Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> Acked-by: Bjorn Andersson <bjorn.anders...@sonymobile.com> Regards, Bjorn > --- > Compile-tested drivers/virtio/ but not the