On Mon, 14 Mar 2022, Michael S. Tsirkin wrote:
> On Mon, Mar 14, 2022 at 08:43:02AM +0000, Lee Jones wrote:
> > vhost_vsock_handle_tx_kick() already holds the mutex during its call
> > to vhost_get_vq_desc(). All we have to do here is take the same lock
> > during virt
conditions which may pop up over time.
Cc:
Signed-off-by: Lee Jones
---
drivers/vhost/vhost.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index 59edb5a1ffe28..bbaff6a5e21b8 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
2022 at 09:15:27AM +, Lee Jones wrote:
> > > > > On Tue, 08 Mar 2022, Greg KH wrote:
> > > > >
> > > > > > On Tue, Mar 08, 2022 at 08:10:06AM +, Lee Jones wrote:
> > > > > > > On Mon, 07 Mar 2022, Greg
On Tue, 08 Mar 2022, Greg KH wrote:
> On Tue, Mar 08, 2022 at 09:15:27AM +0000, Lee Jones wrote:
> > On Tue, 08 Mar 2022, Greg KH wrote:
> >
> > > On Tue, Mar 08, 2022 at 08:10:06AM +, Lee Jones wrote:
> > > > On Mon, 07 Mar 2022, Greg KH wrote:
> >
On Tue, 08 Mar 2022, Greg KH wrote:
> On Tue, Mar 08, 2022 at 08:10:06AM +0000, Lee Jones wrote:
> > On Mon, 07 Mar 2022, Greg KH wrote:
> >
> > > On Mon, Mar 07, 2022 at 07:17:57PM +, Lee Jones wrote:
> > > > vhost_vsock_handle_tx_kick() alr
On Tue, 08 Mar 2022, Lee Jones wrote:
> On Mon, 07 Mar 2022, Greg KH wrote:
>
> > On Mon, Mar 07, 2022 at 07:17:57PM +0000, Lee Jones wrote:
> > > vhost_vsock_handle_tx_kick() already holds the mutex during its call
> > > to vhost_get_vq_desc(). All we have to
On Mon, 07 Mar 2022, Greg KH wrote:
> On Mon, Mar 07, 2022 at 07:17:57PM +0000, Lee Jones wrote:
> > vhost_vsock_handle_tx_kick() already holds the mutex during its call
> > to vhost_get_vq_desc(). All we have to do here is take the same lock
> > during virtqueue cle
On Tue, 08 Mar 2022, Jason Wang wrote:
> On Tue, Mar 8, 2022 at 3:18 AM Lee Jones wrote:
> >
> > vhost_vsock_handle_tx_kick() already holds the mutex during its call
> > to vhost_get_vq_desc(). All we have to do here is take the same lock
> > during virtque
On Mon, 07 Mar 2022, Michael S. Tsirkin wrote:
> On Mon, Mar 07, 2022 at 07:17:57PM +0000, Lee Jones wrote:
> > vhost_vsock_handle_tx_kick() already holds the mutex during its call
> > to vhost_get_vq_desc(). All we have to do here is take the same lock
> > during virt
conditions which may pop up over time.
Link: https://syzkaller.appspot.com/bug?extid=279432d30d825e63ba00
Cc:
Reported-by: syzbot+adc3cb32385586bec...@syzkaller.appspotmail.com
Signed-off-by: Lee Jones
---
drivers/vhost/vhost.c | 10 ++
1 file changed, 10 insertions(+)
diff --git
On Fri, 04 Mar 2022, Michael S. Tsirkin wrote:
> On Wed, Mar 02, 2022 at 07:54:21AM +0000, Lee Jones wrote:
> > vhost_vsock_handle_tx_kick() already holds the mutex during its call
> > to vhost_get_vq_desc(). All we have to do is take the same lock
> > during virtqueue cle
On Fri, 04 Mar 2022, Michael S. Tsirkin wrote:
> On Wed, Mar 02, 2022 at 07:54:21AM +0000, Lee Jones wrote:
> > vhost_vsock_handle_tx_kick() already holds the mutex during its call
> > to vhost_get_vq_desc(). All we have to do is take the same lock
> > during virtqueue cle
On Fri, 04 Mar 2022, Stefano Garzarella wrote:
> On Thu, Mar 03, 2022 at 04:01:06PM -0500, Michael S. Tsirkin wrote:
> > On Thu, Mar 03, 2022 at 09:14:36PM +0200, Leon Romanovsky wrote:
> > > On Thu, Mar 03, 2022 at 03:19:29PM +, Lee Jones wrote:
> > > > All
On Fri, 04 Mar 2022, Leon Romanovsky wrote:
> On Thu, Mar 03, 2022 at 04:01:06PM -0500, Michael S. Tsirkin wrote:
> > On Thu, Mar 03, 2022 at 09:14:36PM +0200, Leon Romanovsky wrote:
> > > On Thu, Mar 03, 2022 at 03:19:29PM +, Lee Jones wrote:
> > > > All workers
On Thu, 03 Mar 2022, Leon Romanovsky wrote:
> On Thu, Mar 03, 2022 at 03:19:29PM +0000, Lee Jones wrote:
> > All workers/users should be halted before any clean-up should take place.
> >
> > Suggested-by: Michael S. Tsirkin
> > Signed-off-by: Lee Jones
> > -
All workers/users should be halted before any clean-up should take place.
Suggested-by: Michael S. Tsirkin
Signed-off-by: Lee Jones
---
drivers/vhost/vhost.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index bbaff6a5e21b8..d935d2506963f
On Wed, 02 Mar 2022, Stefano Garzarella wrote:
> On Wed, Mar 02, 2022 at 04:49:17PM +0000, Lee Jones wrote:
> > On Wed, 02 Mar 2022, Michael S. Tsirkin wrote:
> >
> > > On Wed, Mar 02, 2022 at 05:28:31PM +0100, Stefano Garzarella wrote:
> > > > On Wed, Mar
On Wed, 02 Mar 2022, Michael S. Tsirkin wrote:
> On Wed, Mar 02, 2022 at 05:28:31PM +0100, Stefano Garzarella wrote:
> > On Wed, Mar 2, 2022 at 3:57 PM Lee Jones wrote:
> > >
> > > On Wed, 02 Mar 2022, Michael S. Tsirkin wrote:
> > >
> > > > On
On Wed, 02 Mar 2022, Michael S. Tsirkin wrote:
> On Wed, Mar 02, 2022 at 01:56:35PM +0000, Lee Jones wrote:
> > On Wed, 02 Mar 2022, Michael S. Tsirkin wrote:
> >
> > > On Wed, Mar 02, 2022 at 07:54:21AM +, Lee Jones wrote:
> > > > vhost_vsock_handle_tx_k
On Wed, 02 Mar 2022, Michael S. Tsirkin wrote:
> On Wed, Mar 02, 2022 at 07:54:21AM +0000, Lee Jones wrote:
> > vhost_vsock_handle_tx_kick() already holds the mutex during its call
> > to vhost_get_vq_desc(). All we have to do is take the same lock
> > during virtqueue cle
On Wed, 02 Mar 2022, Stefano Garzarella wrote:
> On Wed, Mar 02, 2022 at 07:54:21AM +0000, Lee Jones wrote:
> > vhost_vsock_handle_tx_kick() already holds the mutex during its call
> > to vhost_get_vq_desc(). All we have to do is take the same lock
> > during virtqueue cle
vhost.c:372
> > kthread+0x2e9/0x3a0 kernel/kthread.c:377
> > ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:295
>
> I don't see how this can trigger normally so I'm assuming
> another case of use after free.
Yes, exactly.
I patched it. Please see:
https://lore.kernel.
+adc3cb32385586bec...@syzkaller.appspotmail.com
Signed-off-by: Lee Jones
---
drivers/vhost/vhost.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index 59edb5a1ffe28..bbaff6a5e21b8 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -693,6
jnoczi
Cc: Stefano Garzarella
Cc: "David S. Miller"
Cc: Jakub Kicinski
Cc: virtualization@lists.linux-foundation.org
Cc: k...@vger.kernel.org
Cc: net...@vger.kernel.org
Signed-off-by: Ram Muthiah
Signed-off-by: Lee Jones
---
include/linux/virtio_vsock.h| 4
| 4 +---
> drivers/input/gameport/gameport.c | 3 +--
> drivers/input/serio/serio.c | 3 +--
> drivers/ipack/ipack.c | 4 +---
> drivers/macintosh/macio_asic.c| 4 +---
> drivers/mcb/mcb-core.c | 4 +
On Mon, 13 Jul 2020, Michael S. Tsirkin wrote:
> On Mon, Jul 13, 2020 at 08:59:49AM +0100, Lee Jones wrote:
> > This is the only use of kerneldoc in the sourcefile and no
> > descriptions are provided.
> >
> > Fixes the following W=1 kernel build warning(s):
> >
: Function parameter or member 'buf'
not described in 'virtscsi_complete_cmd'
Cc: "Michael S. Tsirkin"
Cc: Jason Wang
Cc: Stefan Hajnoczi
Cc: virtualization@lists.linux-foundation.org
Signed-off-by: Lee Jones
Acked-by: Paolo Bonzini
---
drivers/scsi/virtio_scsi.c | 2 +-
1 file
: Function parameter or member 'buf'
not described in 'virtscsi_complete_cmd'
Cc: "Michael S. Tsirkin"
Cc: Jason Wang
Cc: Paolo Bonzini
Cc: Stefan Hajnoczi
Cc: virtualization@lists.linux-foundation.org
Signed-off-by: Lee Jones
---
drivers/scsi/virtio_scsi.c | 2 +-
1 file
r (i = 0; i < ST_SLIM_MAX_CLK && slim_rproc->clks[i]; i++)
> > + clk_put(slim_rproc->clks[i]);
> > +err:
> > + rproc_put(rproc);
> > + return ERR_PTR(err);
> > +}
> > +EXPORT_SYMBOL(st_slim_rproc_alloc);
> > +
> > +/**
> > + * st_slim_rp
We certainly never used to take 'device ID' or
> > 'version' attributes. I guess something must have changed.
>
> I will try to provide patches for code and bindings rework this week.
Wonderful.. Thanks Arnaud.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open sourc
On Tue, 30 Aug 2016, Peter Griffin wrote:
> Thanks for reviewing and your very valuable feedback.
> On Tue, 30 Aug 2016, Lee Jones wrote:
> > On Fri, 26 Aug 2016, Peter Griffin wrote:
> >
> > > This patch adds the DT node for the uniperif reader
> > > IP b
On Tue, 30 Aug 2016, Peter Griffin wrote:
> On Tue, 30 Aug 2016, Lee Jones wrote:
> > On Fri, 26 Aug 2016, Peter Griffin wrote:
> >
> > > slim core is used as a basis for many IPs in the STi
> > > chipsets such as fdma and demux. To avoid duplicating
> >
t; + clk_put(slim_rproc->clks[clk]);
> +
> + rproc_del(slim_rproc->rproc);
> + rproc_put(slim_rproc->rproc);
> +}
> +EXPORT_SYMBOL(st_slim_rproc_put);
> +
> +MODULE_AUTHOR("Peter Griffin");
Email.
> +MODULE_DESCRIPTION("STMicroelectronics
On Fri, 26 Aug 2016, Peter Griffin wrote:
> This patch adds the slim core rproc driver to the STi section
> of the MAINTAINERS file.
>
> Signed-off-by: Peter Griffin <peter.grif...@linaro.org>
> ---
> MAINTAINERS | 2 ++
> 1 file changed, 2 insertions(+)
+
> 1 file changed, 52 insertions(+)
Acked-by: Lee Jones <lee.jo...@linaro.org>
> diff --git a/arch/arm/boot/dts/stih407-family.dtsi
> b/arch/arm/boot/dts/stih407-family.dtsi
> index d294e82..45cab30 100644
> --- a/arch/arm/boot/dts/stih407-family.dtsi
> +++
.@linaro.org>
> Cc: arnaud.pouliq...@st.com
> Cc: broo...@kernel.org
> ---
> arch/arm/configs/multi_v7_defconfig | 3 +++
> 1 file changed, 3 insertions(+)
Acked-by: Lee Jones <lee.jo...@linaro.org>
> diff --git a/arch/arm/configs/multi_v7_defconfig
> b/arch/arm/con
-
> arch/arm/boot/dts/stih407-pinctrl.dtsi | 23 +++
> 1 file changed, 23 insertions(+)
Acked-by: Lee Jones <lee.jo...@linaro.org>
> diff --git a/arch/arm/boot/dts/stih407-pinctrl.dtsi
> b/arch/arm/boot/dts/stih407-pinctrl.dtsi
> index a538ae5..0fb5c8a 100644
>
-
> arch/arm/boot/dts/stih407-pinctrl.dtsi | 24
> 1 file changed, 24 insertions(+)
Acked-by: Lee Jones <lee.jo...@linaro.org>
> diff --git a/arch/arm/boot/dts/stih407-pinctrl.dtsi
> b/arch/arm/boot/dts/stih407-pinctrl.dtsi
> index 0fb5c8a..537db7e 10
-
> arch/arm/boot/dts/stih407-pinctrl.dtsi | 8
> 1 file changed, 8 insertions(+)
Acked-by: Lee Jones <lee.jo...@linaro.org>
> diff --git a/arch/arm/boot/dts/stih407-pinctrl.dtsi
> b/arch/arm/boot/dts/stih407-pinctrl.dtsi
> index 537db7e..598dbab 100644
> --- a/arch/arm/b
family.dtsi | 7 +++
> 1 file changed, 7 insertions(+)
Acked-by: Lee Jones <lee.jo...@linaro.org>
> diff --git a/arch/arm/boot/dts/stih407-family.dtsi
> b/arch/arm/boot/dts/stih407-family.dtsi
> index 45cab30..d1258d5 100644
> --- a/arch/arm/boot/dts/stih407-fam
On Tue, 30 Aug 2016, Lee Jones wrote:
> On Fri, 26 Aug 2016, Peter Griffin wrote:
>
> > This patch adds the DT nodes for the uniperif player
> > IP blocks found on STiH407 family silicon.
> >
> > Signed-off-by: Arnaud Pouliquen <arnaud.pouliq...@st.com&
_player3: sti-uni-player@3 {
> + compatible = "st,sti-uni-player";
> + status = "disabled";
> + #sound-dai-cells = <0>;
> + st,syscfg = <_core>;
> + clocks = <_s_d0_flexgen C
interrupts = ;
> + dmas = < 6 0 1>;
> + dma-names = "rx";
> + dai-name = "Uni Reader #1 (HDMI RX)";
> + st,version = <3>;
> + };
Al
On Tue, 30 Aug 2016, Lee Jones wrote:
> On Fri, 26 Aug 2016, Peter Griffin wrote:
>
> > Use tabs instead of spaces.
> >
> > Signed-off-by: Peter Griffin <peter.grif...@linaro.org>
> > ---
> > drivers/gpu/drm/virtio/Kconfig | 6 +++---
> &g
d.pouliq...@st.com>
> Signed-off-by: Peter Griffin <peter.grif...@linaro.org>
> ---
> arch/arm/boot/dts/stihxxx-b2120.dtsi | 45
> ++++++++
> 1 file changed, 45 insertions(+)
Acked-by: Lee Jones <lee.jo...@linaro.org>
> diff --git a/arch/arm
> index e1afc3d..90357d9 100644
> --- a/drivers/gpu/drm/virtio/Kconfig
> +++ b/drivers/gpu/drm/virtio/Kconfig
> @@ -1,6 +1,7 @@
> config DRM_VIRTIO_GPU
> tristate "Virtio GPU driver"
> - depends on DRM && VIRTIO
> + depends on DRM
> + select V
On Fri, 26 Aug 2016, Peter Griffin wrote:
> Use tabs instead of spaces.
>
> Signed-off-by: Peter Griffin <peter.grif...@linaro.org>
> ---
> drivers/gpu/drm/virtio/Kconfig | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
For my own reference:
Ack
Resorted to poaching now have we Pawel?
I hope you were joking!
Yes, of course. I thought that was clearly indicated by the jovial winking
smiley. :)
I realise it wasn't obvious soley by this exchange, but Pawel and I are
actually ol' friends.
Doing your work for you isn't poaching.
This
the parameters parsing easier to follow.
Reported-by: Lee Jones lee.jo...@linaro.org
Signed-off-by: Pawel Moll pawel.m...@arm.com
---
drivers/virtio/virtio_mmio.c | 26 ++
1 file changed, 18 insertions(+), 8 deletions(-)
Resorted to poaching now have we Pawel
On Mon, 05 Nov 2012, Pawel Moll wrote:
On Mon, 2012-11-05 at 13:44 +, Lee Jones wrote:
On Mon, 05 Nov 2012, Pawel Moll wrote:
On 64-bit machines resource_size_t is a 64-bit value, while
sscanf() format for this argument was defined as %u. Fixed
by using an intermediate local
-foundation.org
Signed-off-by: Lee Jones lee.jo...@linaro.org
---
drivers/virtio/virtio_mmio.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c
index 6b1b7e1..077e9ca 100644
--- a/drivers/virtio/virtio_mmio.c
+++ b/drivers
51 matches
Mail list logo
