Re: [PATCH v4 1/7] mm: page_alloc: avoid merging non-fallbackable pageblocks with others.

2022-01-24 Thread Mel Gorman
On Mon, Jan 24, 2022 at 11:12:07AM -0500, Zi Yan wrote: > On 24 Jan 2022, at 9:02, Mel Gorman wrote: > > > On Wed, Jan 19, 2022 at 02:06:17PM -0500, Zi Yan wrote: > >> From: Zi Yan > >> > >> This is done in addition to MIGRATE_ISOLATE pageblock merge avoid

Re: [PATCH v4 1/7] mm: page_alloc: avoid merging non-fallbackable pageblocks with others.

2022-01-24 Thread Mel Gorman
ATE_UNMOVABLE, > MIGRATE_TYPES }, > [MIGRATE_RECLAIMABLE] = { MIGRATE_UNMOVABLE, MIGRATE_MOVABLE, > MIGRATE_TYPES }, > + [MIGRATE_HIGHATOMIC] = { MIGRATE_TYPES }, /* Never used */ > #ifdef CONFIG_CMA > [MIGRATE_CMA] = { MIGRATE_TYPES }, /* Never used */ > #endif

Re: [RFC PATCH 0/3] Use pageblock_order for cma and alloc_contig_range alignment.

2021-11-30 Thread Mel Gorman
unting right. However, there does not appear to be any special protection against a page in a highatomic pageblock getting merged with a buddy of another pageblock type. The pageblock would still have the right setting but on allocation, the p

Re: [PATCH] virtio: Do not drop __GFP_HIGH in alloc_indirect

2015-12-07 Thread Mel Gorman
ll reduce their changes for success because the > lack of access to memory reserves. > > Signed-off-by: Michal Hocko <mho...@suse.com> Reviewed-by: Mel Gorman <mgor...@techsingularity.net> It also has been tested by Ying Huang and found to have fixed a page allocation fail

Re: [PATCH 0/4] enable migration of driver pages

2015-08-03 Thread Mel Gorman
a lot harder. With that in mind, I'll still read the rest of the series. -- Mel Gorman SUSE Labs ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH 2/4] mm/compaction: enable mobile-page migration

2015-08-03 Thread Mel Gorman
24 +#define KPF_MOBILE 25 #endif /* _UAPILINUX_KERNEL_PAGE_FLAGS_H */ -- Mel Gorman SUSE Labs ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo

Re: [PATCH 1/4] fs/anon_inodes: new interface to create new inode

2015-08-03 Thread Mel Gorman
anon_inode_getfd() cannot be used. -- Mel Gorman SUSE Labs ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH 0/4] enable migration of driver pages

2015-08-03 Thread Mel Gorman
On Wed, Jul 29, 2015 at 12:55:54PM +0200, Daniel Vetter wrote: On Wed, Jul 29, 2015 at 11:49:45AM +0100, Mel Gorman wrote: On Mon, Jul 13, 2015 at 05:35:15PM +0900, Gioh Kim wrote: My ARM-based platform occured severe fragmentation problem after long-term (several days) test. Sometimes

Re: [PATCH v11 7/7] mm: add vm event counters for balloon pages compaction

2012-11-09 Thread Mel Gorman
life very hard or would you notice? -- Mel Gorman SUSE Labs ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH v11 4/7] mm: introduce compaction and migration for ballooned pages

2012-11-09 Thread Mel Gorman
!= -EAGAIN) { /* It may be necessary to make this more generic for migration-related callbacks but I see nothing incompatible in your patch with doing that. Doing the abstraction now would be overkill so Acked-by: Mel Gorman m...@csn.ul.ie -- Mel Gorman SUSE Labs

Re: [PATCH v7 1/4] mm: introduce compaction and migration for virtio ballooned pages

2012-08-15 Thread Mel Gorman
is instructive in itself. I have no strong feelings about this though. I see little harm in making the check but in light of this conversation add a short comment explaining that the check should be redundant. -- Mel Gorman SUSE Labs ___ Virtualization

Re: [PATCH v7 2/4] virtio_balloon: introduce migration primitives to balloon pages

2012-08-15 Thread Mel Gorman
. -- Mel Gorman SUSE Labs ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH v7 2/4] virtio_balloon: introduce migration primitives to balloon pages

2012-08-15 Thread Mel Gorman
On Wed, Aug 15, 2012 at 12:25:28PM +0300, Michael S. Tsirkin wrote: On Wed, Aug 15, 2012 at 10:05:28AM +0100, Mel Gorman wrote: On Tue, Aug 14, 2012 at 05:11:13PM -0300, Rafael Aquini wrote: On Tue, Aug 14, 2012 at 10:51:39PM +0300, Michael S. Tsirkin wrote: What I think you should do

Re: [PATCH v6 1/3] mm: introduce compaction and migration for virtio ballooned pages

2012-08-10 Thread Mel Gorman
to see something like if (WARN_ON(!movable_balooon_page(page))) return; lock_page(page); __putback_balloon_page(page); put_page(page); unlock_page(page); but either works. Do not forget to update the caller of course. Thanks. -- Mel Gorman SUSE Labs

Re: [PATCH v6 1/3] mm: introduce compaction and migration for virtio ballooned pages

2012-08-09 Thread Mel Gorman
going to be held by a parallel compacting process checking the reference count and the delay will be short. As a bonus you can drop the WARN_ON check in the caller and make this void as the WARN_ON check in the caller becomes redundant. -- Mel Gorman SUSE Labs

Re: [PATCH v2 1/4] mm: introduce compaction and migration for virtio ballooned pages

2012-06-29 Thread Mel Gorman
procedures. Signed-off-by: Rafael Aquini aqu...@redhat.com I have two minor comments but it is not critical they be addressed. If you doa V3 then fix it but if it is picked up as it is, I'm ok with that. From a compaction point of view; Acked-by: Mel Gorman m...@csn.ul.ie --- include/linux

Re: [PATCH 1/4] mm: introduce compaction and migration for virtio ballooned pages

2012-06-27 Thread Mel Gorman
On Tue, Jun 26, 2012 at 10:34:00PM +0200, Andi Kleen wrote: How is the compiler meant to optimise away cond if it's a function call? Inlines can be optimized away. These tests are usually inlines. What did I miss? If nothing, then I will revert this particular change and Rafael will

Re: [PATCH 1/4] mm: introduce compaction and migration for virtio ballooned pages

2012-06-26 Thread Mel Gorman
)); + put_page(page); + __free_page(page); + return rc; + } out: if (rc != -EAGAIN) { /* -- 1.7.10.2 -- Mel Gorman SUSE Labs ___ Virtualization mailing list Virtualization@lists.linux

Re: [PATCH 1/4] mm: introduce compaction and migration for virtio ballooned pages

2012-06-26 Thread Mel Gorman
, but patch 3 is already doing that at the same time the migration primitives are introduced. It does mean the full series has to be applied to do anything but I think it's bisect safe. -- Mel Gorman SUSE Labs ___ Virtualization mailing list Virtualization

Re: [PATCH 1/4] mm: introduce compaction and migration for virtio ballooned pages

2012-06-26 Thread Mel Gorman
patch is not using VM_BUG_ON to call a function with side-effects. -- Mel Gorman SUSE Labs ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH] vhost: rcu annotation fixup

2011-01-18 Thread Mel Gorman
about. -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https