[PATCH] kernel/resource: Fix use of ternary condition in release_mem_region_adjustable

2020-09-22 Thread Nathan Chancellor
the parentheses as it was clearly intended for the ternary condition to be evaluated first. Fixes: 5fd23bd0d739 ("kernel/resource: make release_mem_region_adjustable() never fail") Link: https://github.com/ClangBuiltLinux/linux/issues/1159 Signed-off-by: Nathan Chancellor ---

Re: [PATCH] vdpa/mlx5: Avoid warnings about shifts on 32-bit platforms

2020-08-21 Thread Nathan Chancellor
On Fri, Aug 21, 2020 at 04:13:19PM -0700, Randy Dunlap wrote: > On 8/21/20 3:50 PM, Nathan Chancellor wrote: > > Clang warns several times when building for 32-bit ARM along the lines > > of: > > > > drivers/vdpa/mlx5/net/mlx5_vnet.c:1462:31: warning: shift count &g

[PATCH] vdpa/mlx5: Avoid warnings about shifts on 32-bit platforms

2020-08-21 Thread Nathan Chancellor
g long. This matches the size of the features field throughout this driver, which is u64 so there should be no functional change. Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices") Link: https://github.com/ClangBuiltLinux/linux/issues/1140 Signed-off-by: N

Re: [PATCH] virtio_balloon: Adjust label in virtballoon_probe

2020-02-15 Thread Nathan Chancellor
On Sun, Feb 16, 2020 at 08:36:45AM +0100, David Hildenbrand wrote: > > > > Am 16.02.2020 um 01:41 schrieb Nathan Chancellor : > > > > Clang warns when CONFIG_BALLOON_COMPACTION is unset: > > > > ../drivers/virtio/virtio_balloon.c:963:1: warning: unused lab

Re: [PATCH] virtio_balloon: Fix unused label warning

2020-02-15 Thread Nathan Chancellor
On Mon, Feb 10, 2020 at 10:33:28AM +0100, Borislav Petkov wrote: > From: Borislav Petkov > > Fix > > drivers/virtio/virtio_balloon.c: In function ‘virtballoon_probe’: > drivers/virtio/virtio_balloon.c:963:1: warning: label ‘out_del_vqs’ defined > but not used [-Wunused-label] > 963 |

[PATCH] virtio_balloon: Adjust label in virtballoon_probe

2020-02-15 Thread Nathan Chancellor
is set. Fixes: 1ad6f58ea936 ("virtio_balloon: Fix memory leaks on errors in virtballoon_probe()") Link: https://github.com/ClangBuiltLinux/linux/issues/886 Signed-off-by: Nathan Chancellor --- drivers/virtio/virtio_balloon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH net-next v9 1/3] netdev: pass the stuck queue to the timeout handler

2019-12-09 Thread Nathan Chancellor
Hi Michael, On Mon, Dec 09, 2019 at 11:29:03AM -0500, Michael S. Tsirkin wrote: > This allows incrementing the correct timeout statistic without any mess. > Down the road, devices can learn to reset just the specific queue. > > The patch was generated with the following script: > > > where

Re: [PATCH] vhost: Don't use defined in VHOST_ARCH_CAN_ACCEL_UACCESS definition

2019-07-24 Thread Nathan Chancellor
y me, I figured that might be preferred (since clang will warn if VHOST_ARCH_CAN_ACCEL_UACCESS is not defined so you'd know if the header was forgotten). Thank you for the fix :) Reviewed-by: Nathan Chancellor Tested-by: Nathan Chancellor > > > diff --git a/drivers/vhost/vhost.h b/drive

[PATCH] vhost: Don't use defined in VHOST_ARCH_CAN_ACCEL_UACCESS definition

2019-07-24 Thread Nathan Chancellor
adata through kernel virtual address") Link: https://github.com/ClangBuiltLinux/linux/issues/508 Signed-off-by: Nathan Chancellor --- drivers/vhost/vhost.c | 44 +-- drivers/vhost/vhost.h | 7 --- 2 files changed, 26 insertions(+), 25 deletions(-) di