Re: [PATCH v2 00/14] drm/format-helper: Move to struct iosys_map

onversion > drm/format-helper: Rework XRGB-to-MONO conversion > drm/format-helper: Move destination-buffer handling into internal > helper > drm/format-helper: Rename parameter vmap to src > Tested-by: Noralf Trønnes * gud: XRGB-to-{MONO,GRAY8,RGB332,RGB565}

Re: [PATCH v3 7/9] drm/simpledrm: Enable FB_DAMAGE_CLIPS property

y clipping from update function (Noralf) > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Noralf Trønnes ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH v2 7/9] drm/simpledrm: Enable FB_DAMAGE_CLIPS property

Den 09.11.2021 15.56, skrev Thomas Zimmermann: > Hi, > > thanks for looking through all this code. > > Am 09.11.21 um 14:04 schrieb Noralf Trønnes: >> >> >> Den 09.11.2021 13.38, skrev Thomas Zimmermann: >>> >>> >>> Am 08.11.21 um

Re: [PATCH v2 8/9] drm/simpledrm: Support virtual screen sizes

Den 09.11.2021 10.06, skrev Thomas Zimmermann: > Hi > > Am 08.11.21 um 22:01 schrieb Noralf Trønnes: >> >> >> Den 01.11.2021 15.15, skrev Thomas Zimmermann: >>> Add constants for the maximum size of the shadow-plane surface >>> size. Usefu

Re: [PATCH v2 7/9] drm/simpledrm: Enable FB_DAMAGE_CLIPS property

Den 09.11.2021 13.38, skrev Thomas Zimmermann: > > > Am 08.11.21 um 21:55 schrieb Noralf Trønnes: >> >> >> Den 01.11.2021 15.15, skrev Thomas Zimmermann: >>> Enable the FB_DAMAGE_CLIPS property to reduce display-update >>> overhead. Also fixes a

Re: [PATCH v2 9/9] drm: Clarify semantics of struct drm_mode_config.{min,max}_{width,height}

Den 01.11.2021 15.15, skrev Thomas Zimmermann: > Add additional information on the semantics of the size fields in > struct drm_mode_config. Also add a TODO to review all driver for > correct usage of these fields. > > Signed-off-by: Thomas Zimmermann > --- Acked-

Re: [PATCH v2 8/9] drm/simpledrm: Support virtual screen sizes

Den 01.11.2021 15.15, skrev Thomas Zimmermann: > Add constants for the maximum size of the shadow-plane surface > size. Useful for shadow planes with virtual screen sizes. The > current sizes are 4096 scanlines with 4096 pixels each. This > seems reasonable for current hardware, but can be

Re: [PATCH v2 7/9] drm/simpledrm: Enable FB_DAMAGE_CLIPS property

Den 01.11.2021 15.15, skrev Thomas Zimmermann: > Enable the FB_DAMAGE_CLIPS property to reduce display-update > overhead. Also fixes a warning in the kernel log. > > simple-framebuffer simple-framebuffer.0: [drm] > drm_plane_enable_fb_damage_clips() not called > > Fix the computation of

Re: [PATCH v2 7/9] drm/simpledrm: Enable FB_DAMAGE_CLIPS property

Den 01.11.2021 15.15, skrev Thomas Zimmermann: > Enable the FB_DAMAGE_CLIPS property to reduce display-update > overhead. Also fixes a warning in the kernel log. > > simple-framebuffer simple-framebuffer.0: [drm] > drm_plane_enable_fb_damage_clips() not called > > Fix the computation of

Re: [PATCH v2 1/9] drm/format-helper: Export drm_fb_clip_offset()

n 'unsigned int' (Sam, Noralf) > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Noralf Trønnes ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH 7/9] drm/simpledrm: Enable FB_DAMAGE_CLIPS property

Den 22.10.2021 15.28, skrev Thomas Zimmermann: > Enable the FB_DAMAGE_CLIPS property to reduce display-update > overhead. Also fixes a warning in the kernel log. > > simple-framebuffer simple-framebuffer.0: [drm] > drm_plane_enable_fb_damage_clips() not called > > Fix the computation of

Re: [PATCH 6/9] drm/fb-helper: Allocate shadow buffer of surface height

Den 22.10.2021 15.28, skrev Thomas Zimmermann: > Allocating a shadow buffer of the height of the buffer object does > not support fbdev overallocation. Use surface height instead. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by:

Re: [PATCH 5/9] drm/format-helper: Streamline blit-helper interface

n't required. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Noralf Trønnes ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH 4/9] drm/format-helper: Rework format-helper conversion functions

kernel crash: > + dst_pitch = len; This works: dst_pitch = drm_rect_width(clip); With that fixed: Tested-by: Noralf Trønnes Reviewed-by: Noralf Trønnes > + > /* >* The cma memory is write-combined so reads are uncached. >

Re: [PATCH 3/9] drm/format-helper: Add destination-buffer pitch to drm_fb_swab()

*clip, bool cached) > +void drm_fb_swab(void *dst, unsigned int dst_pitch, const void *src, > + const struct drm_framebuffer *fb, const struct drm_rect *clip, > + bool cached) Tested-by: Noralf Trønnes Reviewed-by: Noralf Trønnes

Re: [PATCH 2/9] drm/format-helper: Rework format-helper memcpy functions

Thomas Zimmermann > --- Tested-by: Noralf Trønnes Reviewed-by: Noralf Trønnes ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH 1/9] drm/format-helper: Export drm_fb_clip_offset()

Den 22.10.2021 15.28, skrev Thomas Zimmermann: > Provide a function that computes the offset into a blit destination > buffer. This will allow to move destination-buffer clipping into the > format-helper callers. > > Signed-off-by: Thomas Zimmermann > --- >

Re: [PATCH 39/44] drm/cirrus: Use devm_drm_dev_alloc

Den 03.04.2020 15.58, skrev Daniel Vetter: > Already using devm_drm_dev_init, so very simple replacment. > > Signed-off-by: Daniel Vetter > Cc: Dave Airlie > Cc: Gerd Hoffmann > Cc: Daniel Vetter > Cc: Sam Ravnborg > Cc: "Noralf Trønnes" > Cc: Rob H

Re: [PATCH v2 2/2] drm/qxl: add drm_driver.release callback.

(adding back Daniel) Den 10.02.2020 17.57, skrev Noralf Trønnes: > > > Den 10.02.2020 16.06, skrev Daniel Vetter: >> On Mon, Feb 10, 2020 at 12:37:52PM +0100, Gerd Hoffmann wrote: >>> Move final cleanups to qxl_drm_release() callback. >>> Add drm_atomic_helper_

Re: [PATCH v2 2/2] drm/qxl: add drm_driver.release callback.

Den 10.02.2020 16.06, skrev Daniel Vetter: > On Mon, Feb 10, 2020 at 12:37:52PM +0100, Gerd Hoffmann wrote: >> Move final cleanups to qxl_drm_release() callback. >> Add drm_atomic_helper_shutdown() call to qxl_pci_remove(). >> >> Signed-off-by: Gerd Hoffmann >> --- >>

Re: [PATCH 2/6] drm: Add drm_simple_encoder_{init,create}()

Den 07.02.2020 09.41, skrev Thomas Zimmermann: > The simple-encoder helpers initialize an encoder with an empty > implementation. This covers the requirements of most of the existing > DRM drivers. A call to drm_simple_encoder_create() allocates and > initializes an encoder instance, a call to

Re: [PATCH v2 3/6] drm/fb-helper: Instanciate shadow FB if configured in device's mode_config

fig { > /* dumb ioctl parameters */ > uint32_t preferred_depth, prefer_shadow; > > + /* fbdev parameters */ No need for this comment. Doc can look like this, I've done s/framebuffer/fbdev/: /** * @prefer_shadow_fbdev: * * Hint to fbdev emulation to

Re: [PATCH v2 2/6] drm/fb-helper: Map DRM client buffer only when required

2: > * change DRM client to not map buffer by default > * manually map client buffer for fbdev with HW framebuffer > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Noralf Trønnes ___ Virtualizati

Re: [PATCH v2 1/6] drm/client: Support unmapping of DRM client buffers

nt.h > index 72d51d1e9dd9..e1db1d9da0bf 100644 > --- a/include/drm/drm_client.h > +++ b/include/drm/drm_client.h > @@ -149,6 +149,9 @@ struct drm_client_buffer { > struct drm_client_buffer * > drm_client_framebuffer_create(struct drm_client_dev *client, u32 width, u32 > height, u32 format); >

Re: [PATCH 0/5] Unmappable DRM client buffers for fbdev emulation

Den 04.07.2019 13.10, skrev Thomas Zimmermann: > Hi > > Am 04.07.19 um 12:18 schrieb Noralf Trønnes: >> >> >> Den 04.07.2019 09.43, skrev Thomas Zimmermann: >>> Hi >>> >>> Am 03.07.19 um 21:27 schrieb Noralf Trønnes: >>>> >>

Re: [PATCH 0/5] Unmappable DRM client buffers for fbdev emulation

Den 04.07.2019 09.43, skrev Thomas Zimmermann: > Hi > > Am 03.07.19 um 21:27 schrieb Noralf Trønnes: >> >> >> Den 03.07.2019 10.32, skrev Thomas Zimmermann: >>> DRM client buffers are permanently mapped throughout their lifetime. This >>> prevent

Re: [PATCH 0/5] Unmappable DRM client buffers for fbdev emulation

Den 03.07.2019 10.32, skrev Thomas Zimmermann: > DRM client buffers are permanently mapped throughout their lifetime. This > prevents us from using generic framebuffer emulation for devices with > small dedicated video memory, such as ast or mgag200. With fb buffers > permanently mapped, such

Re: [PATCH 5/5] drm/mgag200: Replace struct mga_fbdev with generic framebuffer emulation

mgag200_driver_load(struct drm_device *dev, unsigned > long flags) > } > mdev->cursor.pixels_current = NULL; > > + r = drm_fbdev_generic_setup(mdev->dev, 0); > + if (r) { > + dev_err(>pdev->dev, > + "drm_fbdev_generic_setup failed: %d\n&q

Re: [PATCH 4/5] drm/bochs: Use shadow buffer for bochs framebuffer console

Signed-off-by: Thomas Zimmermann > --- Acked-by: Noralf Trønnes ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH 3/5] drm/ast: Replace struct ast_fbdev with generic framebuffer emulation

sume_force_mode(dev); > > - console_lock(); > - ast_fbdev_set_suspend(dev, 0); > - console_unlock(); > - return error; > + if (dev->fb_helper) { > + console_lock(); > + drm_fb_helper_set_suspend(dev->fb_helper, 0); > +

Re: [PATCH 1/5] drm/client: Support unmapping of DRM client buffers

Den 03.07.2019 10.32, skrev Thomas Zimmermann: > DRM clients, such as the fbdev emulation, have their buffer objects > mapped by default. Mapping a buffer implicitly prevents its relocation. > Hence, the buffer may permanently consume video memory while it's > allocated. This is a problem for

Re: [PATCH] drm/bochs: use simple display pipe

Den 10.04.2019 09.48, skrev Gerd Hoffmann: > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH v2 2/3] drm: switch drm_fb_xrgb8888_to_rgb565_dstclip to accept __iomem dst

unsigned int pixels, > + bool swab) Both here and further down you change the argument name: swap -> swab. If you want that, you need to fix the function declaration and the docs as well. With that sorted out: Reviewed-by: Noralf Trønnes

Re: [PATCH v2 3/3] drm: switch drm_fb_xrgb8888_to_rgb888_dstclip to accept __iomem dst

st pointer and use memcpy_toio() instead of memcpy(). The helper > function (drm_fb_xrgb_to_rgb888_line) has been changed to process a > single scanline. > > Signed-off-by: Gerd Hoffmann > --- Reviewed-by: Noralf Trønnes __

Re: [PATCH v2 1/3] drm: switch drm_fb_memcpy_dstclip to accept __iomem dst

nd use memcpy_toio() instead of memcpy(). With that separating out the > memcpy loop into the drm_fb_memcpy_lines() helper isn't useful any more, > so move the code back into the calling functins. > > Signed-off-by: Gerd Hoffmann >

Re: [PATCH v3 5/5] drm/cirrus: rewrite and modernize driver.

d. > - The generic fbdev emulation is used. > - It's a atomic driver now. > - It runs wayland. > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH] drm/cirrus: rewrite and modernize driver.

Den 04.04.2019 12.27, skrev Gerd Hoffmann: > Hi, > >>> tinydrm_xrgb_to_* >>> >>> imo these could be put into some drm_format_helpers.c to be shared. >> >> I agree, my long term goal is to get rid of tinydrm.ko. Just haven't got >> there yet. >> >> Gerd, if you end up using some of those

Re: [PATCH] drm/cirrus: rewrite and modernize driver.

Den 04.04.2019 10.52, skrev Daniel Vetter: > On Thu, Apr 4, 2019 at 10:30 AM Gerd Hoffmann wrote: >> >> Hi, >> Speaking of wayland: Seems at least gnome-shell insists on using XR24. >>> >>> Yeah XR24 is pretty much mandatory. Noralf added a few helpers to >>> convert XR24 to other

Re: [PATCH] drm/cirrus: rewrite and modernize driver.

Den 03.04.2019 10.53, skrev Gerd Hoffmann: >>> +struct cirrus_device { >>> + struct drm_device *dev; >> >> Why not embed drm_device? It's the latest rage :-) > > Sure, can do that. > >>> +void cirrus_pipe_update(struct drm_simple_display_pipe *pipe, >>> +

Re: [PATCH v3 5/5] drm/virtio: rework resource creation workflow.

then initialize the > ttm object, and finally attach just created object to the fence for the > command in case it didn't finish yet. > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes ___ Virtualization

Re: [PATCH v3 2/5] drm/virtio: use struct to pass params to virtio_gpu_object_create()

M_PL_FLAG_NO_EVICT so ttm knows. Doesn't change much for the moment > as virtio-gpu supports TTM_PL_FLAG_TT only so there is no opportunity to > move around objects. That'll probably change in the future though. > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes ___

Re: [PATCH] drm/virtio: add virtio-gpu-features debugfs file.

Den 20.03.2019 09.36, skrev Gerd Hoffmann: > This file prints which features the virtio-gpu device has. > > Also add "virtio-gpu-" prefix to the existing fence file, > to make clear this is a driver-specific debugfs file. > > Signed-off-by: Gerd Hoffmann >

Re: [PATCH 3/3] drm/virtio: implement prime export

nevertheless. > > Signed-off-by: Gerd Hoffmann Acked-by: Noralf Trønnes ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH 1/3] drm/virtio: implement prime mmap

Den 27.02.2019 15.44, skrev Gerd Hoffmann: > Sync gem vm_node.start with ttm vm_node.start, > then we can just call drm_gem_prime_mmap(). > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes ___ Virtualization mailing list

Re: [PATCH 2/3] drm/virtio: implement prime pin/unpin

void virtgpu_gem_prime_unpin(struct drm_gem_object *obj) > { > - WARN_ONCE(1, "not implemented"); > + /* nothing */ > } You can just remove these dummies the callbacks are optional. See drm_gem_pin().

Re: [PATCH v2 4/6] drm/virtio: params struct for virtio_gpu_cmd_create_resource_3d()

Den 01.02.2019 09.01, skrev Gerd Hoffmann: > On Thu, Jan 31, 2019 at 11:47:38AM +0100, Noralf Trønnes wrote: >> >> >> Den 30.01.2019 10.43, skrev Gerd Hoffmann: >>> Add 3d resource parameters to virtio_gpu_object_params struct. Wit

Re: [PATCH v2 3/6] drm/virtio: params struct for virtio_gpu_cmd_create_resource()

Den 30.01.2019 10.43, skrev Gerd Hoffmann: > Add format, width and height fields to the virtio_gpu_object_params > struct. With that in place we can use the parameter struct for > virtio_gpu_cmd_create_resource() calls too. > > Signed-off-by: Gerd Hoffmann > --- Acked-

Re: [PATCH v2 1/6] drm/virtio: move virtio_gpu_object_{attach, detach} calls.

e calls from the > move_notify() callback. > > With that in place the move and move_notify callbacks are not > needed any more, so drop them. > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes ___ Virtualization mailin

Re: [PATCH v2 4/6] drm/virtio: params struct for virtio_gpu_cmd_create_resource_3d()

Den 30.01.2019 10.43, skrev Gerd Hoffmann: > Add 3d resource parameters to virtio_gpu_object_params struct. With > that in place we can use it for virtio_gpu_cmd_resource_create_3d() > calls. > > Signed-off-by: Gerd Hoffmann > --- You don't remove the struct virtio_gpu_resource_create_3d

Re: [PATCH v2 5/6] drm/virtio: drop fencing in virtio_gpu_resource_create_ioctl

re is no need to wait for completion too. Which > btw is different from resource destroy, where we have to make sure the > host has seen the destroy and thus doesn't use it any more before > releasing the pages backing the resource. > > Signed-off-by: Gerd Hoffm

Re: [PATCH v2 6/6] drm/virtio: move virtio_gpu_cmd_create_resource call into virtio_gpu_object_create

With that in place virtio_gpu_object_attach() will never be called with > an object which is not yet created, so the extra > virtio_gpu_object_attach() calls done after > virtio_gpu_cmd_create_resource() is not needed any more. > > Signed-off-by: Gerd Hoffmann

Re: [PATCH v2 2/6] drm/virtio: use struct to pass params to virtio_gpu_object_create()

params = { 0 }; > int ret; > uint32_t pitch; > uint32_t format; > @@ -96,7 +97,9 @@ int virtio_gpu_mode_dumb_create(struct drm_file *file_priv, > args->size = pitch * args->height; > args->size = ALIGN(args->size, PAGE_SIZE)

Re: [PATCH v2] drm/qxl: use ttm_tt

Den 29.01.2019 09.25, skrev Gerd Hoffmann: > qxl device will not dma, so we don't need ttm_dma_tt. Go use ttm_tt > instead, to avoid wasting resources (swiotlb bounce buffers for > example). > > Signed-off-by: Gerd Hoffmann > --- Acked-

Re: [PATCH v3 17/23] drm/qxl: use generic fbdev emulation

Den 28.01.2019 09.59, skrev Gerd Hoffmann: > On Fri, Jan 25, 2019 at 06:25:27PM +0100, Noralf Trønnes wrote: >> >> >> Den 18.01.2019 13.20, skrev Gerd Hoffmann: >>> Switch qxl over to the new generic fbdev emulation. >>> >>> Signed-off-by:

Re: [PATCH v3 10/23] drm/qxl: move qxl_primary_apply_cursor to correct place

e the > commit message with that. > This is actually my first review of a driver that I'm not familiar with. I'm not quite sure how much in depth understanding that is required to put my ack on it. Going further into the patchset I realised that there's no way that I can

Re: [PATCH v3 09/23] drm/qxl: use QXL_GEM_DOMAIN_SURFACE for dumb gem objects

Den 18.01.2019 13.20, skrev Gerd Hoffmann: > dumb buffers are used as qxl surfaces, so allocate them as > QXL_GEM_DOMAIN_SURFACE. Should usually be allocated in > PRIV ttm domain then, so this reduces VRAM memory pressure. > > Signed-off-by: Gerd Hoffmann > --- Acked-

Re: [PATCH v3 18/23] drm/qxl: remove dead qxl fbdev emulation code

t; drivers/gpu/drm/qxl/qxl_draw.c | 232 --- >>> drivers/gpu/drm/qxl/qxl_fb.c | 300 >>> - >>> drivers/gpu/drm/qxl/Makefile | 2 +- >>> 4 files changed, 1 insertion(+), 554 deletions(-) >>> delete mode 100644

Re: [PATCH v3 08/23] drm/qxl: use QXL_GEM_DOMAIN_SURFACE for shadow bo.

Den 18.01.2019 13.20, skrev Gerd Hoffmann: > The shadow bo is used as qxl surface, so allocate it as > QXL_GEM_DOMAIN_SURFACE. Should usually be allocated in > PRIV ttm domain then, so this reduces VRAM memory pressure. > > Signed-off-by: Gerd Hoffmann > --- Acked-

Re: [PATCH v3 07/23] drm/qxl: allow both PRIV and VRAM placement for QXL_GEM_DOMAIN_SURFACE

s which must be allocated there. > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH v3 06/23] drm/qxl: use separate offset spaces for the two slots / ttm memory types.

s are rare enough by pure luck. > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH v3 05/23] drm/qxl: drop unused fields from struct qxl_device

Den 18.01.2019 13.20, skrev Gerd Hoffmann: > slot_id_bits and slot_gen_bits can be read directly from qxlrom instead. > va_slot_mask is never used anywhere. > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes ___ Virtual

Re: [PATCH v3 02/23] drm/qxl: drop unused qxl_fb_virtual_address

Den 18.01.2019 13.19, skrev Gerd Hoffmann: > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH v3 03/23] drm/qxl: simplify slot management

Den 18.01.2019 13.20, skrev Gerd Hoffmann: > Drop pointless indirection, remove the mem_slots array and index > variables, drop dynamic allocation. Store memslots in qxl_device > instead. > > Signed-off-by: Gerd Hoffmann > --- Looks sane: Acked-

Re: [PATCH v3 04/23] drm/qxl: change the way slot is detected

adapted to upstream changes ] > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH v3 01/23] drm/qxl: drop ttm_mem_reg arg from qxl_hw_surface_alloc()

Den 18.01.2019 13.19, skrev Gerd Hoffmann: > Not used, is always NULL. > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfo

Re: [PATCH v3 22/23] drm/qxl: use kernel mode db

Den 18.01.2019 13.20, skrev Gerd Hoffmann: > Add all standard modes from the kernel's video mode data base. > Keep a few non-standard modes in the qxl mode list. > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes ___

Re: [PATCH v3 21/23] drm/qxl: add qxl_add_mode helper function

Den 18.01.2019 13.20, skrev Gerd Hoffmann: > Add a helper function to add custom video modes to a connector. > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes ___ Virtualization mailing list Virtualization@lists.linux-fo

Re: [PATCH v3 20/23] drm/qxl: add mode/framebuffer check functions

are too big will not be added to the mode list in the first place. > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH v3 19/23] drm/qxl: implement qxl_gem_prime_(un)pin

Den 18.01.2019 13.20, skrev Gerd Hoffmann: > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH v3 18/23] drm/qxl: remove dead qxl fbdev emulation code

--- > drivers/gpu/drm/qxl/Makefile | 2 +- > 4 files changed, 1 insertion(+), 554 deletions(-) > delete mode 100644 drivers/gpu/drm/qxl/qxl_fb.c > Nice! Acked-by: Noralf Trønnes ___ Virtualization mailin

Re: [PATCH v3 15/23] drm/qxl: use qxl_num_crtc directly

eed to dereference pointers each time it > needs the value, and when reading the code you don't have to trace where > and why qdev->monitors_config->max_allowed is set. > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes

Re: [PATCH v3 17/23] drm/qxl: use generic fbdev emulation

goto modeset_cleanup; > > + drm_fb_helper_remove_conflicting_pci_framebuffers(pdev, 0, "qxl"); I couldn't find that this was part of old fbdev code, so it would be nice to mention it in the commit message. Acked-by: Noralf Trønnes > + drm_fbdev_g

Re: [PATCH v3 16/23] drm/qxl: implement prime kmap/kunmap

is balanced. > > Signed-off-by: Gerd Hoffmann > --- Just a note: You catch the one-to-many kmap type of unbalance, but not the one-too-many kunmap situation. Acked-by: Noralf Trønnes > drivers/gpu/drm/qxl/qxl_drv.h| 1 + > drivers/gpu/drm/qxl/qxl_object.c | 6 ++ > d

Re: [PATCH v3 14/23] drm/qxl: cover all crtcs in shadow bo.

user_bo->shadow->surf = user_bo->surf; > + if (user_bo->shadow != qdev->dumb_shadow_bo) { > + if (user_bo->shadow) { > + drm_gem_object_put_unlocked > + (_bo->shadow

Re: [PATCH v3 13/23] drm/qxl: use shadow bo directly

pot anything suspicious looking. Acked-by: Noralf Trønnes ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH v3 12/23] drm/qxl: track primary bo

_io_create_primary(). > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH v3 11/23] drm/qxl: drop unused offset parameter from qxl_io_create_primary()

Den 18.01.2019 13.20, skrev Gerd Hoffmann: > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH v3 10/23] drm/qxl: move qxl_primary_apply_cursor to correct place

condition, but the condition for applying the cursor is changed from bo_old->is_primary to !bo->is_primary. It probably makes sense to someone that knows the driver. Acked-by: Noralf Trønnes ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH v3 14/15] drm/bochs: drop old fbdev emulation code

Den 10.01.2019 11.16, skrev Gerd Hoffmann: > Hi, > >>> - drm_fb_helper_set_suspend_unlocked(>fb.helper, 1); >> >> The generic fbdev emulation doesn't take care of suspend/resume. You >> could do this: >> drm_fb_helper_set_suspend_unlocked(drm_dev->fb_helper, 1); > > Additional to

Re: [PATCH v3 14/15] drm/bochs: drop old fbdev emulation code

Den 10.01.2019 09.28, skrev Gerd Hoffmann: > Not needed any more, bochs uses the generic emulation now. > > Signed-off-by: Gerd Hoffmann > Reviewed-by: Oleksandr Andrushchenko > Acked-by: Daniel Vetter > --- > drivers/gpu/drm/bochs/bochs.h | 9 --- >

Re: [PATCH 00/23] drm: Eliminate plane->fb/crtc usage for atomic drivers

Den 22.03.2018 19.49, skrev Ville Syrjälä: On Thu, Mar 22, 2018 at 05:51:35PM +0100, Noralf Trønnes wrote: tinydrm is also using plane->fb: $ grep -r "plane\.fb" drivers/gpu/drm/tinydrm/ drivers/gpu/drm/tinydrm/repaper.c:  if (tdev->pipe.plane.fb != fb) drivers/gpu/drm/ti

Re: [PATCH 00/23] drm: Eliminate plane->fb/crtc usage for atomic drivers

Den 22.03.2018 16.22, skrev Ville Syrjala: From: Ville Syrjälä I really just wanted to fix i915 to re-enable its planes afer load detection (a two line patch). This is what I actually ended up with after I ran into a framebuffer refcount leak with said two line

Re: [PATCH libdrm] drm: Remove create_handle() drm_framebuffer "virtual".

Den 09.08.2017 01.42, skrev Joe Kniss: Because all drivers currently use gem objects for framebuffer planes, the virtual create_handle() is not required. This change adds a struct drm_gem_object *gems[4] field to drm_framebuffer and removes create_handle() function pointer from

Re: [PATCH 7/8] drm: Nuke drm_atomic_helper_connector_dpms

.reset = drm_atomic_helper_connector_reset, .detect = tinydrm_connector_detect, .fill_modes = drm_helper_probe_single_connector_modes, Acked-by: Noralf Trønnes <nor...@tronnes.org> ___ Virtualization mailing list Virtualization@lists.linux-foundati