On Wed, 1 Jun 2011 13:25:48 +0300, Michael S. Tsirkin m...@redhat.com wrote:
Add an option to modify the notificatin
hand-off in virtio to be basically like Xen:
each side published an index, the other side only triggers
an event when it crosses that index value
(Xen event indexes start at 1,
On Wed, 1 Jun 2011 03:24:29 -0400, Mark Wu d...@redhat.com wrote:
Current index allocation in virtio-blk is based on a monotonically
increasing variable index. It could cause some confusion about disk
name in the case of hot-plugging disks. And it's impossible to find the
lowest available
On Wed, 1 Jun 2011 12:50:03 +0300, Michael S. Tsirkin m...@redhat.com wrote:
Current code might introduce a lot of latency variation
if there are many pending bufs at the time we
attempt to transmit a new one. This is bad for
real-time applications and can't be good for TCP either.
Free up
On Wed, 1 Jun 2011 12:49:46 +0300, Michael S. Tsirkin m...@redhat.com wrote:
Add API to check ring capacity. Because of the option
to use indirect buffers, this returns the worst
case, not the normal case capacity.
Can we drop the silly add_buf() returns capacity hack then?
Thanks,
Rusty.
On Wed, 1 Jun 2011 12:49:54 +0300, Michael S. Tsirkin m...@redhat.com wrote:
In the (rare) case where new descriptors are used
while virtio_net enables vq callback for the TX vq,
virtio_net uses the number of sg entries in the skb it frees to
calculate how many descriptors in the ring have
On Sat, 28 May 2011 23:02:04 +0300, Michael S. Tsirkin m...@redhat.com
wrote:
On Thu, May 26, 2011 at 12:58:23PM +0930, Rusty Russell wrote:
ie. free two packets for every one we're about to add. For steady state
that would work really well.
Sure, with indirect buffers, but if we
don't
On Wed, 25 May 2011 09:07:59 +0300, Michael S. Tsirkin m...@redhat.com
wrote:
On Wed, May 25, 2011 at 11:05:04AM +0930, Rusty Russell wrote:
Hmm I'm not sure I got it, need to think about this.
I'd like to go back and document how my design was supposed to work.
This really should have been
On Mon, 23 May 2011 14:19:00 +0300, Michael S. Tsirkin m...@redhat.com
wrote:
On Mon, May 23, 2011 at 11:37:15AM +0930, Rusty Russell wrote:
Can we hit problems with OOM? Sure, but no worse than now...
The problem is that this virtqueue_get_capacity() returns the worst
case
On Tue, 24 May 2011 12:23:45 +0300, Michael S. Tsirkin m...@redhat.com
wrote:
Just checking: were you going to send the following to Linus for 2.6.40?
virtio:event_index_interface.patch
virtio:ring_inline_function_to_check_for_events.patch
virtio:ring_support_event_idx_feature.patch
On Mon, 23 May 2011 14:19:00 +0300, Michael S. Tsirkin m...@redhat.com
wrote:
I do understand how it seems a waste to leave direct space
in the ring while we might in practice have space
due to indirect. Didn't come up with a nice way to
solve this yet - but 'no worse than now :)'
Let's just
On Sun, 22 May 2011 15:10:08 +0300, Michael S. Tsirkin m...@redhat.com
wrote:
On Sat, May 21, 2011 at 11:49:59AM +0930, Rusty Russell wrote:
On Fri, 20 May 2011 02:11:56 +0300, Michael S. Tsirkin m...@redhat.com
wrote:
Current code might introduce a lot of latency variation
On Thu, 19 May 2011 10:24:12 +0300, Michael S. Tsirkin m...@redhat.com
wrote:
On Mon, May 16, 2011 at 04:43:21PM +0930, Rusty Russell wrote:
On Sun, 15 May 2011 15:48:18 +0300, Michael S. Tsirkin m...@redhat.com
wrote:
On Mon, May 09, 2011 at 03:27:33PM +0930, Rusty Russell wrote
On Fri, 20 May 2011 02:10:07 +0300, Michael S. Tsirkin m...@redhat.com
wrote:
OK, here is the large patchset that implements the virtio spec update
that I sent earlier (the spec itself needs a minor update, will send
that out too next week, but I think we are on the same page here
already).
On Fri, 20 May 2011 02:11:14 +0300, Michael S. Tsirkin m...@redhat.com
wrote:
Add an API that tells the other side that callbacks
should be delayed until a lot of work has been done.
Implement using the new event_idx feature.
Note: it might seem advantageous to let the drivers
ask for a
On Fri, 20 May 2011 02:10:44 +0300, Michael S. Tsirkin m...@redhat.com
wrote:
Support for the new event idx feature:
1. When enabling interrupts, publish the current avail index
value to the host to get interrupts on the next update.
2. Use the new avail_event feature to reduce the number
On Fri, 20 May 2011 02:11:47 +0300, Michael S. Tsirkin m...@redhat.com
wrote:
virtio net uses the number of sg entries to
check for TX ring capacity freed. But this
gives incorrect results when indirect buffers
are used. Use the new capacity API instead.
OK, but this explanation needs
On Fri, 20 May 2011 02:10:54 +0300, Michael S. Tsirkin m...@redhat.com
wrote:
Support the new event index feature. When acked,
utilize it to reduce the # of interrupts sent to the guest.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
Applied, even though it'd normally be in your tree,
On Fri, 20 May 2011 02:10:27 +0300, Michael S. Tsirkin m...@redhat.com
wrote:
With the new used_event and avail_event and features, both
host and guest need similar logic to check whether events are
enabled, so it helps to put the common code in the header.
Note that Xen has similar logic
On Fri, 20 May 2011 02:10:17 +0300, Michael S. Tsirkin m...@redhat.com
wrote:
Define a new feature bit for the guest and host to utilize
an event index (like Xen) instead if a flag bit to enable/disable
interrupts and kicks.
Applied.
Thanks,
Rusty.
On Fri, 20 May 2011 02:11:05 +0300, Michael S. Tsirkin m...@redhat.com
wrote:
Add ability to test the new event idx feature,
enable by default.
Applied.
Thanks,
Rusty.
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
On Fri, 20 May 2011 02:11:56 +0300, Michael S. Tsirkin m...@redhat.com
wrote:
Current code might introduce a lot of latency variation
if there are many pending bufs at the time we
attempt to transmit a new one. This is bad for
real-time applications and can't be good for TCP either.
Do we
On Fri, 20 May 2011 02:12:19 +0300, Michael S. Tsirkin m...@redhat.com
wrote:
Update avail index immediately instead of upon kick:
for virtio-net RX this helps parallelism with the host.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
drivers/virtio/virtio_ring.c | 28
On Thu, 19 May 2011 01:01:25 +0300, Michael S. Tsirkin m...@redhat.com
wrote:
The patch virtio_net: limit xmit polling
got the logic reversed: it polled while we had
capacity not while ring was empty.
Fix it up and clean up a bit by using a for loop.
Signed-off-by: Michael S. Tsirkin
On Tue, 17 May 2011 09:10:31 +0300, Michael S. Tsirkin m...@redhat.com
wrote:
Well one can imagine a driver doing:
while (virtqueue_get_buf()) {
virtqueue_add_buf()
}
virtqueue_kick()
which looks sensible (batch kicks) but might
process any number of
On Tue, 17 May 2011 09:00:52 +0300, Michael S. Tsirkin m...@redhat.com
wrote:
On Mon, May 16, 2011 at 03:53:19PM +0930, Rusty Russell wrote:
On Sun, 15 May 2011 15:47:27 +0300, Michael S. Tsirkin m...@redhat.com
wrote:
On Mon, May 09, 2011 at 01:43:15PM +0930, Rusty Russell wrote
On Sun, 15 May 2011 15:48:18 +0300, Michael S. Tsirkin m...@redhat.com
wrote:
On Mon, May 09, 2011 at 03:27:33PM +0930, Rusty Russell wrote:
On Wed, 4 May 2011 23:52:33 +0300, Michael S. Tsirkin m...@redhat.com
wrote:
Add an API that tells the other side that callbacks
should
On Sun, 15 May 2011 15:47:27 +0300, Michael S. Tsirkin m...@redhat.com
wrote:
On Mon, May 09, 2011 at 01:43:15PM +0930, Rusty Russell wrote:
On Wed, 4 May 2011 23:51:19 +0300, Michael S. Tsirkin m...@redhat.com
wrote:
#define VIRTIO_RING_F_USED_EVENT_IDX 29
+/* The Host publishes
On Sun, 15 May 2011 16:55:41 +0300, Michael S. Tsirkin m...@redhat.com
wrote:
On Mon, May 09, 2011 at 02:03:26PM +0930, Rusty Russell wrote:
On Wed, 4 May 2011 23:51:47 +0300, Michael S. Tsirkin m...@redhat.com
wrote:
Use the new avail_event feature to reduce the number
of exits from
On Wed, 4 May 2011 23:52:33 +0300, Michael S. Tsirkin m...@redhat.com wrote:
Add an API that tells the other side that callbacks
should be delayed until a lot of work has been done.
Implement using the new used_event feature.
Since you're going to add a capacity query anyway, why not add the
On Thu, 5 May 2011 18:08:17 +0300, Michael S. Tsirkin m...@redhat.com wrote:
fix typo in a comment: size - side
Reported-by: Stefan Hajnoczi stefa...@gmail.com
Signed-off-by: Michael S. Tsirkin m...@redhat.com
I could smerge these together for you, but I *really* want benchmarks in
these
On Wed, 4 May 2011 23:51:47 +0300, Michael S. Tsirkin m...@redhat.com wrote:
Use the new avail_event feature to reduce the number
of exits from the guest.
Figures here would be nice :)
@@ -228,6 +237,12 @@ add_head:
* new available array entries. */
virtio_wmb();
On Wed, 4 May 2011 23:51:38 +0300, Michael S. Tsirkin m...@redhat.com wrote:
Add support for the used_event idx feature: when enabling
interrupts, publish the current avail index value to
the host so that we get interrupts on the next update.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
On Wed, 4 May 2011 23:51:19 +0300, Michael S. Tsirkin m...@redhat.com wrote:
Define a new feature bit for the host to
declare that it uses an avail_event index
(like Xen) instead of a feature bit
to enable/disable interrupts.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
On Wed, 20 Apr 2011 21:21:59 +0800, Liu Yuan namei.u...@gmail.com wrote:
From: Liu Yuan tailai...@taobao.com
In the function vp_request_msix_vectors(), when
pci_enable_msix() returns 0, there will be
redundant double checks for 'err'. This patch
fixes it to avoid the unnecessary check.
On Sat, 23 Apr 2011 18:13:34 -0500, Rob Landley rland...@parallels.com wrote:
From: Rob Landley rland...@parallels.com
Going indirect for only two buffers isn't likely to be a performance win
because the kmalloc/kfree overhead for the indirect block can't be cheaper
than one extra linked
On Thu, 14 Apr 2011 13:30:05 -0700, Dave Hansen d...@linux.vnet.ibm.com wrote:
Here's a new commit message:
Applied, thanks.
Rusty.
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
On Tue, 12 Apr 2011 09:22:32 -0700, Dave Hansen d...@linux.vnet.ibm.com wrote:
On Tue, 2011-04-12 at 11:13 +0530, Amit Shah wrote:
Sure, the only contention was on the commit message, where you stated
modern qemus set this... qemu doesn't, and it should. Care to do a
patch for that?
If
On Mon, 11 Apr 2011 19:55:25 +0300, Michael S. Tsirkin m...@redhat.com
wrote:
Extend features to 64 bit so we can use more
transport bits.
Future patches add two new feature bits which would
exhaust the supply of transport feature bits,
so let's add bit 31 to tell the guest that
there are
On Thu, 07 Apr 2011 10:43:25 -0700, Dave Hansen d...@linux.vnet.ibm.com wrote:
The virtio balloon driver has a VIRTIO_BALLOON_F_MUST_TELL_HOST
feature bit. Whenever the bit is set, we must always tell the
host before we free pages back to the allocator. Without this
we might free a page
On Tue, 05 Apr 2011 07:08:12 +0200, Jens Axboe jax...@fusionio.com wrote:
On 2011-04-05 06:49, Takuma Umeya wrote:
When virtio block device is removed, index does not get decremented. When
another virtio disk is attached it uses the next device letter to the
one that is suppose to be
On Mon, 28 Mar 2011 19:57:06 +0530, Amit Shah amit.s...@redhat.com wrote:
On (Thu) 17 Mar 2011 [17:56:59], Amit Shah wrote:
On (Thu) 17 Mar 2011 [15:26:28], Rusty Russell wrote:
On Wed, 16 Mar 2011 19:12:10 +0530, Amit Shah amit.s...@redhat.com
wrote:
When detaching a buffer from
On Wed, 16 Mar 2011 19:12:10 +0530, Amit Shah amit.s...@redhat.com wrote:
When detaching a buffer from a vq, the avail.idx value should be
decremented as well.
This was noticed by hot-unplugging a virtio console port and then
plugging in a new one on the same number (re-using the vqs which
On Fri, 11 Mar 2011 16:46:28 +0530, Amit Shah amit.s...@redhat.com wrote:
Ideally virtio_pci_release_dev() shouldn't be needed at all; all that
work can be moved to virtio_pci_remove(). virtio_pci_release_dev()
was added in 29f9f12e to curb a warning:
virtio: add PCI device release()
On Thu, 10 Mar 2011 16:05:41 +0900, Magnus Damm magnus.d...@gmail.com wrote:
virtio: Virtio platform driver
[PATCH 01/02] virtio: Break out lguest virtio code to virtio_lguest.c
[PATCH 02/02] virtio: Add virtio platform driver
I have no problem with these patches, but it's just churn until
On Mon, 14 Mar 2011 17:45:02 +0530, Amit Shah amit.s...@redhat.com wrote:
In the case where a virtio-console port is in use (opened by a program)
and a virtio-console device is removed, the port is kept around but all
the virtio-related state is assumed to be gone.
When the port is finally
On Mon, 14 Mar 2011 17:45:48 +0530, Amit Shah amit.s...@redhat.com wrote:
This call was disabled as hot-unplugging one virtconsole port led to
another virtconsole port freezing.
Upon testing it again, this now works, so enable it.
Applied,
Rusty.
That's already been done by the virtio infrastructure before the probe
function is called.
Reported-by: alexey.kardashevs...@au1.ibm.com
Signed-off-by: Rusty Russell ru...@rustcorp.com.au
diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c
--- a/drivers/char
On Wed, 2 Mar 2011 13:53:06 +0530, Amit Shah amit.s...@redhat.com wrote:
A crash was observed when a device gets removed while a port is in
use. When the port gets removed, we tried to free vq buffers. The vq
no longer exists at this stage, just ensure we don't access it.
The second patch
On Tue, 15 Feb 2011 08:05:27 pm Michal Hocko wrote:
Hi,
we have started seeing a lot of allocator messages complaining about
failed allocations from virtnet_poll in soft IRQ. Could you consider the
following patch, please?
Do we really want to silence this? Isn't warning about it kind of the
On Tue, 15 Feb 2011 08:55:50 pm Michal Hocko wrote:
On Tue 15-02-11 20:41:29, Rusty Russell wrote:
On Tue, 15 Feb 2011 08:05:27 pm Michal Hocko wrote:
Hi,
we have started seeing a lot of allocator messages complaining about
failed allocations from virtnet_poll in soft IRQ. Could you
On Thu, 10 Feb 2011 06:59:25 am Ken Stailey wrote:
Justification:
Impact: Under heavy network I/O load virtio-net driver crashes making VM
guest unusable.
Hmm, this went badly wrong. I acked this patch, and it was mailed to
netdev six months ago.
Bruce's patch used spaces instead of tabs,
subsequent to each napi_enable.
Signed-off-by: Bruce Rogers brog...@novell.com
Signed-off-by: Olaf Kirch o...@suse.de
Cc: sta...@kernel.org
Signed-off-by: Rusty Russell ru...@rustcorp.com.au
---
drivers/net/virtio_net.c | 27 ---
1 file changed, 16 insertions(+), 11 deletions
On Mon, 31 Jan 2011 06:06:36 pm Amit Shah wrote:
The outvq needs to be woken up on host notifications so that buffers
consumed by the host can be reclaimed, outvq freed, and application
writes may proceed again.
The need for this is now finally noticed when I have qemu patches ready
to use
On Mon, 31 Jan 2011 08:33:15 pm Rusty Russell wrote:
On Mon, 31 Jan 2011 06:06:36 pm Amit Shah wrote:
The outvq needs to be woken up on host notifications so that buffers
consumed by the host can be reclaimed, outvq freed, and application
writes may proceed again.
The need
On Tue, 1 Feb 2011 08:41:44 am Linus Torvalds wrote:
On Mon, Jan 31, 2011 at 4:16 PM, Rusty Russell ru...@rustcorp.com.au wrote:
Patches should keep coming through Rusty but it
helps if I'm Cc'd as well.
This commit log makes no sense as being yours. It's clearly frm
Michael, but you're
Patches should keep coming through Rusty but it
helps if I'm Cc'd as well.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
Signed-off-by: Rusty Russell ru...@rustcorp.com.au
---
MAINTAINERS | 10 ++
1 file changed, 10 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index
limit
logic
lguest: document --rng in example Launcher
Randy Dunlap (1):
LGUEST_GUEST: fix unmet direct dependencies (VIRTUALIZATION VIRTIO)
Rusty Russell (1):
lguest: compile fixes
Documentation/lguest/lguest.c | 73 ++
Documentation
On Mon, 17 Jan 2011 09:07:30 am Simon Horman wrote:
[snip]
I've been away, but what concerns me is that socket buffer limits are
bypassed in various configurations, due to skb cloning. We should probably
drop such limits altogether, or fix them to be consistent.
Simple fix is as someone
On Tue, 11 Jan 2011 03:49:04 am Michael S. Tsirkin wrote:
On Mon, Jan 10, 2011 at 07:10:46PM +0200, Gleb Natapov wrote:
On Fri, Jan 07, 2011 at 02:55:06AM -0600, Milton Miller wrote:
We sometimes need to map between the virtio device and
the given pci device. One such use is OS installer
On Sun, 2 Jan 2011 05:38:46 am Randy Dunlap wrote:
From: Randy Dunlap randy.dun...@oracle.com
Honor the kconfig menu hierarchy to remove kconfig dependency warnings:
VIRTIO and VIRTIO_RING are subordinate to VIRTUALIZATION.
warning: (LGUEST_GUEST) selects VIRTIO which has unmet direct
On Tue, 14 Dec 2010 03:54:47 am Michael S. Tsirkin wrote:
On Mon, Dec 13, 2010 at 12:44:13PM +0200, Michael S. Tsirkin wrote:
Please merge the following tree for 2.6.38.
Thanks!
Um, I sent this out before I noticed the mail from Rusty
with some questions on the test code. I missed that
(lguest is currently broken, but timed out chasing it; expect a patch next
week once I get back).
The following changes since commit 3561d43fd289f590fdae672e5eb831b8d5cf0bf6:
Linux 2.6.37-rc3 (2010-11-21 15:18:56 -0800)
are available in the git repository at:
On Wed, 10 Nov 2010 04:50:29 pm Stephen Hemminger wrote:
The sysfs files for virtio produce the wrong format and are missing
the required newline. The output for virtio bus vendor/device should
have the same format as the corresponding entries for PCI devices.
Although this technically
On Sat, 6 Nov 2010 07:36:50 pm Jiri Slaby wrote:
Stanse found that in init_vqs, memory is leaked under certain
circumstanses (the fail path order is incorrect). Fix that by checking
allocations in one turn and free all of them at once if some fails
(some may be NULL, but this is OK).
Good
On Sat, 30 Oct 2010 01:29:33 pm Simon Horman wrote:
[ CCed VHOST contacts ]
On Thu, Oct 28, 2010 at 01:22:02PM -0700, Jesse Gross wrote:
On Thu, Oct 28, 2010 at 4:54 AM, Simon Horman ho...@verge.net.au wrote:
My reasoning is that in the non-mirroring case the guest is
limited by the
On Wed, 27 Oct 2010 11:30:31 pm Ian Molton wrote:
On 19/10/10 11:39, Avi Kivity wrote:
On 10/19/2010 12:31 PM, Ian Molton wrote:
2. should start with a patch to the virtio-pci spec to document what
you're doing
Where can I find that spec?
http://ozlabs.org/~rusty/virtio-spec/
The following changes since commit f6f94e2ab1b33f0082ac22d71f66385a60d8157f:
Linux 2.6.36 (2010-10-20 13:30:22 -0700)
are available in the git repository at:
ssh://master.kernel.org/pub/scm/linux/kernel/git/rusty/linux-2.6-for-linus.git
virtio
Amit Shah (18):
virtio: console: Reset
in the virtio ring as well as they don't return
-EAGAIN to userspace.
Signed-off-by: Amit Shah amit.s...@redhat.com
Acked-by: Hans de Goede hdego...@redhat.com
CC: sta...@kernel.org
Signed-off-by: Rusty Russell ru...@rustcorp.com.au
---
drivers/char/virtio_console.c | 17 ++---
1 file
On Wed, 6 Oct 2010 12:20:01 am Amit Shah wrote:
Hello Rusty,
A few trivial fixes on top of virtio-spec-0.8.9 (patch -p0):
Thanks, applied.
If you turn on lyx change tracking, patches get uglier but it means
annotations of differences show up in next version.
Thanks!
Rusty.
-for-linus.git
master
Amit Shah (1):
virtio: console: Prevent userspace from submitting NULL buffers
Hans de Goede (1):
virtio: console: Fix poll blocking even though there is data to read
Rusty Russell (1):
lguest: update comments to reflect LHCALL_LOAD_GDT_ENTRY.
arch/x86/lguest
On Wed, 15 Sep 2010 11:16:24 pm Amit Shah wrote:
On (Wed) Sep 15 2010 [15:37:21], Hans de Goede wrote:
--- linux-2.6.35.x86_64/drivers/char/virtio_console.c~2010-08-02
00:11:14.0 +0200
+++ linux-2.6.35.x86_64/drivers/char/virtio_console.c 2010-09-15
13:39:29.043505000
On Sun, 12 Sep 2010 06:30:43 pm Avi Kivity wrote:
On 09/12/2010 02:42 AM, Alexander Graf wrote:
On 24.08.2010, at 15:48, Alexander Graf wrote:
The one big missing feature in s390-virtio was hotplugging. This is no
more.
This patch implements hotplug add support, so you can on the fly
On Thu, 2 Sep 2010 10:11:41 pm Amit Shah wrote:
If a portdev isn't using multiport support, it won't have any control vq
data to remove.
Signed-off-by: Amit Shah amit.s...@redhat.com
So previously it would crash if it was ever removed? If so, it'd be
nice to see that in the patch
On Thu, 2 Sep 2010 10:47:54 pm Amit Shah wrote:
If a port has registered for SIGIO signals, let the application
know that the port is getting unplugged.
Signed-off-by: Amit Shah amit.s...@redhat.com
Thanks Amit, these patches were really well organized and nice to read.
Applied them all...
, but let's apply
a minimal fix for 2.6.35.
Reported-by: Chris Mason chris.ma...@oracle.com
Signed-off-by: Michael S. Tsirkin m...@redhat.com
Signed-off-by: Rusty Russell ru...@rustcorp.com.au
Tested-by: Chris Mason chris.ma...@oracle.com
---
diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio
On Thu, 24 Jun 2010 12:49:56 pm Ryan Harper wrote:
Using Rusty's suggestion I've respun the patch removing the special copy
function. I've tested this patch in a guest kernel with and without qemu
supplying serial numbers for the block devices and it's working as expected.
When qemu supplies
On Thu, 24 Jun 2010 03:00:30 pm Stefan Hajnoczi wrote:
On Wed, Jun 23, 2010 at 11:12 PM, Anthony Liguori anth...@codemonkey.ws
wrote:
Shouldn't it be possible to just drop the lock before invoking
virtqueue_kick() and reacquire it afterwards? There's nothing in that
virtqueue_kick() path
.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
Acked-by: Amit Shah amit.s...@redhat.com
Signed-off-by: Rusty Russell ru...@rustcorp.com.au
Cc: sta...@kernel.org # .34.x
drivers/virtio/virtio_ring.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
commit
On Tue, 22 Jun 2010 02:13:21 am Ryan Harper wrote:
* john cooper john.coo...@redhat.com [2010-06-21 01:11]:
Rusty Russell wrote:
On Sat, 19 Jun 2010 04:08:02 am Ryan Harper wrote:
Create a new attribute for virtio-blk devices that will fetch the serial
number
of the block device
On Sat, 19 Jun 2010 04:08:03 am Ryan Harper wrote:
With the availablility of a sysfs device attribute for examining disk serial
numbers the ioctl is no longer needed. The user-space changes for this aren't
upstream yet so we don't have any users to worry about.
If John Cooper acks this, I'll
On Sat, 19 Jun 2010 04:08:02 am Ryan Harper wrote:
Create a new attribute for virtio-blk devices that will fetch the serial
number
of the block device. This attribute can be used by udev to create disk/by-id
symlinks for devices that don't have a UUID (filesystem) associated with them.
not stop the
device until some request completes - there's no guarantee anything
at all is outstanding.
Make the error message clearer as well: error here does not
indicate queue full.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
Signed-off-by: Rusty Russell ru...@rustcorp.com.au
On Fri, 4 Jun 2010 09:12:05 pm Michael S. Tsirkin wrote:
On Fri, Jun 04, 2010 at 08:46:49PM +0930, Rusty Russell wrote:
I'm uncomfortable with moving a field.
We haven't done that before and I wonder what will break with old code.
With e.g. my patch, We only do this conditionally when
-by: Rusty Russell ru...@rustcorp.com.au
Cc: sta...@kernel.org
Thanks!
Rusty.
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/virtualization
On Wed, 2 Jun 2010 12:17:12 am Michael S. Tsirkin wrote:
This adds an (unused) option to put available ring before control (avail
index, flags), and adds padding between index and flags. This avoids
cache line sharing between control and ring, and also makes it possible
to extend avail control
On Thu, 27 May 2010 05:20:35 am Michael S. Tsirkin wrote:
Here's a rewrite of the original patch with a new layout.
I haven't tested it yet so no idea how this performs, but
I think this addresses the cache bounce issue raised by Avi.
Posting for early flames/comments.
Sorry, not without some
On Thu, 20 May 2010 02:31:50 pm Rusty Russell wrote:
On Wed, 19 May 2010 05:36:42 pm Avi Kivity wrote:
Note that this is a exclusive-shared-exclusive bounce only, too.
A bounce is a bounce.
I tried to measure this to show that you were wrong, but I was only able
to show
On Tue, 18 May 2010 09:03:17 pm Michael S. Tsirkin wrote:
Rusty, the patch virtio: imply disable_cb on callbacks is on your tree.
I'd like to figure out how it works: for example:
diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
--- a/drivers/block/virtio_blk.c
+++
On Thu, 6 May 2010 03:57:55 pm Michael S. Tsirkin wrote:
On Thu, May 06, 2010 at 10:22:12AM +0930, Rusty Russell wrote:
On Wed, 5 May 2010 03:52:36 am Michael S. Tsirkin wrote:
What do you think?
I think everyone is settled on 128 byte cache lines for the forseeable
future, so it's
On Thu, 6 May 2010 07:30:00 pm Avi Kivity wrote:
On 05/05/2010 11:58 PM, Michael S. Tsirkin wrote:
+ /* We publish the last-seen used index at the end of the available ring.
+* It is at the end for backwards compatibility. */
+ vr-last_used_idx =(vr)-avail-ring[num];
+ /* Verify
On Thu, 6 May 2010 03:49:46 pm Michael S. Tsirkin wrote:
Now, I also added an mb() in guest between read and write so
that last used index write can not get ahead of used index read.
It does feel good to have it there, but I can not say why
it's helpful. Works fine without it, but then these
-off-by: Rusty Russell ru...@rustcorp.com.au
Cc: sta...@kernel.org
---
drivers/Makefile |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/Makefile b/drivers/Makefile
index 34f1e10..f42a030 100644
--- a/drivers/Makefile
+++ b/drivers/Makefile
@@ -17,6 +17,7 @@ obj
after the avail ring
and the used ring, whatever the number of descriptors (which must be a
power of 2).
We add a feature bit so the guest can tell the host that it's writing
out the current value there, if it wants to use that.
Signed-off-by: Rusty Russell ru...@rustcorp.com.au
On Wed, 5 May 2010 08:39:47 pm Michael S. Tsirkin wrote:
Hi!
I see this in virtio_ring.c:
/* Put entry in available array (but don't update avail-idx *
until they do sync). */
Why is it done this way?
It seems that updating the index straight away would be simpler, while
On Thu, 6 May 2010 06:05:06 am Amit Shah wrote:
Hello,
This series adds resize support for multiple console ports. The size
for each console is stored in its structure and the host informs the
guest about size changes via the VIRTIO_CONSOLE_RESIZE control
message.
Thanks, applied!
Rusty.
On Thu, 6 May 2010 06:28:14 am Michael S. Tsirkin wrote:
Rusty,
this is a simplified form of a patch you posted in the past.
I have a vhost patch that, using this feature, shows external
to host bandwidth grow from 5 to 7 GB/s, by avoiding
an interrupt in the window after previous interrupt
On Wed, 5 May 2010 04:24:59 am Christoph Hellwig wrote:
On Fri, Feb 19, 2010 at 12:22:20AM +0200, Michael S. Tsirkin wrote:
I took a stub at documenting CMD and FLUSH request types in virtio
block. Christoph, could you look over this please?
I note that the interface seems full of warts
On Wed, 5 May 2010 05:47:05 am Jamie Lokier wrote:
Jens Axboe wrote:
On Tue, May 04 2010, Rusty Russell wrote:
ISTR someone mentioning a desire for such an API years ago, so CC'ing the
usual I/O suspects...
It would be nice to have a more fuller API for this, but the reality
On Fri, 19 Feb 2010 08:52:20 am Michael S. Tsirkin wrote:
I took a stub at documenting CMD and FLUSH request types in virtio
block. Christoph, could you look over this please?
I note that the interface seems full of warts to me,
this might be a first step to cleaning them.
ISTR Christoph
if allocation fails, since we retry after sometime anyway.
Signed-off-by: Balbir Singh bal...@linux.vnet.ibm.com
Signed-off-by: Rusty Russell ru...@rustcorp.com.au
Cc: kvm k...@vger.kernel.org
Cc: sta...@kernel.org
---
drivers/virtio/virtio_balloon.c |3 ++-
1 files changed, 2 insertions(+), 1
801 - 900 of 1486 matches
Mail list logo
