[PATCH] drivers/virt: add missing linux/interrupt.h to fsl_hypervisor.c

2011-07-19 Thread Timur Tabi
fsl_hypervisor.c calls request_irq() but does not include linux/interrupt.h. Normally, the driver will compile without error, but it can fail on some configurations. Signed-off-by: Timur Tabi ti...@freescale.com --- drivers/virt/fsl_hypervisor.c |1 + 1 files changed, 1 insertions(+), 0

Re: [PATCH 7/7] [v4] drivers/virt: introduce Freescale hypervisor management driver

2011-06-10 Thread Timur Tabi
Randy Dunlap wrote: But it sounds like virt/ needs virt/host/ and virt/guest/ to me. I'm okay with that idea, except there's a consensus that drivers should be in drivers/. -- Timur Tabi Linux kernel developer at Freescale ___ Virtualization mailing

Re: [PATCH 7/7] [v4] drivers/virt: introduce Freescale hypervisor management driver

2011-06-10 Thread Timur Tabi
a good point. Ok, so maybe I don't have any really good answers here. :-) -- Timur Tabi Linux kernel developer at Freescale ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo

[PATCH 7/7] [v5] drivers/virt: introduce Freescale hypervisor management driver

2011-06-09 Thread Timur Tabi
down. Signed-off-by: Timur Tabi ti...@freescale.com --- drivers/Kconfig|2 + drivers/Makefile |3 + drivers/virt/Kconfig | 32 ++ drivers/virt/Makefile |5 + drivers/virt/fsl_hypervisor.c | 983

Re: [PATCH 7/7] [v5] drivers/virt: introduce Freescale hypervisor management driver

2011-06-09 Thread Timur Tabi
there already are, I wonder what the point is. Even if I pick a number that is currently not listed in the chart, that doesn't mean that it's actually not being used, or that it won't conflict in the future. So is it okay to stick with 0, or do I need to pick a new number? -- Timur Tabi Linux kernel

Re: [PATCH 7/7] [v5] drivers/virt: introduce Freescale hypervisor management driver

2011-06-09 Thread Timur Tabi
it to Documentation/ioctl/ioctl-number.txt in the same patch. Ok, I was really hoping to avoid doing this. Like I said, binary compatibility is important, and changing the type will break my existing apps. Are you insisting that I pick a new number? -- Timur Tabi Linux kernel developer at Freescale

Re: [PATCH 7/7] [v5] drivers/virt: introduce Freescale hypervisor management driver

2011-06-09 Thread Timur Tabi
, and then wonder why nothing works. But as Arnd pointed out, it really isn't as big of deal as I make it out to be. I can maintain compatibility internally. I blame my allergy medicine. -- Timur Tabi Linux kernel developer at Freescale

[PATCH 7/7] [v6] drivers/virt: introduce Freescale hypervisor management driver

2011-06-09 Thread Timur Tabi
down. Signed-off-by: Timur Tabi ti...@freescale.com --- Documentation/ioctl/ioctl-number.txt |1 + drivers/Kconfig |2 + drivers/Makefile |3 + drivers/virt/Kconfig | 32 ++ drivers/virt/Makefile|5 + drivers