Hi Amit,
Sorry for the late reply.
(2013/07/19 19:05), Amit Shah wrote:
On (Fri) 19 Jul 2013 [18:19:51], Yoshihiro YUNOMAE wrote:
Hi,
This patch set fixes two bugs of splice_write in the virtio-console driver.
[BUG1] Although pipe-nrbufs is empty, the driver tries to do splice_write
in splice_from_pipe_feed() by bug of any user
application.
These reports are written in each patch.
Changes in V2:
- Fix a locking problem for error
Changes in V3:
- Add Reviewed-by lines and stable@ line in sign-off area
Thanks!
---
Yoshihiro YUNOMAE (2):
[BUGFIX] virtio/console: Quit from
splice_write is executed in the virtio-console driver.
V3: Add Reviewed-by lines and stable@ line in sign-off area.
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
Reviewed-by: Amit Shah amit.s...@redhat.com
Reviewed-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Cc: Amit Shah
in splice_from_pipe_feed() by bug of any user
application.
These reports are written in each patch.
Changes in V2:
- Fix a locking problem for error
Thanks!
---
Yoshihiro YUNOMAE (2):
[BUGFIX] virtio/console: Quit from splice_write if pipe-nrbufs is 0
[BUGFIX] virtio/console: Add pipe_lock
splice_write is executed in the virtio-console driver.
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
Cc: Amit Shah amit.s...@redhat.com
Cc: Arnd Bergmann a...@arndb.de
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/char/virtio_console.c |7 +++
1 file changed, 7
89 e6 4c 89 ff 41
RIP [811a6b5f] splice_from_pipe_feed+0x6f/0x130
RSP 88007b55fd78
CR2: 0018
---[ end trace 24572beb7764de59 ]---
V2: Fix a locking problem for error
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
Cc: Amit Shah amit.s...@redhat.com
-blocking mode in QEMU
Thank you,
---
Masami Hiramatsu (2):
trace-cmd: Use tracing directory to count CPUs
trace-cmd: Use TRACE_DIR envrionment variable if defined
Yoshihiro YUNOMAE (3):
trace-cmd: Use polling function
trace-cmd: Add non-blocking option for open
From: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Use TRACE_DIR environment variable for setting
debugfs/tracing directory if defined. This is
for controlling guest(or remote) ftrace.
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Signed-off-by: Yoshihiro YUNOMAE
\
trace-cmd record -e sched:*
Here, AGENT_READ_DIR is the path for a reading directory of virtio-trace,
AGENT_CTL is a control path of trace-agent, and TRACING_DIR is a debugfs path
of a guest.
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
---
trace-cmd.h |1
nonblock option to open() and splice_read().
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
---
trace-recorder.c | 13 -
1 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/trace-recorder.c b/trace-recorder.c
index 3b750e9..6577fe8 100644
--- a/trace
Use poll() for avoiding a busy loop to read trace data of a guest from FIFO.
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
---
trace-recorder.c | 42 --
1 files changed, 36 insertions(+), 6 deletions(-)
diff --git a/trace-recorder.c
Hi Steven,
(2012/08/22 22:51), Steven Rostedt wrote:
On Wed, 2012-08-22 at 17:43 +0900, Yoshihiro YUNOMAE wrote:
Add read path and control path to use trace-agent of virtio-trace.
When we use trace-agent, trace-cmd will be used as follows:
# AGENT_READ_DIR=/tmp/virtio-trace/tracing
the port is ready on splice
virtio/console: Add a failback for unstealable pipe buffer
virtio/console: Add splice_write support
Yoshihiro YUNOMAE (1):
tools: Add guest trace agent as a user tool
drivers/char/virtio_console.c | 198 ++--
kernel/trace
From: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Enable to use splice_write from pipe to virtio-console port.
This steals pages from pipe and directly send it to host.
Note that this may accelerate only the guest to host path.
Changes in v2:
- Use GFP_KERNEL instead of GFP_ATOMIC in
From: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Add a failback memcpy path for unstealable pipe buffer.
If buf-ops-steal() fails, virtio-serial tries to
copy the page contents to an allocated page, instead
of just failing splice().
Signed-off-by: Masami Hiramatsu
From: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Wait if the port is not connected or full on splice
like as write is doing.
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
---
drivers/char/virtio_console.c | 39 +++
1 files changed,
From: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Allocate scatterlist according to the current pipe size.
This allows splicing bigger buffer if the pipe size has
been changed by fcntl.
Changes in v2:
- Just a minor fix for avoiding a confliction with previous patch.
Signed-off-by: Masami
trace data to stdout by using -o option
- controlled by start/stop orders from a Host
Changes in v2:
- Cleanup (change fprintf() to pr_err() and an include guard)
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
---
tools/virtio/virtio-trace/Makefile | 14 +
tools
Hi Amit,
Thank you for commenting on our work.
(2012/07/26 20:35), Amit Shah wrote:
On (Tue) 24 Jul 2012 [11:36:57], Yoshihiro YUNOMAE wrote:
[...]
Therefore, we propose a new system virtio-trace, which uses enhanced
virtio-serial and existing ring-buffer of ftrace, for collecting guest
Hi Stefan,
(2012/07/24 22:41), Stefan Hajnoczi wrote:
On Tue, Jul 24, 2012 at 12:19 PM, Yoshihiro YUNOMAE
yoshihiro.yunomae...@hitachi.com wrote:
Are you using text formatted ftrace?
No, currently using raw format, but　we'd like to reformat it in text.
Capturing the info necessary
Hi Stefan,
Thank you for commenting on our patch set.
(2012/07/24 20:03), Masami Hiramatsu wrote:
(2012/07/24 19:02), Stefan Hajnoczi wrote:
On Tue, Jul 24, 2012 at 3:36 AM, Yoshihiro YUNOMAE
yoshihiro.yunomae...@hitachi.com wrote:
The performance of each method is compared as follows:
[1
splice_write support
Yoshihiro YUNOMAE (1):
tools: Add guest trace agent as a user tool
drivers/char/virtio_console.c | 198 ++--
kernel/trace/trace.c|8 -
tools/virtio/virtio-trace/Makefile | 14 +
tools/virtio/virtio
From: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Enable to use splice_write from pipe to virtio-console port.
This steals pages from pipe and directly send it to host.
Note that this may accelerate only the guest to host path.
Signed-off-by: Masami Hiramatsu
From: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Wait if the port is not connected or full on splice
like as write is doing.
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Cc: Amit Shah amit.s...@redhat.com
Cc: Arnd Bergmann a...@arndb.de
Cc: Greg Kroah-Hartman
From: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Use generic steal operation on pipe buffer to allow stealing
ring buffer's read page from pipe buffer.
Note that this could reduce the performance of splice on the
splice_write side operation without affinity setting.
Since the ring buffer's
From: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Allocate scatterlist according to the current pipe size.
This allows splicing bigger buffer if the pipe size has
been changed by fcntl.
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Cc: Amit Shah amit.s...@redhat.com
Cc:
trace data to stdout by using -o option
- controlled by start/stop orders from a Host
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
---
tools/virtio/virtio-trace/Makefile | 14 +
tools/virtio/virtio-trace/README| 118
tools/virtio/virtio
27 matches
Mail list logo
