Re: [GIT PULL] virtio: last minute fixup

2022-05-16 Thread Michael S. Tsirkin
On Thu, May 12, 2022 at 10:10:34AM -0700, Linus Torvalds wrote: > On Thu, May 12, 2022 at 6:30 AM Michael Ellerman wrote: > > > > Links to other random places don't serve that function. > > What "function"? > > This is my argument. Those Link: things need to have a *reason*. > > Saying "they ar

Re: [GIT PULL] virtio: last minute fixup

2022-05-13 Thread Eric W. Biederman
Linus Torvalds writes: > On Thu, May 12, 2022 at 10:10 AM Linus Torvalds > wrote: >> >> And most definitely not just random data that can be trivially >> auto-generated after-the-fact. > > Put another way: when people asked for change ID's and I said "we have > links", I by no means meant that "

Re: [GIT PULL] virtio: last minute fixup

2022-05-13 Thread Michael S. Tsirkin
On Wed, May 11, 2022 at 02:24:23PM +0200, Jörg Rödel wrote: > On Tue, May 10, 2022 at 11:23:11AM -0700, Linus Torvalds wrote: > > And - once again - I want to complain about the "Link:" in that commit. > > I have to say that for me (probably for others as well) those Link tags > pointing to the pa

Re: [GIT PULL] virtio: last minute fixup

2022-05-12 Thread Linus Torvalds
On Thu, May 12, 2022 at 10:10 AM Linus Torvalds wrote: > > And most definitely not just random data that can be trivially > auto-generated after-the-fact. Put another way: when people asked for change ID's and I said "we have links", I by no means meant that "you can just add random worthless lin

Re: [GIT PULL] virtio: last minute fixup

2022-05-12 Thread Linus Torvalds
On Thu, May 12, 2022 at 6:30 AM Michael Ellerman wrote: > > Links to other random places don't serve that function. What "function"? This is my argument. Those Link: things need to have a *reason*. Saying "they are a change ID" is not a reason. That's just a random word-salad. You need to have

Re: [GIT PULL] virtio: last minute fixup

2022-05-12 Thread Michael Ellerman
Linus Torvalds writes: > On Wed, May 11, 2022 at 3:12 AM Michael Ellerman wrote: >> >> Which I read as you endorsing Link: tags :) > > I absolutely adore "Link:" tags. They've been great. > > But they've been great for links that are *usedful*. > > They are wonderful when they link to the origina

Re: [GIT PULL] virtio: last minute fixup

2022-05-11 Thread Theodore Ts'o
On Wed, May 11, 2022 at 12:31:16PM -0400, Konstantin Ryabitsev wrote: > > But my mailer, editor and terminal don't know what to do with a Message-Id. > > > > Whereas they can all open an https link. > > > > Making people paste message ids into lore to see the original submission > > is not a win.

Re: [GIT PULL] virtio: last minute fixup

2022-05-11 Thread Linus Torvalds
On Wed, May 11, 2022 at 3:12 AM Michael Ellerman wrote: > > Which I read as you endorsing Link: tags :) I absolutely adore "Link:" tags. They've been great. But they've been great for links that are *usedful*. They are wonderful when they link to the original problem. They are *really* wonderf

Re: [GIT PULL] virtio: last minute fixup

2022-05-11 Thread Michael Ellerman
Konstantin Ryabitsev writes: ... > > I think we should simply disambiguate the trailer added by tooling like b4. > Instead of using Link:, it can go back to using Message-Id, which is already > standard with git -- it's trivial for git.kernel.org to link them to > lore.kernel.org. But my mailer,

Re: [GIT PULL] virtio: last minute fixup

2022-05-11 Thread Jörg Rödel
On Tue, May 10, 2022 at 11:23:11AM -0700, Linus Torvalds wrote: > And - once again - I want to complain about the "Link:" in that commit. I have to say that for me (probably for others as well) those Link tags pointing to the patch submission have quite some value: 1) First of all it is a

Re: [GIT PULL] virtio: last minute fixup

2022-05-11 Thread Michael Ellerman
Linus Torvalds writes: > On Tue, May 10, 2022 at 5:24 AM Michael S. Tsirkin wrote: >> >> A last minute fixup of the transitional ID numbers. >> Important to get these right - if users start to depend on the >> wrong ones they are very hard to fix. > > Hmm. I've pulled this, but those numbers aren

Re: [GIT PULL] virtio: last minute fixup

2022-05-11 Thread Michael S. Tsirkin
On Tue, May 10, 2022 at 04:50:47PM -0700, Linus Torvalds wrote: > On Tue, May 10, 2022 at 4:12 PM Nathan Chancellor wrote: > > > > For what it's worth, as someone who is frequently tracking down and > > reporting issues, a link to the mailing list post in the commit message > > makes it much easie

Re: [GIT PULL] virtio: last minute fixup

2022-05-10 Thread Michael S. Tsirkin
On Tue, May 10, 2022 at 11:23:11AM -0700, Linus Torvalds wrote: > On Tue, May 10, 2022 at 5:24 AM Michael S. Tsirkin wrote: > > > > A last minute fixup of the transitional ID numbers. > > Important to get these right - if users start to depend on the > > wrong ones they are very hard to fix. > >

Re: [GIT PULL] virtio: last minute fixup

2022-05-10 Thread Linus Torvalds
On Tue, May 10, 2022 at 4:12 PM Nathan Chancellor wrote: > > For what it's worth, as someone who is frequently tracking down and > reporting issues, a link to the mailing list post in the commit message > makes it much easier to get these reports into the right hands, as the > original posting is

Re: [GIT PULL] virtio: last minute fixup

2022-05-10 Thread pr-tracker-bot
The pull request you sent on Tue, 10 May 2022 08:23:51 -0400: > https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/feb9c5e19e913b53cb536a7aa7c9f20107bb51ec Thank you! -- Deet-doot-dot, I am a b

Re: [GIT PULL] virtio: last minute fixup

2022-05-10 Thread Linus Torvalds
On Tue, May 10, 2022 at 5:24 AM Michael S. Tsirkin wrote: > > A last minute fixup of the transitional ID numbers. > Important to get these right - if users start to depend on the > wrong ones they are very hard to fix. Hmm. I've pulled this, but those numbers aren't exactly "new". They've been t

[GIT PULL] virtio: last minute fixup

2022-05-10 Thread Michael S. Tsirkin
The following changes since commit 1c80cf031e0204fde471558ee40183695773ce13: vdpa: mlx5: synchronize driver status with CVQ (2022-03-30 04:18:14 -0400) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch chang