[PATCH] Bluetooth: virtio_bt: fix device removal

2022-08-09 Thread Igor Skalkin
Tested-by: Igor Skalkin Please mind our privacy notice pursuant to Art. 13 GDPR. // Unsere Hinweise zum Datenschutz gem. Art. 13 DSGVO

Re: [PATCH] Bluetooth: virtio_bt: fix device removal

2022-06-27 Thread Michael S. Tsirkin
On Mon, Jun 13, 2022 at 02:58:59AM -0400, Michael S. Tsirkin wrote: > On Fri, Jan 14, 2022 at 03:12:47PM -0500, Michael S. Tsirkin wrote: > > On Thu, Dec 16, 2021 at 08:58:31PM +0100, Marcel Holtmann wrote: > > > Hi Michael, > > > > > > > Device removal is clearly out of virtio spec: it attemp

Re: [PATCH] Bluetooth: virtio_bt: fix device removal

2022-06-12 Thread Michael S. Tsirkin
On Fri, Jan 14, 2022 at 03:12:47PM -0500, Michael S. Tsirkin wrote: > On Thu, Dec 16, 2021 at 08:58:31PM +0100, Marcel Holtmann wrote: > > Hi Michael, > > > > > Device removal is clearly out of virtio spec: it attempts to remove > > > unused buffers from a VQ before invoking device reset.

Re: [PATCH] Bluetooth: virtio_bt: fix device removal

2022-01-14 Thread Michael S. Tsirkin
On Thu, Dec 16, 2021 at 08:58:31PM +0100, Marcel Holtmann wrote: > Hi Michael, > > > Device removal is clearly out of virtio spec: it attempts to remove > > unused buffers from a VQ before invoking device reset. To fix, make > > open/close NOPs and do all cleanup/setup in probe/remove.

Re: [PATCH] Bluetooth: virtio_bt: fix device removal

2021-12-13 Thread Michael S. Tsirkin
On Mon, Dec 13, 2021 at 05:44:13AM -0500, Michael S. Tsirkin wrote: > On Thu, Dec 09, 2021 at 04:22:58PM -0500, Michael S. Tsirkin wrote: > > On Thu, Nov 25, 2021 at 09:02:01PM +0100, Marcel Holtmann wrote: > > > Hi Michael, > > > > > > > Device removal is clearly out of virtio spec: it attempts t

Re: [PATCH] Bluetooth: virtio_bt: fix device removal

2021-12-13 Thread Michael S. Tsirkin
On Thu, Dec 09, 2021 at 04:22:58PM -0500, Michael S. Tsirkin wrote: > On Thu, Nov 25, 2021 at 09:02:01PM +0100, Marcel Holtmann wrote: > > Hi Michael, > > > > > Device removal is clearly out of virtio spec: it attempts to remove > > > unused buffers from a VQ before invoking device reset. To fix,

Re: [PATCH] Bluetooth: virtio_bt: fix device removal

2021-12-09 Thread Michael S. Tsirkin
On Thu, Nov 25, 2021 at 09:02:01PM +0100, Marcel Holtmann wrote: > Hi Michael, > > > Device removal is clearly out of virtio spec: it attempts to remove > > unused buffers from a VQ before invoking device reset. To fix, make > > open/close NOPs and do all cleanup/setup in probe/remove. > > so the

Re: [PATCH] Bluetooth: virtio_bt: fix device removal

2021-11-25 Thread Michael S. Tsirkin
On Thu, Nov 25, 2021 at 10:58:56PM +0100, Marcel Holtmann wrote: > Hi Michael, > > > Device removal is clearly out of virtio spec: it attempts to remove > > unused buffers from a VQ before invoking device reset. To fix, make > > open/close NOPs and do all cleanup/setup in probe/remove.

Re: [PATCH] Bluetooth: virtio_bt: fix device removal

2021-11-25 Thread Michael S. Tsirkin
On Thu, Nov 25, 2021 at 10:01:25PM +0100, Marcel Holtmann wrote: > Hi Michael, > > >>> Device removal is clearly out of virtio spec: it attempts to remove > >>> unused buffers from a VQ before invoking device reset. To fix, make > >>> open/close NOPs and do all cleanup/setup in probe/remove. > >>

Re: [PATCH] Bluetooth: virtio_bt: fix device removal

2021-11-25 Thread Michael S. Tsirkin
On Thu, Nov 25, 2021 at 09:02:01PM +0100, Marcel Holtmann wrote: > Hi Michael, > > > Device removal is clearly out of virtio spec: it attempts to remove > > unused buffers from a VQ before invoking device reset. To fix, make > > open/close NOPs and do all cleanup/setup in probe/remove. > > so the

[PATCH] Bluetooth: virtio_bt: fix device removal

2021-11-25 Thread Michael S. Tsirkin
Device removal is clearly out of virtio spec: it attempts to remove unused buffers from a VQ before invoking device reset. To fix, make open/close NOPs and do all cleanup/setup in probe/remove. The cost here is a single skb wasted on an unused bt device - which seems modest. NB: with this fix in