Re: [PATCH] Revert "virtio-blk: Add validation for block size in config space"

2021-10-13 Thread Michael S. Tsirkin
On Thu, Oct 14, 2021 at 10:45:25AM +0800, Jason Wang wrote: > On Wed, Oct 13, 2021 at 8:46 PM Michael S. Tsirkin wrote: > > > > It turns out that access to config space before completing the feature > > negotiation is broken for big endian guests at least with QEMU hosts up > > to 6.1 inclusive.

Re: [PATCH] Revert "virtio-blk: Add validation for block size in config space"

2021-10-13 Thread Jason Wang
On Wed, Oct 13, 2021 at 8:46 PM Michael S. Tsirkin wrote: > > It turns out that access to config space before completing the feature > negotiation is broken for big endian guests at least with QEMU hosts up > to 6.1 inclusive. This affects any device that accesses config space in > the validate

[PATCH] Revert "virtio-blk: Add validation for block size in config space"

2021-10-13 Thread Michael S. Tsirkin
It turns out that access to config space before completing the feature negotiation is broken for big endian guests at least with QEMU hosts up to 6.1 inclusive. This affects any device that accesses config space in the validate callback: at the moment that is virtio-net with VIRTIO_NET_F_MTU but