Re: [PATCH] virtio: Work around frames incorrectly marked as gso

2020-02-20 Thread Anton Ivanov
On 20/02/2020 07:58, Michael S. Tsirkin wrote: On Thu, Feb 13, 2020 at 04:23:24PM +, Anton Ivanov wrote: On 13/02/2020 15:53, Michael S. Tsirkin wrote: On Thu, Feb 13, 2020 at 07:44:06AM -0800, Eric Dumazet wrote: On 2/13/20 2:00 AM, Michael S. Tsirkin wrote: On Wed, Feb 12, 2020 at

Re: [PATCH] virtio: Work around frames incorrectly marked as gso

2020-02-19 Thread Michael S. Tsirkin
On Thu, Feb 13, 2020 at 04:23:24PM +, Anton Ivanov wrote: > > On 13/02/2020 15:53, Michael S. Tsirkin wrote: > > On Thu, Feb 13, 2020 at 07:44:06AM -0800, Eric Dumazet wrote: > > > > > > On 2/13/20 2:00 AM, Michael S. Tsirkin wrote: > > > > On Wed, Feb 12, 2020 at 05:38:09PM +, Anton

Re: [PATCH] virtio: Work around frames incorrectly marked as gso

2020-02-13 Thread Michael S. Tsirkin
On Thu, Feb 13, 2020 at 04:23:24PM +, Anton Ivanov wrote: > > On 13/02/2020 15:53, Michael S. Tsirkin wrote: > > On Thu, Feb 13, 2020 at 07:44:06AM -0800, Eric Dumazet wrote: > > > > > > On 2/13/20 2:00 AM, Michael S. Tsirkin wrote: > > > > On Wed, Feb 12, 2020 at 05:38:09PM +, Anton

Re: [PATCH] virtio: Work around frames incorrectly marked as gso

2020-02-13 Thread Anton Ivanov
On 13/02/2020 15:53, Michael S. Tsirkin wrote: On Thu, Feb 13, 2020 at 07:44:06AM -0800, Eric Dumazet wrote: On 2/13/20 2:00 AM, Michael S. Tsirkin wrote: On Wed, Feb 12, 2020 at 05:38:09PM +, Anton Ivanov wrote: On 11/02/2020 10:37, Michael S. Tsirkin wrote: On Tue, Feb 11, 2020 at

Re: [PATCH] virtio: Work around frames incorrectly marked as gso

2020-02-13 Thread Michael S. Tsirkin
On Thu, Feb 13, 2020 at 07:44:06AM -0800, Eric Dumazet wrote: > > > On 2/13/20 2:00 AM, Michael S. Tsirkin wrote: > > On Wed, Feb 12, 2020 at 05:38:09PM +, Anton Ivanov wrote: > >> > >> > >> On 11/02/2020 10:37, Michael S. Tsirkin wrote: > >>> On Tue, Feb 11, 2020 at 07:42:37AM +, Anton

Re: [PATCH] virtio: Work around frames incorrectly marked as gso

2020-02-13 Thread Eric Dumazet
On 2/13/20 2:00 AM, Michael S. Tsirkin wrote: > On Wed, Feb 12, 2020 at 05:38:09PM +, Anton Ivanov wrote: >> >> >> On 11/02/2020 10:37, Michael S. Tsirkin wrote: >>> On Tue, Feb 11, 2020 at 07:42:37AM +, Anton Ivanov wrote: On 11/02/2020 02:51, Jason Wang wrote: > > On

Re: [PATCH] virtio: Work around frames incorrectly marked as gso

2020-02-13 Thread Michael S. Tsirkin
On Thu, Feb 13, 2020 at 11:12:45AM +, Anton Ivanov wrote: > > > On 13/02/2020 10:00, Michael S. Tsirkin wrote: > > On Wed, Feb 12, 2020 at 05:38:09PM +, Anton Ivanov wrote: > > > > > > > > > On 11/02/2020 10:37, Michael S. Tsirkin wrote: > > > > On Tue, Feb 11, 2020 at 07:42:37AM

Re: [PATCH] virtio: Work around frames incorrectly marked as gso

2020-02-13 Thread Anton Ivanov
On 13/02/2020 10:00, Michael S. Tsirkin wrote: On Wed, Feb 12, 2020 at 05:38:09PM +, Anton Ivanov wrote: On 11/02/2020 10:37, Michael S. Tsirkin wrote: On Tue, Feb 11, 2020 at 07:42:37AM +, Anton Ivanov wrote: On 11/02/2020 02:51, Jason Wang wrote: On 2020/2/11 上午12:55, Anton

Re: [PATCH] virtio: Work around frames incorrectly marked as gso

2020-02-13 Thread Anton Ivanov
On 13/02/2020 03:31, Jason Wang wrote: On 2020/2/13 上午1:38, Anton Ivanov wrote: On 11/02/2020 10:37, Michael S. Tsirkin wrote: On Tue, Feb 11, 2020 at 07:42:37AM +, Anton Ivanov wrote: On 11/02/2020 02:51, Jason Wang wrote: On 2020/2/11 上午12:55, Anton Ivanov wrote: On 09/12/2019

Re: [PATCH] virtio: Work around frames incorrectly marked as gso

2020-02-13 Thread Michael S. Tsirkin
On Wed, Feb 12, 2020 at 05:38:09PM +, Anton Ivanov wrote: > > > On 11/02/2020 10:37, Michael S. Tsirkin wrote: > > On Tue, Feb 11, 2020 at 07:42:37AM +, Anton Ivanov wrote: > > > On 11/02/2020 02:51, Jason Wang wrote: > > > > > > > > On 2020/2/11 上午12:55, Anton Ivanov wrote: > > > > >

Re: [PATCH] virtio: Work around frames incorrectly marked as gso

2020-02-12 Thread Jason Wang
On 2020/2/13 上午1:38, Anton Ivanov wrote: On 11/02/2020 10:37, Michael S. Tsirkin wrote: On Tue, Feb 11, 2020 at 07:42:37AM +, Anton Ivanov wrote: On 11/02/2020 02:51, Jason Wang wrote: On 2020/2/11 上午12:55, Anton Ivanov wrote: On 09/12/2019 10:48, anton.iva...@cambridgegreys.com

Re: [PATCH] virtio: Work around frames incorrectly marked as gso

2020-02-12 Thread Anton Ivanov
On 11/02/2020 10:37, Michael S. Tsirkin wrote: On Tue, Feb 11, 2020 at 07:42:37AM +, Anton Ivanov wrote: On 11/02/2020 02:51, Jason Wang wrote: On 2020/2/11 上午12:55, Anton Ivanov wrote: On 09/12/2019 10:48, anton.iva...@cambridgegreys.com wrote: From: Anton Ivanov Some of the

Re: [PATCH] virtio: Work around frames incorrectly marked as gso

2020-02-12 Thread Anton Ivanov
On 12/02/2020 10:19, Michael S. Tsirkin wrote: On Wed, Feb 12, 2020 at 10:03:31AM +, Anton Ivanov wrote: On 11/02/2020 10:37, Michael S. Tsirkin wrote: On Tue, Feb 11, 2020 at 07:42:37AM +, Anton Ivanov wrote: On 11/02/2020 02:51, Jason Wang wrote: On 2020/2/11 上午12:55, Anton

Re: [PATCH] virtio: Work around frames incorrectly marked as gso

2020-02-12 Thread Michael S. Tsirkin
On Wed, Feb 12, 2020 at 10:03:31AM +, Anton Ivanov wrote: > > > On 11/02/2020 10:37, Michael S. Tsirkin wrote: > > On Tue, Feb 11, 2020 at 07:42:37AM +, Anton Ivanov wrote: > > > On 11/02/2020 02:51, Jason Wang wrote: > > > > > > > > On 2020/2/11 上午12:55, Anton Ivanov wrote: > > > > >

Re: [PATCH] virtio: Work around frames incorrectly marked as gso

2020-02-12 Thread Anton Ivanov
On 11/02/2020 10:37, Michael S. Tsirkin wrote: On Tue, Feb 11, 2020 at 07:42:37AM +, Anton Ivanov wrote: On 11/02/2020 02:51, Jason Wang wrote: On 2020/2/11 上午12:55, Anton Ivanov wrote: On 09/12/2019 10:48, anton.iva...@cambridgegreys.com wrote: From: Anton Ivanov Some of the

Re: [PATCH] virtio: Work around frames incorrectly marked as gso

2020-02-11 Thread Michael S. Tsirkin
On Tue, Feb 11, 2020 at 07:42:37AM +, Anton Ivanov wrote: > On 11/02/2020 02:51, Jason Wang wrote: > > > > On 2020/2/11 上午12:55, Anton Ivanov wrote: > > > > > > > > > On 09/12/2019 10:48, anton.iva...@cambridgegreys.com wrote: > > > > From: Anton Ivanov > > > > > > > > Some of the frames

Re: [PATCH] virtio: Work around frames incorrectly marked as gso

2020-02-10 Thread Anton Ivanov
On 11/02/2020 02:51, Jason Wang wrote: On 2020/2/11 上午12:55, Anton Ivanov wrote: On 09/12/2019 10:48, anton.iva...@cambridgegreys.com wrote: From: Anton Ivanov Some of the frames marked as GSO which arrive at virtio_net_hdr_from_skb() have no GSO_TYPE, no fragments (data_len = 0) and

Re: [PATCH] virtio: Work around frames incorrectly marked as gso

2020-02-10 Thread Jason Wang
On 2020/2/11 上午12:55, Anton Ivanov wrote: On 09/12/2019 10:48, anton.iva...@cambridgegreys.com wrote: From: Anton Ivanov Some of the frames marked as GSO which arrive at virtio_net_hdr_from_skb() have no GSO_TYPE, no fragments (data_len = 0) and length significantly shorter than the MTU

Re: [PATCH] virtio: Work around frames incorrectly marked as gso

2020-02-10 Thread Anton Ivanov
On 09/12/2019 10:48, anton.iva...@cambridgegreys.com wrote: From: Anton Ivanov Some of the frames marked as GSO which arrive at virtio_net_hdr_from_skb() have no GSO_TYPE, no fragments (data_len = 0) and length significantly shorter than the MTU (752 in my experiments). This is observed on

Re: [PATCH] virtio: Work around frames incorrectly marked as gso

2019-12-09 Thread Johannes Berg
> else if (sinfo->gso_type & SKB_GSO_TCPV6) > hdr->gso_type = VIRTIO_NET_HDR_GSO_TCPV6; > - else > - return -EINVAL; > + else { > + if (skb->data_len == 0) > +

[PATCH] virtio: Work around frames incorrectly marked as gso

2019-12-09 Thread anton . ivanov
From: Anton Ivanov Some of the frames marked as GSO which arrive at virtio_net_hdr_from_skb() have no GSO_TYPE, no fragments (data_len = 0) and length significantly shorter than the MTU (752 in my experiments). This is observed on raw sockets reading off vEth interfaces in all 4.x and 5.x