Re: [PATCH 0/6] virtio-console: spec compliance fixes

2018-05-06 Thread Michael S. Tsirkin
On Sun, May 06, 2018 at 08:24:30PM +0200, Amit Shah wrote: > On (Thu) 03 May 2018 [22:28:32], Michael S. Tsirkin wrote: > > On Thu, May 03, 2018 at 05:45:29AM +0200, Amit Shah wrote: > > > (apologies if you received a dup) > > > > > > On (Tue) 24 Apr 2018 [21:41:29], Michael S. Tsirkin wrote: > >

Re: [PATCH 0/6] virtio-console: spec compliance fixes

2018-05-06 Thread Amit Shah
On (Thu) 03 May 2018 [22:28:32], Michael S. Tsirkin wrote: > On Thu, May 03, 2018 at 05:45:29AM +0200, Amit Shah wrote: > > (apologies if you received a dup) > > > > On (Tue) 24 Apr 2018 [21:41:29], Michael S. Tsirkin wrote: > > > On Fri, Apr 20, 2018 at 09:17:59PM +0300, Michael S. Tsirkin

Re: [PATCH 0/6] virtio-console: spec compliance fixes

2018-05-03 Thread Michael S. Tsirkin
On Thu, May 03, 2018 at 05:45:29AM +0200, Amit Shah wrote: > (apologies if you received a dup) > > On (Tue) 24 Apr 2018 [21:41:29], Michael S. Tsirkin wrote: > > On Fri, Apr 20, 2018 at 09:17:59PM +0300, Michael S. Tsirkin wrote: > > > Turns out virtio console tries to take a buffer out of an

Re: [PATCH 0/6] virtio-console: spec compliance fixes

2018-05-02 Thread Amit Shah
On (Tue) 24 Apr 2018 [21:41:29], Michael S. Tsirkin wrote: > On Fri, Apr 20, 2018 at 09:17:59PM +0300, Michael S. Tsirkin wrote: > > Turns out virtio console tries to take a buffer out of an active vq. > > Works by sheer luck, and is explicitly forbidden by spec. And while > > going over it I saw

Re: [PATCH 0/6] virtio-console: spec compliance fixes

2018-04-24 Thread Michael S. Tsirkin
On Fri, Apr 20, 2018 at 09:17:59PM +0300, Michael S. Tsirkin wrote: > Turns out virtio console tries to take a buffer out of an active vq. > Works by sheer luck, and is explicitly forbidden by spec. And while > going over it I saw that error handling is also broken - > failure is easy to trigger

[PATCH 0/6] virtio-console: spec compliance fixes

2018-04-20 Thread Michael S. Tsirkin
Turns out virtio console tries to take a buffer out of an active vq. Works by sheer luck, and is explicitly forbidden by spec. And while going over it I saw that error handling is also broken - failure is easy to trigger if I force allocations to fail. Lightly tested. Michael S. Tsirkin (6):