Re: [PATCH 03/12] block: bio_release_pages: use flags arg instead of bool

2019-08-01 Thread Christoph Hellwig
On Tue, Jul 30, 2019 at 11:57:02AM -0400, Jerome Glisse wrote: > Other user can also add page that are not coming from GUP but need to > have a reference see __blkdev_direct_IO() Except for the zero page case I mentioned in my last mail explicitly, and the KVEC/PIPE type iov vecs from the

Re: [PATCH 03/12] block: bio_release_pages: use flags arg instead of bool

2019-07-30 Thread Jerome Glisse
On Tue, Jul 30, 2019 at 12:25:57PM +0200, Christoph Hellwig wrote: > On Mon, Jul 29, 2019 at 04:57:21PM -0400, Jerome Glisse wrote: > > > All pages releases by bio_release_pages should come from > > > get_get_user_pages, so I don't really see the point here. > > > > No they do not all comes from

Re: [PATCH 03/12] block: bio_release_pages: use flags arg instead of bool

2019-07-30 Thread Christoph Hellwig
On Mon, Jul 29, 2019 at 04:57:21PM -0400, Jerome Glisse wrote: > > All pages releases by bio_release_pages should come from > > get_get_user_pages, so I don't really see the point here. > > No they do not all comes from GUP for see various callers > of bio_check_pages_dirty() for instance

Re: [PATCH 03/12] block: bio_release_pages: use flags arg instead of bool

2019-07-29 Thread Jerome Glisse
On Tue, Jul 23, 2019 at 10:30:53PM -0700, Christoph Hellwig wrote: > On Tue, Jul 23, 2019 at 09:25:09PM -0700, john.hubb...@gmail.com wrote: > > From: John Hubbard > > > > In commit d241a95f3514 ("block: optionally mark pages dirty in > > bio_release_pages"), new "bool mark_dirty" argument was

[PATCH 03/12] block: bio_release_pages: use flags arg instead of bool

2019-07-24 Thread john . hubbard
From: John Hubbard In commit d241a95f3514 ("block: optionally mark pages dirty in bio_release_pages"), new "bool mark_dirty" argument was added to bio_release_pages. In upcoming work, another bool argument (to indicate that the pages came from get_user_pages) is going to be added. That's one

Re: [PATCH 03/12] block: bio_release_pages: use flags arg instead of bool

2019-07-23 Thread Christoph Hellwig
On Tue, Jul 23, 2019 at 09:25:09PM -0700, john.hubb...@gmail.com wrote: > From: John Hubbard > > In commit d241a95f3514 ("block: optionally mark pages dirty in > bio_release_pages"), new "bool mark_dirty" argument was added to > bio_release_pages. > > In upcoming work, another bool argument (to