Re: [PATCH 1/1] virtio: disable partitions scanning for no partitions block

2021-07-15 Thread Jason Wang
在 2021/7/15 下午5:47, Yury Kamenev 写道: Signed-off-by: Yury Kamenev I think we need a better commit log here. And why do we need a Kconfig for this? If there's a good reason, I guess the right approach is to invent something in the virtio core (via /sys)? Thanks ---

Re: [PATCH 1/1] virtio: disable partitions scanning for no partitions block

2021-07-15 Thread kernel test robot
Hi Yury, Thank you for the patch! Yet something to improve: [auto build test ERROR on block/for-next] [also build test ERROR on vhost/linux-next hch-configfs/for-next linus/master v5.14-rc1 next-20210715] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH 1/1] virtio: disable partitions scanning for no partitions block

2021-07-15 Thread Paolo Bonzini
On 15/07/21 11:47, Yury Kamenev wrote: +#ifdef CONFIG_VIRTIO_BLK_NO_PART_SCAN + if (unlikely(partitions_scanning_disable)) + /* disable partitions scanning if it was stated in virtio features*/ + if (virtio_has_feature(vdev, VIRTIO_BLK_F_NO_PART_SCAN)) +

Re: [PATCH 1/1] virtio: disable partitions scanning for no partitions block

2021-05-24 Thread Paolo Bonzini
On 24/05/21 21:34, Юрий Каменев wrote: Hi Is your goal to avoid accidentally detecting partitions because it's confusing when that happens? The main goal is reducing the kernel start time. It might be use useful in tiny systems that use, for example, squashfs images with certainly no

Re: [PATCH 1/1] virtio: disable partitions scanning for no partitions block

2021-05-24 Thread Ulf Hansson
On Mon, 24 May 2021 at 16:57, Christoph Hellwig wrote: > > On Mon, May 24, 2021 at 03:29:22PM +0100, Stefan Hajnoczi wrote: > > GENHD_FL_NO_PART_SCAN is not used much in other drivers. This makes me > > wonder if the same use case is addressed through other means with SCSI, > > NVMe, etc devices.

Re: [PATCH 1/1] virtio: disable partitions scanning for no partitions block

2021-05-24 Thread Christoph Hellwig
On Mon, May 24, 2021 at 03:29:22PM +0100, Stefan Hajnoczi wrote: > GENHD_FL_NO_PART_SCAN is not used much in other drivers. This makes me > wonder if the same use case is addressed through other means with SCSI, > NVMe, etc devices. Maybe Christoph or Jens can weigh in on whether > adding a bit to

Re: [PATCH 1/1] virtio: disable partitions scanning for no partitions block

2021-05-24 Thread Stefan Hajnoczi
On Thu, May 20, 2021 at 04:39:08PM +0300, Yury Kamenev wrote: Hi, Is there a VIRTIO spec change for the new VIRTIO_BLK_F_NO_PS feature bit? Please send one: https://www.oasis-open.org/committees/tc_home.php?wg_abbrev=virtio#feedback GENHD_FL_NO_PART_SCAN is not used much in other drivers. This