Re: [PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.

2015-01-28 Thread Hannes Frederic Sowa
On Mi, 2015-01-28 at 18:48 +0200, Michael S. Tsirkin wrote: > On Wed, Jan 28, 2015 at 05:15:49PM +0100, Hannes Frederic Sowa wrote: > > Hi, > > > > On Mi, 2015-01-28 at 18:00 +0200, Michael S. Tsirkin wrote: > > > On Wed, Jan 28, 2015 at 11:34:02AM +0100, Hannes Frederic Sowa wrote: > > > > Hi, >

Re: [PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.

2015-01-28 Thread Michael S. Tsirkin
On Wed, Jan 28, 2015 at 05:15:49PM +0100, Hannes Frederic Sowa wrote: > Hi, > > On Mi, 2015-01-28 at 18:00 +0200, Michael S. Tsirkin wrote: > > On Wed, Jan 28, 2015 at 11:34:02AM +0100, Hannes Frederic Sowa wrote: > > > Hi, > > > > > > On Mi, 2015-01-28 at 11:46 +0200, Michael S. Tsirkin wrote: >

Re: [PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.

2015-01-28 Thread Ben Hutchings
On Wed, 2015-01-28 at 11:46 +0200, Michael S. Tsirkin wrote: > On Wed, Jan 28, 2015 at 09:25:08AM +0100, Hannes Frederic Sowa wrote: [...] > > I see fragmentation id generation still as security critical: > > When Eric patched the frag id generator in 04ca6973f7c1a0d ("ip: make IP > > identifiers l

Re: [PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.

2015-01-28 Thread Hannes Frederic Sowa
Hi, On Mi, 2015-01-28 at 18:00 +0200, Michael S. Tsirkin wrote: > On Wed, Jan 28, 2015 at 11:34:02AM +0100, Hannes Frederic Sowa wrote: > > Hi, > > > > On Mi, 2015-01-28 at 11:46 +0200, Michael S. Tsirkin wrote: > > > On Wed, Jan 28, 2015 at 09:25:08AM +0100, Hannes Frederic Sowa wrote: > > > > H

Re: [PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.

2015-01-28 Thread Michael S. Tsirkin
On Wed, Jan 28, 2015 at 11:34:02AM +0100, Hannes Frederic Sowa wrote: > Hi, > > On Mi, 2015-01-28 at 11:46 +0200, Michael S. Tsirkin wrote: > > On Wed, Jan 28, 2015 at 09:25:08AM +0100, Hannes Frederic Sowa wrote: > > > Hello, > > > > > > On Di, 2015-01-27 at 18:08 +0200, Michael S. Tsirkin wrote

Re: [PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.

2015-01-28 Thread Michael S. Tsirkin
On Wed, Jan 28, 2015 at 10:27:47AM -0500, Vlad Yasevich wrote: > On 01/28/2015 09:45 AM, Hannes Frederic Sowa wrote: > > Hi, > > > > On Mi, 2015-01-28 at 09:16 -0500, Vlad Yasevich wrote: > >> On 01/28/2015 05:34 AM, Hannes Frederic Sowa wrote: > >>> Hi, > >>> > >>> On Mi, 2015-01-28 at 11:46 +020

Re: [PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.

2015-01-28 Thread Vlad Yasevich
On 01/28/2015 09:45 AM, Hannes Frederic Sowa wrote: > Hi, > > On Mi, 2015-01-28 at 09:16 -0500, Vlad Yasevich wrote: >> On 01/28/2015 05:34 AM, Hannes Frederic Sowa wrote: >>> Hi, >>> >>> On Mi, 2015-01-28 at 11:46 +0200, Michael S. Tsirkin wrote: On Wed, Jan 28, 2015 at 09:25:08AM +0100, Han

Re: [PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.

2015-01-28 Thread Hannes Frederic Sowa
Hi, On Mi, 2015-01-28 at 09:16 -0500, Vlad Yasevich wrote: > On 01/28/2015 05:34 AM, Hannes Frederic Sowa wrote: > > Hi, > > > > On Mi, 2015-01-28 at 11:46 +0200, Michael S. Tsirkin wrote: > >> On Wed, Jan 28, 2015 at 09:25:08AM +0100, Hannes Frederic Sowa wrote: > >>> Hello, > >>> > >>> On Di, 2

Re: [PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.

2015-01-28 Thread Hannes Frederic Sowa
On Mi, 2015-01-28 at 15:43 +0200, Michael S. Tsirkin wrote: > On Wed, Jan 28, 2015 at 11:34:02AM +0100, Hannes Frederic Sowa wrote: > > Hi, > > > > On Mi, 2015-01-28 at 11:46 +0200, Michael S. Tsirkin wrote: > > > On Wed, Jan 28, 2015 at 09:25:08AM +0100, Hannes Frederic Sowa wrote: > > > > Hello,

Re: [PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.

2015-01-28 Thread Vlad Yasevich
On 01/28/2015 05:34 AM, Hannes Frederic Sowa wrote: > Hi, > > On Mi, 2015-01-28 at 11:46 +0200, Michael S. Tsirkin wrote: >> On Wed, Jan 28, 2015 at 09:25:08AM +0100, Hannes Frederic Sowa wrote: >>> Hello, >>> >>> On Di, 2015-01-27 at 18:08 +0200, Michael S. Tsirkin wrote: On Tue, Jan 27, 201

Re: [PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.

2015-01-28 Thread Michael S. Tsirkin
On Wed, Jan 28, 2015 at 11:34:02AM +0100, Hannes Frederic Sowa wrote: > Hi, > > On Mi, 2015-01-28 at 11:46 +0200, Michael S. Tsirkin wrote: > > On Wed, Jan 28, 2015 at 09:25:08AM +0100, Hannes Frederic Sowa wrote: > > > Hello, > > > > > > On Di, 2015-01-27 at 18:08 +0200, Michael S. Tsirkin wrote

Re: [PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.

2015-01-28 Thread Hannes Frederic Sowa
On Mi, 2015-01-28 at 11:34 +0100, Hannes Frederic Sowa wrote: > > > And now it's even easier - just patch the hypervisor, and all VMs > > automatically benefit. > > Sometimes the hypervisor is not under my control. You would need to > patch both kernels in your case - non gso frames would still g

Re: [PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.

2015-01-28 Thread Hannes Frederic Sowa
Hi, On Mi, 2015-01-28 at 11:46 +0200, Michael S. Tsirkin wrote: > On Wed, Jan 28, 2015 at 09:25:08AM +0100, Hannes Frederic Sowa wrote: > > Hello, > > > > On Di, 2015-01-27 at 18:08 +0200, Michael S. Tsirkin wrote: > > > On Tue, Jan 27, 2015 at 05:02:31PM +0100, Hannes Frederic Sowa wrote: > > >

Re: [PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.

2015-01-28 Thread Michael S. Tsirkin
On Wed, Jan 28, 2015 at 09:25:08AM +0100, Hannes Frederic Sowa wrote: > Hello, > > On Di, 2015-01-27 at 18:08 +0200, Michael S. Tsirkin wrote: > > On Tue, Jan 27, 2015 at 05:02:31PM +0100, Hannes Frederic Sowa wrote: > > > On Di, 2015-01-27 at 09:26 -0500, Vlad Yasevich wrote: > > > > On 01/27/201

Re: [PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.

2015-01-28 Thread Hannes Frederic Sowa
Hello, On Di, 2015-01-27 at 18:08 +0200, Michael S. Tsirkin wrote: > On Tue, Jan 27, 2015 at 05:02:31PM +0100, Hannes Frederic Sowa wrote: > > On Di, 2015-01-27 at 09:26 -0500, Vlad Yasevich wrote: > > > On 01/27/2015 08:47 AM, Hannes Frederic Sowa wrote: > > > > On Di, 2015-01-27 at 10:42 +0200,

Re: [PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.

2015-01-27 Thread Vlad Yasevich
On 01/27/2015 11:02 AM, Hannes Frederic Sowa wrote: > On Di, 2015-01-27 at 09:26 -0500, Vlad Yasevich wrote: >> On 01/27/2015 08:47 AM, Hannes Frederic Sowa wrote: >>> On Di, 2015-01-27 at 10:42 +0200, Michael S. Tsirkin wrote: On Tue, Jan 27, 2015 at 02:47:54AM +, Ben Hutchings wrote: >>>

Re: [PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.

2015-01-27 Thread Michael S. Tsirkin
On Tue, Jan 27, 2015 at 05:02:31PM +0100, Hannes Frederic Sowa wrote: > On Di, 2015-01-27 at 09:26 -0500, Vlad Yasevich wrote: > > On 01/27/2015 08:47 AM, Hannes Frederic Sowa wrote: > > > On Di, 2015-01-27 at 10:42 +0200, Michael S. Tsirkin wrote: > > >> On Tue, Jan 27, 2015 at 02:47:54AM +, B

Re: [PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.

2015-01-27 Thread Hannes Frederic Sowa
On Di, 2015-01-27 at 09:26 -0500, Vlad Yasevich wrote: > On 01/27/2015 08:47 AM, Hannes Frederic Sowa wrote: > > On Di, 2015-01-27 at 10:42 +0200, Michael S. Tsirkin wrote: > >> On Tue, Jan 27, 2015 at 02:47:54AM +, Ben Hutchings wrote: > >>> On Mon, 2015-01-26 at 09:37 -0500, Vladislav Yasevic

Re: [PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.

2015-01-27 Thread Eric Dumazet
On Tue, 2015-01-27 at 09:26 -0500, Vlad Yasevich wrote: > That's what I originally wanted to do, but had to move and grow txflags thus > skb_shinfo ended up growing. I wanted to avoid that, so stole an skb flag. > > I considered treating fragid == 0 as unset, but a 0 fragid is perfectly valid >

Re: [PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.

2015-01-27 Thread Vlad Yasevich
On 01/27/2015 08:47 AM, Hannes Frederic Sowa wrote: > On Di, 2015-01-27 at 10:42 +0200, Michael S. Tsirkin wrote: >> On Tue, Jan 27, 2015 at 02:47:54AM +, Ben Hutchings wrote: >>> On Mon, 2015-01-26 at 09:37 -0500, Vladislav Yasevich wrote: If the IPv6 fragment id has not been set and we p

Re: [PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.

2015-01-27 Thread Hannes Frederic Sowa
On Di, 2015-01-27 at 10:42 +0200, Michael S. Tsirkin wrote: > On Tue, Jan 27, 2015 at 02:47:54AM +, Ben Hutchings wrote: > > On Mon, 2015-01-26 at 09:37 -0500, Vladislav Yasevich wrote: > > > If the IPv6 fragment id has not been set and we perform > > > fragmentation due to UFO, select a new fr

Re: [PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.

2015-01-27 Thread Michael S. Tsirkin
On Tue, Jan 27, 2015 at 02:47:54AM +, Ben Hutchings wrote: > On Mon, 2015-01-26 at 09:37 -0500, Vladislav Yasevich wrote: > > If the IPv6 fragment id has not been set and we perform > > fragmentation due to UFO, select a new fragment id. > > When we store the fragment id into skb_shinfo, set th

Re: [PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.

2015-01-27 Thread David Miller
From: Ben Hutchings Date: Tue, 27 Jan 2015 02:47:54 + > On Mon, 2015-01-26 at 09:37 -0500, Vladislav Yasevich wrote: >> If the IPv6 fragment id has not been set and we perform >> fragmentation due to UFO, select a new fragment id. >> When we store the fragment id into skb_shinfo, set the bit

Re: [PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.

2015-01-26 Thread Ben Hutchings
On Mon, 2015-01-26 at 09:37 -0500, Vladislav Yasevich wrote: > If the IPv6 fragment id has not been set and we perform > fragmentation due to UFO, select a new fragment id. > When we store the fragment id into skb_shinfo, set the bit > in the skb so we can re-use the selected id. > This preserves t

[PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.

2015-01-26 Thread Vladislav Yasevich
If the IPv6 fragment id has not been set and we perform fragmentation due to UFO, select a new fragment id. When we store the fragment id into skb_shinfo, set the bit in the skb so we can re-use the selected id. This preserves the behavior of UFO packets generated on the host and solves the issue o