Re: [PATCH 2/2] vhost: handle polling failure

2012-12-27 Thread Wanlong Gao
On 12/27/2012 02:39 PM, Jason Wang wrote: Currently, polling error were ignored in vhost. This may lead some issues (e.g kenrel crash when passing a tap fd to vhost before calling TUNSETIFF). Fix this by: Can this kernel crash be reproduced by hand? Thanks, Wanlong Gao - extend the idea

Re: [PATCH 2/2] vhost: handle polling failure

2012-12-27 Thread Jason Wang
On 12/27/2012 06:01 PM, Wanlong Gao wrote: On 12/27/2012 02:39 PM, Jason Wang wrote: Currently, polling error were ignored in vhost. This may lead some issues (e.g kenrel crash when passing a tap fd to vhost before calling TUNSETIFF). Fix this by: Can this kernel crash be reproduced

[PATCH 2/2] vhost: handle polling failure

2012-12-26 Thread Jason Wang
Currently, polling error were ignored in vhost. This may lead some issues (e.g kenrel crash when passing a tap fd to vhost before calling TUNSETIFF). Fix this by: - extend the idea of vhost_net_poll_state to all vhost_polls - change the state only when polling is succeed - make vhost_poll_start()