Re: [PATCH 3/4] virtio_ring: introduce a per virtqueue waitqueue

2023-01-30 Thread Michael S. Tsirkin
On Tue, Jan 31, 2023 at 11:24:52AM +0800, Jason Wang wrote: > On Mon, Jan 30, 2023 at 7:18 PM Michael S. Tsirkin wrote: > > > > On Mon, Jan 30, 2023 at 03:44:24PM +0800, Jason Wang wrote: > > > On Mon, Jan 30, 2023 at 1:43 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Mon, Jan 30, 2023

Re: [PATCH 3/4] virtio_ring: introduce a per virtqueue waitqueue

2023-01-30 Thread Jason Wang
On Mon, Jan 30, 2023 at 7:18 PM Michael S. Tsirkin wrote: > > On Mon, Jan 30, 2023 at 03:44:24PM +0800, Jason Wang wrote: > > On Mon, Jan 30, 2023 at 1:43 PM Michael S. Tsirkin wrote: > > > > > > On Mon, Jan 30, 2023 at 10:53:54AM +0800, Jason Wang wrote: > > > > On Sun, Jan 29, 2023 at 3:30 PM

Re: [PATCH 3/4] virtio_ring: introduce a per virtqueue waitqueue

2023-01-30 Thread Michael S. Tsirkin
On Mon, Jan 30, 2023 at 03:44:24PM +0800, Jason Wang wrote: > On Mon, Jan 30, 2023 at 1:43 PM Michael S. Tsirkin wrote: > > > > On Mon, Jan 30, 2023 at 10:53:54AM +0800, Jason Wang wrote: > > > On Sun, Jan 29, 2023 at 3:30 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Sun, Jan 29, 2023

Re: [PATCH 3/4] virtio_ring: introduce a per virtqueue waitqueue

2023-01-29 Thread Jason Wang
On Mon, Jan 30, 2023 at 1:43 PM Michael S. Tsirkin wrote: > > On Mon, Jan 30, 2023 at 10:53:54AM +0800, Jason Wang wrote: > > On Sun, Jan 29, 2023 at 3:30 PM Michael S. Tsirkin wrote: > > > > > > On Sun, Jan 29, 2023 at 01:48:49PM +0800, Jason Wang wrote: > > > > On Fri, Jan 27, 2023 at 6:35 PM

Re: [PATCH 3/4] virtio_ring: introduce a per virtqueue waitqueue

2023-01-29 Thread Michael S. Tsirkin
On Mon, Jan 30, 2023 at 10:53:54AM +0800, Jason Wang wrote: > On Sun, Jan 29, 2023 at 3:30 PM Michael S. Tsirkin wrote: > > > > On Sun, Jan 29, 2023 at 01:48:49PM +0800, Jason Wang wrote: > > > On Fri, Jan 27, 2023 at 6:35 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Fri, Dec 30, 2022

Re: [PATCH 3/4] virtio_ring: introduce a per virtqueue waitqueue

2023-01-29 Thread Jason Wang
On Sun, Jan 29, 2023 at 3:30 PM Michael S. Tsirkin wrote: > > On Sun, Jan 29, 2023 at 01:48:49PM +0800, Jason Wang wrote: > > On Fri, Jan 27, 2023 at 6:35 PM Michael S. Tsirkin wrote: > > > > > > On Fri, Dec 30, 2022 at 11:43:08AM +0800, Jason Wang wrote: > > > > On Thu, Dec 29, 2022 at 4:10 PM

Re: [PATCH 3/4] virtio_ring: introduce a per virtqueue waitqueue

2023-01-28 Thread Michael S. Tsirkin
On Sun, Jan 29, 2023 at 01:48:49PM +0800, Jason Wang wrote: > On Fri, Jan 27, 2023 at 6:35 PM Michael S. Tsirkin wrote: > > > > On Fri, Dec 30, 2022 at 11:43:08AM +0800, Jason Wang wrote: > > > On Thu, Dec 29, 2022 at 4:10 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Thu, Dec 29, 2022

Re: [PATCH 3/4] virtio_ring: introduce a per virtqueue waitqueue

2023-01-28 Thread Jason Wang
On Fri, Jan 27, 2023 at 6:35 PM Michael S. Tsirkin wrote: > > On Fri, Dec 30, 2022 at 11:43:08AM +0800, Jason Wang wrote: > > On Thu, Dec 29, 2022 at 4:10 PM Michael S. Tsirkin wrote: > > > > > > On Thu, Dec 29, 2022 at 04:04:13PM +0800, Jason Wang wrote: > > > > On Thu, Dec 29, 2022 at 3:07 PM

Re: [PATCH 3/4] virtio_ring: introduce a per virtqueue waitqueue

2023-01-27 Thread Michael S. Tsirkin
On Fri, Dec 30, 2022 at 11:43:08AM +0800, Jason Wang wrote: > On Thu, Dec 29, 2022 at 4:10 PM Michael S. Tsirkin wrote: > > > > On Thu, Dec 29, 2022 at 04:04:13PM +0800, Jason Wang wrote: > > > On Thu, Dec 29, 2022 at 3:07 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Wed, Dec 28, 2022

Re: [PATCH 3/4] virtio_ring: introduce a per virtqueue waitqueue

2022-12-29 Thread Jason Wang
On Thu, Dec 29, 2022 at 4:10 PM Michael S. Tsirkin wrote: > > On Thu, Dec 29, 2022 at 04:04:13PM +0800, Jason Wang wrote: > > On Thu, Dec 29, 2022 at 3:07 PM Michael S. Tsirkin wrote: > > > > > > On Wed, Dec 28, 2022 at 07:53:08PM +0800, Jason Wang wrote: > > > > On Wed, Dec 28, 2022 at 2:34 PM

Re: [PATCH 3/4] virtio_ring: introduce a per virtqueue waitqueue

2022-12-29 Thread Michael S. Tsirkin
On Thu, Dec 29, 2022 at 04:04:13PM +0800, Jason Wang wrote: > On Thu, Dec 29, 2022 at 3:07 PM Michael S. Tsirkin wrote: > > > > On Wed, Dec 28, 2022 at 07:53:08PM +0800, Jason Wang wrote: > > > On Wed, Dec 28, 2022 at 2:34 PM Jason Wang wrote: > > > > > > > > > > > > 在 2022/12/27 17:38, Michael

Re: [PATCH 3/4] virtio_ring: introduce a per virtqueue waitqueue

2022-12-29 Thread Jason Wang
On Thu, Dec 29, 2022 at 3:07 PM Michael S. Tsirkin wrote: > > On Wed, Dec 28, 2022 at 07:53:08PM +0800, Jason Wang wrote: > > On Wed, Dec 28, 2022 at 2:34 PM Jason Wang wrote: > > > > > > > > > 在 2022/12/27 17:38, Michael S. Tsirkin 写道: > > > > On Tue, Dec 27, 2022 at 05:12:58PM +0800, Jason

Re: [PATCH 3/4] virtio_ring: introduce a per virtqueue waitqueue

2022-12-28 Thread Michael S. Tsirkin
On Wed, Dec 28, 2022 at 07:53:08PM +0800, Jason Wang wrote: > On Wed, Dec 28, 2022 at 2:34 PM Jason Wang wrote: > > > > > > 在 2022/12/27 17:38, Michael S. Tsirkin 写道: > > > On Tue, Dec 27, 2022 at 05:12:58PM +0800, Jason Wang wrote: > > >> 在 2022/12/27 15:33, Michael S. Tsirkin 写道: > > >>> On

Re: [PATCH 3/4] virtio_ring: introduce a per virtqueue waitqueue

2022-12-28 Thread Jason Wang
On Wed, Dec 28, 2022 at 2:34 PM Jason Wang wrote: > > > 在 2022/12/27 17:38, Michael S. Tsirkin 写道: > > On Tue, Dec 27, 2022 at 05:12:58PM +0800, Jason Wang wrote: > >> 在 2022/12/27 15:33, Michael S. Tsirkin 写道: > >>> On Tue, Dec 27, 2022 at 12:30:35PM +0800, Jason Wang wrote: > > But device

Re: [PATCH 3/4] virtio_ring: introduce a per virtqueue waitqueue

2022-12-27 Thread Jason Wang
在 2022/12/27 17:38, Michael S. Tsirkin 写道: On Tue, Dec 27, 2022 at 05:12:58PM +0800, Jason Wang wrote: 在 2022/12/27 15:33, Michael S. Tsirkin 写道: On Tue, Dec 27, 2022 at 12:30:35PM +0800, Jason Wang wrote: But device is still going and will later use the buffers. Same for timeout really.

Re: [PATCH 3/4] virtio_ring: introduce a per virtqueue waitqueue

2022-12-27 Thread Michael S. Tsirkin
On Tue, Dec 27, 2022 at 05:12:58PM +0800, Jason Wang wrote: > > 在 2022/12/27 15:33, Michael S. Tsirkin 写道: > > On Tue, Dec 27, 2022 at 12:30:35PM +0800, Jason Wang wrote: > > > > But device is still going and will later use the buffers. > > > > > > > > Same for timeout really. > > > Avoiding

Re: [PATCH 3/4] virtio_ring: introduce a per virtqueue waitqueue

2022-12-27 Thread Jason Wang
在 2022/12/27 15:33, Michael S. Tsirkin 写道: On Tue, Dec 27, 2022 at 12:30:35PM +0800, Jason Wang wrote: But device is still going and will later use the buffers. Same for timeout really. Avoiding infinite wait/poll is one of the goals, another is to sleep. If we think the timeout is hard, we

Re: [PATCH 3/4] virtio_ring: introduce a per virtqueue waitqueue

2022-12-27 Thread Jason Wang
在 2022/12/27 15:19, Michael S. Tsirkin 写道: On Tue, Dec 27, 2022 at 11:47:34AM +0800, Jason Wang wrote: On Tue, Dec 27, 2022 at 7:34 AM Michael S. Tsirkin wrote: On Mon, Dec 26, 2022 at 03:49:07PM +0800, Jason Wang wrote: This patch introduces a per virtqueue waitqueue to allow driver to

Re: [PATCH 3/4] virtio_ring: introduce a per virtqueue waitqueue

2022-12-26 Thread Michael S. Tsirkin
On Tue, Dec 27, 2022 at 12:30:35PM +0800, Jason Wang wrote: > > But device is still going and will later use the buffers. > > > > Same for timeout really. > > Avoiding infinite wait/poll is one of the goals, another is to sleep. > If we think the timeout is hard, we can start from the wait. > >

Re: [PATCH 3/4] virtio_ring: introduce a per virtqueue waitqueue

2022-12-26 Thread Michael S. Tsirkin
On Tue, Dec 27, 2022 at 11:47:34AM +0800, Jason Wang wrote: > On Tue, Dec 27, 2022 at 7:34 AM Michael S. Tsirkin wrote: > > > > On Mon, Dec 26, 2022 at 03:49:07PM +0800, Jason Wang wrote: > > > This patch introduces a per virtqueue waitqueue to allow driver to > > > sleep and wait for more used.

Re: [PATCH 3/4] virtio_ring: introduce a per virtqueue waitqueue

2022-12-26 Thread Jason Wang
On Tue, Dec 27, 2022 at 7:38 AM Michael S. Tsirkin wrote: > > On Mon, Dec 26, 2022 at 03:49:07PM +0800, Jason Wang wrote: > > This patch introduces a per virtqueue waitqueue to allow driver to > > sleep and wait for more used. Two new helpers are introduced to allow > > driver to sleep and wake

Re: [PATCH 3/4] virtio_ring: introduce a per virtqueue waitqueue

2022-12-26 Thread Jason Wang
On Tue, Dec 27, 2022 at 7:34 AM Michael S. Tsirkin wrote: > > On Mon, Dec 26, 2022 at 03:49:07PM +0800, Jason Wang wrote: > > This patch introduces a per virtqueue waitqueue to allow driver to > > sleep and wait for more used. Two new helpers are introduced to allow > > driver to sleep and wake

Re: [PATCH 3/4] virtio_ring: introduce a per virtqueue waitqueue

2022-12-26 Thread Michael S. Tsirkin
On Mon, Dec 26, 2022 at 03:49:07PM +0800, Jason Wang wrote: > This patch introduces a per virtqueue waitqueue to allow driver to > sleep and wait for more used. Two new helpers are introduced to allow > driver to sleep and wake up. > > Signed-off-by: Jason Wang > --- > Changes since V1: > -

Re: [PATCH 3/4] virtio_ring: introduce a per virtqueue waitqueue

2022-12-26 Thread Michael S. Tsirkin
On Mon, Dec 26, 2022 at 03:49:07PM +0800, Jason Wang wrote: > This patch introduces a per virtqueue waitqueue to allow driver to > sleep and wait for more used. Two new helpers are introduced to allow > driver to sleep and wake up. > > Signed-off-by: Jason Wang > --- > Changes since V1: > -

[PATCH 3/4] virtio_ring: introduce a per virtqueue waitqueue

2022-12-25 Thread Jason Wang
This patch introduces a per virtqueue waitqueue to allow driver to sleep and wait for more used. Two new helpers are introduced to allow driver to sleep and wake up. Signed-off-by: Jason Wang --- Changes since V1: - check virtqueue_is_broken() as well - use more_used() instead of

[RFC PATCH 3/4] virtio_ring: introduce a per virtqueue waitqueue

2022-12-21 Thread Jason Wang
This patch introduces a per virtqueue waitqueue to allow driver to sleep and wait for more used. Two new helpers are introduced to allow driver to sleep and wake up. Signed-off-by: Jason Wang --- drivers/virtio/virtio_ring.c | 31 +++ include/linux/virtio.h |