Re: [PATCH 4/5] iommu: Regulate errno in ->attach_dev callback functions

2022-09-14 Thread Robin Murphy
On 2022-09-14 18:58, Nicolin Chen wrote: On Wed, Sep 14, 2022 at 10:49:42AM +0100, Jean-Philippe Brucker wrote: External email: Use caution opening links or attachments On Wed, Sep 14, 2022 at 06:11:06AM -0300, Jason Gunthorpe wrote: On Tue, Sep 13, 2022 at 01:27:03PM +0100, Jean-Philippe Bru

Re: [PATCH 4/5] iommu: Regulate errno in ->attach_dev callback functions

2022-09-14 Thread Jean-Philippe Brucker
On Wed, Sep 14, 2022 at 06:11:06AM -0300, Jason Gunthorpe wrote: > On Tue, Sep 13, 2022 at 01:27:03PM +0100, Jean-Philippe Brucker wrote: > > I think in the future it will be too easy to forget about the constrained > > return value of attach() while modifying some other part of the driver, > > and

Re: [PATCH 4/5] iommu: Regulate errno in ->attach_dev callback functions

2022-09-13 Thread Jean-Philippe Brucker
Hi Nicolin, On Tue, Sep 13, 2022 at 01:24:47AM -0700, Nicolin Chen wrote: > Following the new rules in include/linux/iommu.h kdocs, update all drivers > ->attach_dev callback functions to return ENODEV error code for all device > specific errors. It particularly excludes EINVAL from being used for