[PATCH 5/5] hw_random: don't init list element we're about to add to list.

[Rusty Russell]

Another interesting anti-pattern.

Signed-off-by: Rusty Russell <ru...@rustcorp.com.au>
---
 drivers/char/hw_random/core.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c
index 6a34feca6b43..96fa06716e95 100644
--- a/drivers/char/hw_random/core.c
+++ b/drivers/char/hw_random/core.c
@@ -485,7 +485,6 @@ int hwrng_register(struct hwrng *rng)
                        goto out_unlock;
                }
        }
-       INIT_LIST_HEAD(&rng->list);
        list_add_tail(&rng->list, &rng_list);
 
        if (old_rng && !rng->init) {
-- 
1.9.1

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization