Re: [PATCH 7/8] drm/virtio: move virtio_gpu_object_{attach, detach} calls.

2018-10-18 Thread Dave Airlie
On Thu, 18 Oct 2018 at 17:00, Gerd Hoffmann wrote: > > > > > This to me feels more like a bind/unbind operation rather than a > > > > populate/unpopulate operation, > > > > > > > > bind is " Bind the backend pages into the aperture in the location" > > > > > > > > whereas populate is > > > > > >

Re: [PATCH 7/8] drm/virtio: move virtio_gpu_object_{attach, detach} calls.

2018-10-18 Thread Gerd Hoffmann
> > > This to me feels more like a bind/unbind operation rather than a > > > populate/unpopulate operation, > > > > > > bind is " Bind the backend pages into the aperture in the location" > > > > > > whereas populate is > > > > > > allocate pages for a ttm. > > > > I ran into that trap too ;) > >

Re: [PATCH 7/8] drm/virtio: move virtio_gpu_object_{attach, detach} calls.

2018-10-18 Thread Dave Airlie
On Thu, 18 Oct 2018 at 16:11, Gerd Hoffmann wrote: > > On Thu, Oct 18, 2018 at 11:41:52AM +1000, Dave Airlie wrote: > > On Mon, 1 Oct 2018 at 20:33, Gerd Hoffmann wrote: > > > > > > Remove the virtio_gpu_object_{attach,detach} calls from move_notify() > > > callback. Add them to the

Re: [PATCH 7/8] drm/virtio: move virtio_gpu_object_{attach, detach} calls.

2018-10-18 Thread Gerd Hoffmann
On Thu, Oct 18, 2018 at 11:41:52AM +1000, Dave Airlie wrote: > On Mon, 1 Oct 2018 at 20:33, Gerd Hoffmann wrote: > > > > Remove the virtio_gpu_object_{attach,detach} calls from move_notify() > > callback. Add them to the ttm_tt_{populate,unpopulate} callbacks, which > > is the correct place to

Re: [PATCH 7/8] drm/virtio: move virtio_gpu_object_{attach, detach} calls.

2018-10-17 Thread Dave Airlie
On Mon, 1 Oct 2018 at 20:33, Gerd Hoffmann wrote: > > Remove the virtio_gpu_object_{attach,detach} calls from move_notify() > callback. Add them to the ttm_tt_{populate,unpopulate} callbacks, which > is the correct place to handle this. > > The new ttm_tt_{populate,unpopulate} callbacks call the