Re: [PATCH RFC 3/4] vsock/virtio: change the maximum packet size allowed

2019-04-19 Thread Stefano Garzarella
On Mon, Apr 08, 2019 at 10:57:44AM -0400, Michael S. Tsirkin wrote: > On Mon, Apr 08, 2019 at 04:55:31PM +0200, Stefano Garzarella wrote: > > > Anyway, any change to this behavior requires compatibility so new guest > > > drivers work with old vhost_vsock.ko. Therefore we should probably just > >

Re: [PATCH RFC 3/4] vsock/virtio: change the maximum packet size allowed

2019-04-19 Thread Stefano Garzarella
On Fri, Apr 05, 2019 at 09:24:47AM +0100, Stefan Hajnoczi wrote: > On Thu, Apr 04, 2019 at 12:58:37PM +0200, Stefano Garzarella wrote: > > Since now we are able to split packets, we can avoid limiting > > their sizes to VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE. > > Instead, we can use

Re: [PATCH RFC 3/4] vsock/virtio: change the maximum packet size allowed

2019-04-19 Thread Stefano Garzarella
On Mon, Apr 08, 2019 at 10:37:23AM +0100, Stefan Hajnoczi wrote: > On Fri, Apr 05, 2019 at 12:07:47PM +0200, Stefano Garzarella wrote: > > On Fri, Apr 05, 2019 at 09:24:47AM +0100, Stefan Hajnoczi wrote: > > > On Thu, Apr 04, 2019 at 12:58:37PM +0200, Stefano Garzarella wrote: > > > > Since now we

[PATCH RFC 3/4] vsock/virtio: change the maximum packet size allowed

2019-04-19 Thread Stefano Garzarella
Since now we are able to split packets, we can avoid limiting their sizes to VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE. Instead, we can use VIRTIO_VSOCK_MAX_PKT_BUF_SIZE as the max packet size. Signed-off-by: Stefano Garzarella --- net/vmw_vsock/virtio_transport_common.c | 4 ++-- 1 file changed, 2

Re: [PATCH RFC 3/4] vsock/virtio: change the maximum packet size allowed

2019-04-08 Thread Stefan Hajnoczi
On Mon, Apr 08, 2019 at 05:17:35PM +0200, Stefano Garzarella wrote: > On Mon, Apr 08, 2019 at 10:57:44AM -0400, Michael S. Tsirkin wrote: > > On Mon, Apr 08, 2019 at 04:55:31PM +0200, Stefano Garzarella wrote: > > > > Anyway, any change to this behavior requires compatibility so new guest > > > >

Re: [PATCH RFC 3/4] vsock/virtio: change the maximum packet size allowed

2019-04-08 Thread Michael S. Tsirkin
On Mon, Apr 08, 2019 at 04:55:31PM +0200, Stefano Garzarella wrote: > > Anyway, any change to this behavior requires compatibility so new guest > > drivers work with old vhost_vsock.ko. Therefore we should probably just > > leave the limit for now. > > I understood your point of view and I

Re: [PATCH RFC 3/4] vsock/virtio: change the maximum packet size allowed

2019-04-08 Thread Stefan Hajnoczi
On Fri, Apr 05, 2019 at 12:07:47PM +0200, Stefano Garzarella wrote: > On Fri, Apr 05, 2019 at 09:24:47AM +0100, Stefan Hajnoczi wrote: > > On Thu, Apr 04, 2019 at 12:58:37PM +0200, Stefano Garzarella wrote: > > > Since now we are able to split packets, we can avoid limiting > > > their sizes to

Re: [PATCH RFC 3/4] vsock/virtio: change the maximum packet size allowed

2019-04-05 Thread Stefan Hajnoczi
On Thu, Apr 04, 2019 at 12:58:37PM +0200, Stefano Garzarella wrote: > Since now we are able to split packets, we can avoid limiting > their sizes to VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE. > Instead, we can use VIRTIO_VSOCK_MAX_PKT_BUF_SIZE as the max > packet size. > > Signed-off-by: Stefano