Re: [PATCH RFC 4/5] tun: vringfd xmit support.

2008-04-07 Thread Rusty Russell
On Monday 07 April 2008 15:13:44 Herbert Xu wrote: Rusty Russell [EMAIL PROTECTED] wrote: +/* We are done with this skb: put it in the used pile. */ +static void skb_finished(struct skb_shared_info *sinfo) +{ + struct skb_shinfo_tun *sht = (void *)(sinfo + 1); + + /*

Re: [PATCH RFC 4/5] tun: vringfd xmit support.

2008-04-07 Thread David Miller
From: Rusty Russell [EMAIL PROTECTED] Date: Mon, 7 Apr 2008 17:24:51 +1000 On Monday 07 April 2008 15:13:44 Herbert Xu wrote: On second thought, this is not going to work. The network stack can clone individual pages out of this skb and put it into a new skb. Therefore whatever scheme we

Re: [PATCH RFC 4/5] tun: vringfd xmit support.

2008-04-06 Thread Herbert Xu
Rusty Russell [EMAIL PROTECTED] wrote: +/* We are done with this skb: put it in the used pile. */ +static void skb_finished(struct skb_shared_info *sinfo) +{ + struct skb_shinfo_tun *sht = (void *)(sinfo + 1); + + /* FIXME: Race prevention */ +

[PATCH RFC 4/5] tun: vringfd xmit support.

2008-04-05 Thread Rusty Russell
This patch modifies tun to allow a vringfd to specify the send buffer. The user does a write to push out packets from the buffer. Again, more thought needs to be put into the possible races with ring registration. Again we use the 'struct virtio_net_hdr' to allow userspace to send GSO packets.