Re: [PATCH V2 4/5] virtio-pci: implement synchronize_vqs()

2022-04-13 Thread Cornelia Huck
On Wed, Apr 13 2022, Jason Wang wrote: > On Wed, Apr 13, 2022 at 12:49 AM Cornelia Huck wrote: >> >> On Tue, Apr 12 2022, Halil Pasic wrote: >> >> > On Mon, 11 Apr 2022 16:27:41 +0200 >> > Cornelia Huck wrote: >> >> >> My main concern is that we would need to synchronize against a single >>

Re: [PATCH V2 4/5] virtio-pci: implement synchronize_vqs()

2022-04-12 Thread Jason Wang
On Wed, Apr 13, 2022 at 12:49 AM Cornelia Huck wrote: > > On Tue, Apr 12 2022, Halil Pasic wrote: > > > On Mon, 11 Apr 2022 16:27:41 +0200 > > Cornelia Huck wrote: > > >> My main concern is that we would need to synchronize against a single > >> interrupt that covers all kinds of I/O

Re: [PATCH V2 4/5] virtio-pci: implement synchronize_vqs()

2022-04-12 Thread Cornelia Huck
On Tue, Apr 12 2022, Halil Pasic wrote: > On Mon, 11 Apr 2022 16:27:41 +0200 > Cornelia Huck wrote: >> My main concern is that we would need to synchronize against a single >> interrupt that covers all kinds of I/O interrupts, not just a single >> device... >> > > Could we synchronize on

Re: [PATCH V2 4/5] virtio-pci: implement synchronize_vqs()

2022-04-12 Thread Halil Pasic
On Tue, 12 Apr 2022 10:24:35 +0800 Jason Wang wrote: > > Regarding the question "are we safe against notifications before > > indicators have been registered" I think we really need to think about > > something like Secure Execution. We don't have, and we are unlikely > > to have in hardware

Re: [PATCH V2 4/5] virtio-pci: implement synchronize_vqs()

2022-04-11 Thread Jason Wang
On Tue, Apr 12, 2022 at 8:02 AM Halil Pasic wrote: > > On Mon, 11 Apr 2022 16:27:41 +0200 > Cornelia Huck wrote: > > > On Mon, Apr 11 2022, Jason Wang wrote: > > > > > On Sun, Apr 10, 2022 at 3:51 PM Michael S. Tsirkin > > > wrote: > > >> > > >> On Fri, Apr 08, 2022 at 03:03:07PM +0200, Halil

Re: [PATCH V2 4/5] virtio-pci: implement synchronize_vqs()

2022-04-11 Thread Jason Wang
On Mon, Apr 11, 2022 at 4:56 PM Michael S. Tsirkin wrote: > > On Mon, Apr 11, 2022 at 04:22:19PM +0800, Jason Wang wrote: > > On Sun, Apr 10, 2022 at 3:51 PM Michael S. Tsirkin wrote: > > > > > > On Fri, Apr 08, 2022 at 03:03:07PM +0200, Halil Pasic wrote: > > > > On Wed, 06 Apr 2022 15:04:32

Re: [PATCH V2 4/5] virtio-pci: implement synchronize_vqs()

2022-04-11 Thread Halil Pasic
On Mon, 11 Apr 2022 16:27:41 +0200 Cornelia Huck wrote: > On Mon, Apr 11 2022, Jason Wang wrote: > > > On Sun, Apr 10, 2022 at 3:51 PM Michael S. Tsirkin wrote: > > > >> > >> On Fri, Apr 08, 2022 at 03:03:07PM +0200, Halil Pasic wrote: > >> > On Wed, 06 Apr 2022 15:04:32 +0200 > >> >

Re: [PATCH V2 4/5] virtio-pci: implement synchronize_vqs()

2022-04-11 Thread Cornelia Huck
On Mon, Apr 11 2022, Jason Wang wrote: > On Sun, Apr 10, 2022 at 3:51 PM Michael S. Tsirkin wrote: >> >> On Fri, Apr 08, 2022 at 03:03:07PM +0200, Halil Pasic wrote: >> > On Wed, 06 Apr 2022 15:04:32 +0200 >> > Cornelia Huck wrote: >> > >> > > On Wed, Apr 06 2022, "Michael S. Tsirkin" wrote:

Re: [PATCH V2 4/5] virtio-pci: implement synchronize_vqs()

2022-04-11 Thread Michael S. Tsirkin
On Mon, Apr 11, 2022 at 04:22:19PM +0800, Jason Wang wrote: > On Sun, Apr 10, 2022 at 3:51 PM Michael S. Tsirkin wrote: > > > > On Fri, Apr 08, 2022 at 03:03:07PM +0200, Halil Pasic wrote: > > > On Wed, 06 Apr 2022 15:04:32 +0200 > > > Cornelia Huck wrote: > > > > > > > On Wed, Apr 06 2022,

Re: [PATCH V2 4/5] virtio-pci: implement synchronize_vqs()

2022-04-11 Thread Jason Wang
On Sun, Apr 10, 2022 at 3:51 PM Michael S. Tsirkin wrote: > > On Fri, Apr 08, 2022 at 03:03:07PM +0200, Halil Pasic wrote: > > On Wed, 06 Apr 2022 15:04:32 +0200 > > Cornelia Huck wrote: > > > > > On Wed, Apr 06 2022, "Michael S. Tsirkin" wrote: > > > > > > > On Wed, Apr 06, 2022 at 04:35:37PM

Re: [PATCH V2 4/5] virtio-pci: implement synchronize_vqs()

2022-04-10 Thread Michael S. Tsirkin
On Fri, Apr 08, 2022 at 03:03:07PM +0200, Halil Pasic wrote: > On Wed, 06 Apr 2022 15:04:32 +0200 > Cornelia Huck wrote: > > > On Wed, Apr 06 2022, "Michael S. Tsirkin" wrote: > > > > > On Wed, Apr 06, 2022 at 04:35:37PM +0800, Jason Wang wrote: > > >> This patch implements PCI version of

Re: [PATCH V2 4/5] virtio-pci: implement synchronize_vqs()

2022-04-08 Thread Halil Pasic
On Wed, 06 Apr 2022 15:04:32 +0200 Cornelia Huck wrote: > On Wed, Apr 06 2022, "Michael S. Tsirkin" wrote: > > > On Wed, Apr 06, 2022 at 04:35:37PM +0800, Jason Wang wrote: > >> This patch implements PCI version of synchronize_vqs(). > >> > >> Cc: Thomas Gleixner > >> Cc: Peter Zijlstra >

Re: [PATCH V2 4/5] virtio-pci: implement synchronize_vqs()

2022-04-07 Thread Jason Wang
On Thu, Apr 7, 2022 at 3:53 PM Cornelia Huck wrote: > > On Thu, Apr 07 2022, Jason Wang wrote: > > > 在 2022/4/6 下午11:31, Michael S. Tsirkin 写道: > >> On Wed, Apr 06, 2022 at 03:04:32PM +0200, Cornelia Huck wrote: > >>> On Wed, Apr 06 2022, "Michael S. Tsirkin" wrote: > >>> > On Wed, Apr 06,

Re: [PATCH V2 4/5] virtio-pci: implement synchronize_vqs()

2022-04-07 Thread Cornelia Huck
On Thu, Apr 07 2022, Jason Wang wrote: > 在 2022/4/6 下午11:31, Michael S. Tsirkin 写道: >> On Wed, Apr 06, 2022 at 03:04:32PM +0200, Cornelia Huck wrote: >>> On Wed, Apr 06 2022, "Michael S. Tsirkin" wrote: >>> On Wed, Apr 06, 2022 at 04:35:37PM +0800, Jason Wang wrote: > This patch

Re: [PATCH V2 4/5] virtio-pci: implement synchronize_vqs()

2022-04-07 Thread Jason Wang
在 2022/4/6 下午11:31, Michael S. Tsirkin 写道: On Wed, Apr 06, 2022 at 03:04:32PM +0200, Cornelia Huck wrote: On Wed, Apr 06 2022, "Michael S. Tsirkin" wrote: On Wed, Apr 06, 2022 at 04:35:37PM +0800, Jason Wang wrote: This patch implements PCI version of synchronize_vqs(). Cc: Thomas

Re: [PATCH V2 4/5] virtio-pci: implement synchronize_vqs()

2022-04-06 Thread Michael S. Tsirkin
On Wed, Apr 06, 2022 at 03:04:32PM +0200, Cornelia Huck wrote: > On Wed, Apr 06 2022, "Michael S. Tsirkin" wrote: > > > On Wed, Apr 06, 2022 at 04:35:37PM +0800, Jason Wang wrote: > >> This patch implements PCI version of synchronize_vqs(). > >> > >> Cc: Thomas Gleixner > >> Cc: Peter Zijlstra

Re: [PATCH V2 4/5] virtio-pci: implement synchronize_vqs()

2022-04-06 Thread Cornelia Huck
On Wed, Apr 06 2022, "Michael S. Tsirkin" wrote: > On Wed, Apr 06, 2022 at 04:35:37PM +0800, Jason Wang wrote: >> This patch implements PCI version of synchronize_vqs(). >> >> Cc: Thomas Gleixner >> Cc: Peter Zijlstra >> Cc: "Paul E. McKenney" >> Cc: Marc Zyngier >> Signed-off-by: Jason

Re: [PATCH V2 4/5] virtio-pci: implement synchronize_vqs()

2022-04-06 Thread Michael S. Tsirkin
On Wed, Apr 06, 2022 at 04:35:37PM +0800, Jason Wang wrote: > This patch implements PCI version of synchronize_vqs(). > > Cc: Thomas Gleixner > Cc: Peter Zijlstra > Cc: "Paul E. McKenney" > Cc: Marc Zyngier > Signed-off-by: Jason Wang Please add implementations at least for ccw and mmio. >

[PATCH V2 4/5] virtio-pci: implement synchronize_vqs()

2022-04-06 Thread Jason Wang
This patch implements PCI version of synchronize_vqs(). Cc: Thomas Gleixner Cc: Peter Zijlstra Cc: "Paul E. McKenney" Cc: Marc Zyngier Signed-off-by: Jason Wang --- drivers/virtio/virtio_pci_common.c | 14 ++ drivers/virtio/virtio_pci_common.h | 2 ++