Re: [PATCH linux-next v4 6/8] vdpa/mlx5: Fix clearing of VIRTIO_NET_F_MAC feature bit

2021-10-25 Thread Jason Wang
在 2021/10/25 下午3:08, Parav Pandit 写道: From: Jason Wang Sent: Monday, October 25, 2021 12:35 PM 在 2021/10/22 上午12:35, Parav Pandit 写道: Cited patch in the fixes tag clears the features bit during reset. mlx5 vdpa device feature bits are static decided by device capabilities. This is not wha

RE: [PATCH linux-next v4 6/8] vdpa/mlx5: Fix clearing of VIRTIO_NET_F_MAC feature bit

2021-10-25 Thread Parav Pandit via Virtualization
> From: Jason Wang > Sent: Monday, October 25, 2021 12:35 PM > > 在 2021/10/22 上午12:35, Parav Pandit 写道: > > Cited patch in the fixes tag clears the features bit during reset. > > mlx5 vdpa device feature bits are static decided by device capabilities. > > > This is not what I read at least fr

Re: [PATCH linux-next v4 6/8] vdpa/mlx5: Fix clearing of VIRTIO_NET_F_MAC feature bit

2021-10-25 Thread Jason Wang
在 2021/10/22 上午12:35, Parav Pandit 写道: Cited patch in the fixes tag clears the features bit during reset. mlx5 vdpa device feature bits are static decided by device capabilities. This is not what I read at least from mlx5_vdpa_get_features: static u64 mlx5_vdpa_get_features(struct vdpa_devic

[PATCH linux-next v4 6/8] vdpa/mlx5: Fix clearing of VIRTIO_NET_F_MAC feature bit

2021-10-21 Thread Parav Pandit via Virtualization
Cited patch in the fixes tag clears the features bit during reset. mlx5 vdpa device feature bits are static decided by device capabilities. Clearing features bit cleared the VIRTIO_NET_F_MAC. Due to this MAC address provided by the device is not honored. Fix it by not clearing the static feature