On Sat, Oct 9, 2021 at 5:18 PM Michael S. Tsirkin wrote:
>
> From: Xuan Zhuo
>
> commit 126285651b7f ("Merge
> ra.kernel.org:/pub/scm/linux/kernel/git/netdev/net")
> accidentally reverted the effect of
> commit 1a8024239da ("virtio-net: fix for skb_over_panic inside big mode")
> on
On Sat, 9 Oct 2021 05:17:53 -0400, Michael S. Tsirkin wrote:
> From: Xuan Zhuo
>
> commit 126285651b7f ("Merge
> ra.kernel.org:/pub/scm/linux/kernel/git/netdev/net")
> accidentally reverted the effect of
> commit 1a8024239da ("virtio-net: fix for skb_over_panic inside big mode")
> on
From: Xuan Zhuo
commit 126285651b7f ("Merge ra.kernel.org:/pub/scm/linux/kernel/git/netdev/net")
accidentally reverted the effect of
commit 1a8024239da ("virtio-net: fix for skb_over_panic inside big mode")
on drivers/net/virtio_net.c
As a result, users of crosvm (which is using large packet
在 2021/6/4 上午11:05, Xuan Zhuo 写道:
On Fri, 4 Jun 2021 11:00:25 +0800, Jason Wang wrote:
在 2021/6/4 上午10:30, Xuan Zhuo 写道:
On Fri, 4 Jun 2021 10:28:41 +0800, Jason Wang wrote:
在 2021/6/4 上午1:09, Xuan Zhuo 写道:
In virtio-net's large packet mode, there is a hole in the space behind
buf.
On Fri, 4 Jun 2021 11:00:25 +0800, Jason Wang wrote:
>
> 在 2021/6/4 上午10:30, Xuan Zhuo 写道:
> > On Fri, 4 Jun 2021 10:28:41 +0800, Jason Wang wrote:
> >> 在 2021/6/4 上午1:09, Xuan Zhuo 写道:
> >>> In virtio-net's large packet mode, there is a hole in the space behind
> >>> buf.
> >>
> >> before the
在 2021/6/4 上午10:30, Xuan Zhuo 写道:
On Fri, 4 Jun 2021 10:28:41 +0800, Jason Wang wrote:
在 2021/6/4 上午1:09, Xuan Zhuo 写道:
In virtio-net's large packet mode, there is a hole in the space behind
buf.
before the buf actually or behind the vnet header?
hdr_padded_len - hdr_len
We must
On Fri, 4 Jun 2021 10:28:41 +0800, Jason Wang wrote:
>
> 在 2021/6/4 上午1:09, Xuan Zhuo 写道:
> > In virtio-net's large packet mode, there is a hole in the space behind
> > buf.
>
>
> before the buf actually or behind the vnet header?
>
>
> >
> > hdr_padded_len - hdr_len
> >
> > We must take
在 2021/6/4 上午1:09, Xuan Zhuo 写道:
In virtio-net's large packet mode, there is a hole in the space behind
buf.
before the buf actually or behind the vnet header?
hdr_padded_len - hdr_len
We must take this into account when calculating tailroom.
[ 44.544385] skb_put.cold
In virtio-net's large packet mode, there is a hole in the space behind
buf.
hdr_padded_len - hdr_len
We must take this into account when calculating tailroom.
[ 44.544385] skb_put.cold (net/core/skbuff.c:5254 (discriminator 1)
net/core/skbuff.c:5252 (discriminator 1))
[ 44.544864]