Re: [PATCH v2] virtiofs: propagate sync() to file server

2021-04-30 Thread Greg Kurz
On Fri, 30 Apr 2021 08:17:57 -0400 Vivek Goyal wrote: > On Tue, Apr 27, 2021 at 09:09:21PM +0200, Greg Kurz wrote: > [..] > > > > diff --git a/include/uapi/linux/fuse.h b/include/uapi/linux/fuse.h > > > > index 54442612c48b..1265ca17620c 100644 > > > > --- a/include/uapi/linux/fuse.h > > > > +++

Re: [PATCH v2] virtiofs: propagate sync() to file server

2021-04-30 Thread Vivek Goyal
On Tue, Apr 27, 2021 at 09:09:21PM +0200, Greg Kurz wrote: [..] > > > diff --git a/include/uapi/linux/fuse.h b/include/uapi/linux/fuse.h > > > index 54442612c48b..1265ca17620c 100644 > > > --- a/include/uapi/linux/fuse.h > > > +++ b/include/uapi/linux/fuse.h > > > @@ -179,6 +179,9 @@ > > > * 7.3

Re: [PATCH v2] virtiofs: propagate sync() to file server

2021-04-27 Thread Greg Kurz
On Tue, 27 Apr 2021 13:12:06 -0400 Vivek Goyal wrote: > On Mon, Apr 26, 2021 at 05:10:11PM +0200, Greg Kurz wrote: > > Even if POSIX doesn't mandate it, linux users legitimately expect > > sync() to flush all data and metadata to physical storage when it > > is located on the same system. This is

Re: [PATCH v2] virtiofs: propagate sync() to file server

2021-04-27 Thread Vivek Goyal
On Mon, Apr 26, 2021 at 05:10:11PM +0200, Greg Kurz wrote: > Even if POSIX doesn't mandate it, linux users legitimately expect > sync() to flush all data and metadata to physical storage when it > is located on the same system. This isn't happening with virtiofs > though : sync() inside the guest r

[PATCH v2] virtiofs: propagate sync() to file server

2021-04-26 Thread Greg Kurz
Even if POSIX doesn't mandate it, linux users legitimately expect sync() to flush all data and metadata to physical storage when it is located on the same system. This isn't happening with virtiofs though : sync() inside the guest returns right away even though data still needs to be flushed from t