Re: [PATCH v3 0/4] Introduce akcipher service for virtio-crypto

2022-04-06 Thread Michael S. Tsirkin
On Tue, Apr 05, 2022 at 10:33:42AM +0200, Cornelia Huck wrote: > On Tue, Apr 05 2022, "Michael S. Tsirkin" wrote: > > > On Mon, Apr 04, 2022 at 05:39:24PM +0200, Cornelia Huck wrote: > >> On Mon, Mar 07 2022, "Michael S. Tsirkin" wrote: > >> > >> > On Mon, Mar 07, 2022 at 10:42:30AM +0800,

Re: [PATCH v3 0/4] Introduce akcipher service for virtio-crypto

2022-04-05 Thread Cornelia Huck
On Tue, Apr 05 2022, "Michael S. Tsirkin" wrote: > On Mon, Apr 04, 2022 at 05:39:24PM +0200, Cornelia Huck wrote: >> On Mon, Mar 07 2022, "Michael S. Tsirkin" wrote: >> >> > On Mon, Mar 07, 2022 at 10:42:30AM +0800, zhenwei pi wrote: >> >> Hi, Michael & Lei >> >> >> >> The full patchset has

Re: [PATCH v3 0/4] Introduce akcipher service for virtio-crypto

2022-04-04 Thread Michael S. Tsirkin
On Mon, Apr 04, 2022 at 05:39:24PM +0200, Cornelia Huck wrote: > On Mon, Mar 07 2022, "Michael S. Tsirkin" wrote: > > > On Mon, Mar 07, 2022 at 10:42:30AM +0800, zhenwei pi wrote: > >> Hi, Michael & Lei > >> > >> The full patchset has been reviewed by Gonglei, thanks to Gonglei. > >> Should I

Re: [PATCH v3 0/4] Introduce akcipher service for virtio-crypto

2022-04-04 Thread Cornelia Huck
On Mon, Mar 07 2022, "Michael S. Tsirkin" wrote: > On Mon, Mar 07, 2022 at 10:42:30AM +0800, zhenwei pi wrote: >> Hi, Michael & Lei >> >> The full patchset has been reviewed by Gonglei, thanks to Gonglei. >> Should I modify the virtio crypto specification(use "__le32 akcipher_algo;" >> instead

Re: Re: [PATCH v3 0/4] Introduce akcipher service for virtio-crypto

2022-03-07 Thread zhenwei pi
On 3/7/22 5:05 PM, Michael S. Tsirkin wrote: On Mon, Mar 07, 2022 at 10:42:30AM +0800, zhenwei pi wrote: Hi, Michael & Lei The full patchset has been reviewed by Gonglei, thanks to Gonglei. Should I modify the virtio crypto specification(use "__le32 akcipher_algo;" instead of "__le32 reserve;"

Re: [PATCH v3 0/4] Introduce akcipher service for virtio-crypto

2022-03-07 Thread Michael S. Tsirkin
On Mon, Mar 07, 2022 at 10:42:30AM +0800, zhenwei pi wrote: > Hi, Michael & Lei > > The full patchset has been reviewed by Gonglei, thanks to Gonglei. > Should I modify the virtio crypto specification(use "__le32 akcipher_algo;" > instead of "__le32 reserve;" only, see v1->v2 change), and start a

Re: [PATCH v3 0/4] Introduce akcipher service for virtio-crypto

2022-03-06 Thread zhenwei pi
Hi, Michael & Lei The full patchset has been reviewed by Gonglei, thanks to Gonglei. Should I modify the virtio crypto specification(use "__le32 akcipher_algo;" instead of "__le32 reserve;" only, see v1->v2 change), and start a new issue for a revoting procedure? Also cc Cornelia Huck. On

Re: Re: [PATCH v3 0/4] Introduce akcipher service for virtio-crypto

2022-03-02 Thread zhenwei pi
On 3/3/22 4:40 AM, Eric Biggers wrote: On Wed, Mar 02, 2022 at 11:39:13AM +0800, zhenwei pi wrote: v2 -> v3: Rename virtio_crypto_algs.c to virtio_crypto_skcipher_algs.c, and minor changes of function name. Minor changes in virtio_crypto_akcipher_algs.c: no need to copy from

[PATCH v3 0/4] Introduce akcipher service for virtio-crypto

2022-03-01 Thread zhenwei pi
v2 -> v3: Rename virtio_crypto_algs.c to virtio_crypto_skcipher_algs.c, and minor changes of function name. Minor changes in virtio_crypto_akcipher_algs.c: no need to copy from buffer if opcode is verify. v1 -> v2: Fix 1 compiling warning reported by kernel test robot Put "__le32