Re: [PATCH v3 6/6] freezer,sched: Rewrite core freezer logic

Am 27.09.22 um 07:35 schrieb Christian Borntraeger: Am 26.09.22 um 20:22 schrieb Peter Zijlstra: On Mon, Sep 26, 2022 at 08:06:46PM +0200, Peter Zijlstra wrote: Let me go git-grep some to see if there's more similar fail. I've ended up with the below... Tested-by: Christian Borntraege

Re: [PATCH v3 6/6] freezer,sched: Rewrite core freezer logic

Am 26.09.22 um 20:22 schrieb Peter Zijlstra: On Mon, Sep 26, 2022 at 08:06:46PM +0200, Peter Zijlstra wrote: Let me go git-grep some to see if there's more similar fail. I've ended up with the below... Tested-by: Christian Borntraeger Kind of scary that nobody else has reported any reg

Re: [PATCH v3 6/6] freezer,sched: Rewrite core freezer logic

On Mon, Sep 26, 2022 at 08:06:46PM +0200, Peter Zijlstra wrote: > Let me go git-grep some to see if there's more similar fail. I've ended up with the below... --- include/linux/wait.h | 2 +- kernel/hung_task.c | 8 ++-- kernel/sched/core.c | 2 +- 3 files changed, 8 insertions(+), 4 del

Re: [PATCH v3 6/6] freezer,sched: Rewrite core freezer logic

On Mon, Sep 26, 2022 at 05:49:16PM +0200, Christian Borntraeger wrote: > Hmm, > > #define ___wait_is_interruptible(state) > \ > (!__builtin_constant_p(state) || > \ > state == TASK_INTERRUPTIB

Re: [PATCH v3 6/6] freezer,sched: Rewrite core freezer logic

Am 26.09.22 um 15:37 schrieb Peter Zijlstra: On Mon, Sep 26, 2022 at 03:23:10PM +0200, Christian Borntraeger wrote: Am 26.09.22 um 14:55 schrieb Peter Zijlstra: Could you please test with something like the below on? I can boot that with KVM, but obviously I didn't suffer any weirdness to b

Re: [PATCH v3 6/6] freezer,sched: Rewrite core freezer logic

Am 26.09.22 um 15:37 schrieb Peter Zijlstra: On Mon, Sep 26, 2022 at 03:23:10PM +0200, Christian Borntraeger wrote: Am 26.09.22 um 14:55 schrieb Peter Zijlstra: Could you please test with something like the below on? I can boot that with KVM, but obviously I didn't suffer any weirdness to b

Re: [PATCH v3 6/6] freezer,sched: Rewrite core freezer logic

On Mon, Sep 26, 2022 at 03:23:10PM +0200, Christian Borntraeger wrote: > Am 26.09.22 um 14:55 schrieb Peter Zijlstra: > > > Could you please test with something like the below on? I can boot that > > with KVM, but obviously I didn't suffer any weirdness to begin with :/ > > > > --- > > diff --git

Re: [PATCH v3 6/6] freezer,sched: Rewrite core freezer logic

Am 26.09.22 um 14:55 schrieb Peter Zijlstra: Could you please test with something like the below on? I can boot that with KVM, but obviously I didn't suffer any weirdness to begin with :/ --- diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 4e6a6417211f..ef9ccfc3a8c0 100644 --- a

Re: [PATCH v3 6/6] freezer,sched: Rewrite core freezer logic

Am 26.09.22 um 12:55 schrieb Christian Borntraeger: Am 26.09.22 um 10:06 schrieb Christian Borntraeger: Am 23.09.22 um 09:53 schrieb Christian Borntraeger: Am 23.09.22 um 09:21 schrieb Christian Borntraeger: Peter, as a heads-up. This commit (bisected and verified) triggers a regression

Re: [PATCH v3 6/6] freezer,sched: Rewrite core freezer logic

On Mon, Sep 26, 2022 at 02:32:24PM +0200, Christian Borntraeger wrote: > diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c > index 9fa3c76a267f..e93df4f735fe 100644 > --- a/drivers/char/virtio_console.c > +++ b/drivers/char/virtio_console.c > @@ -790,7 +790,7 @@ static int

Re: [PATCH v3 6/6] freezer,sched: Rewrite core freezer logic

On Mon, Sep 26, 2022 at 12:55:21PM +0200, Christian Borntraeger wrote: > > > Am 26.09.22 um 10:06 schrieb Christian Borntraeger: > > > > > > Am 23.09.22 um 09:53 schrieb Christian Borntraeger: > > > Am 23.09.22 um 09:21 schrieb Christian Borntraeger: > > > > Peter, > > > > > > > > as a heads-u