Re: [PATCH v4 0/3] virtio support cache indirect desc

2021-11-11 Thread Xuan Zhuo
On Thu, 11 Nov 2021 10:02:01 -0500, Michael S. Tsirkin wrote: > On Thu, Nov 11, 2021 at 02:52:07PM +0800, Xuan Zhuo wrote: > > On Wed, 10 Nov 2021 07:53:44 -0500, Michael S. Tsirkin > > wrote: > > > On Mon, Nov 08, 2021 at 10:47:40PM +0800, Xuan Zhuo wrote: > > > > On Mon, 8 Nov 2021 08:49:27

Re: [PATCH v4 0/3] virtio support cache indirect desc

2021-11-11 Thread Michael S. Tsirkin
On Thu, Nov 11, 2021 at 02:52:07PM +0800, Xuan Zhuo wrote: > On Wed, 10 Nov 2021 07:53:44 -0500, Michael S. Tsirkin > wrote: > > On Mon, Nov 08, 2021 at 10:47:40PM +0800, Xuan Zhuo wrote: > > > On Mon, 8 Nov 2021 08:49:27 -0500, Michael S. Tsirkin > > > wrote: > > > > > > > > Hmm a bunch of

Re: [PATCH v4 0/3] virtio support cache indirect desc

2021-11-10 Thread Xuan Zhuo
On Wed, 10 Nov 2021 07:53:44 -0500, Michael S. Tsirkin wrote: > On Mon, Nov 08, 2021 at 10:47:40PM +0800, Xuan Zhuo wrote: > > On Mon, 8 Nov 2021 08:49:27 -0500, Michael S. Tsirkin > > wrote: > > > > > > Hmm a bunch of comments got ignored. See e.g. > > >

Re: [PATCH v4 0/3] virtio support cache indirect desc

2021-11-10 Thread Michael S. Tsirkin
On Wed, Nov 10, 2021 at 07:53:49AM -0500, Michael S. Tsirkin wrote: > On Mon, Nov 08, 2021 at 10:47:40PM +0800, Xuan Zhuo wrote: > > On Mon, 8 Nov 2021 08:49:27 -0500, Michael S. Tsirkin > > wrote: > > > > > > Hmm a bunch of comments got ignored. See e.g. > > >

Re: [PATCH v4 0/3] virtio support cache indirect desc

2021-11-10 Thread Michael S. Tsirkin
On Mon, Nov 08, 2021 at 10:47:40PM +0800, Xuan Zhuo wrote: > On Mon, 8 Nov 2021 08:49:27 -0500, Michael S. Tsirkin wrote: > > > > Hmm a bunch of comments got ignored. See e.g. > > https://lore.kernel.org/r/20211027043851-mutt-send-email-mst%40kernel.org > > if they aren't relevant add code

Re: [PATCH v4 0/3] virtio support cache indirect desc

2021-11-09 Thread Xuan Zhuo
On Tue, 9 Nov 2021 08:03:18 -0500, Michael S. Tsirkin wrote: > On Mon, Nov 08, 2021 at 07:49:48PM +0800, Xuan Zhuo wrote: > > If the VIRTIO_RING_F_INDIRECT_DESC negotiation succeeds, and the number > > of sgs used for sending packets is greater than 1. We must constantly > > call __kmalloc/kfree

Re: [PATCH v4 0/3] virtio support cache indirect desc

2021-11-09 Thread Michael S. Tsirkin
On Mon, Nov 08, 2021 at 07:49:48PM +0800, Xuan Zhuo wrote: > If the VIRTIO_RING_F_INDIRECT_DESC negotiation succeeds, and the number > of sgs used for sending packets is greater than 1. We must constantly > call __kmalloc/kfree to allocate/release desc. > > In the case of extremely fast package

Re: [PATCH v4 0/3] virtio support cache indirect desc

2021-11-08 Thread Xuan Zhuo
On Mon, 8 Nov 2021 08:49:27 -0500, Michael S. Tsirkin wrote: > > Hmm a bunch of comments got ignored. See e.g. > https://lore.kernel.org/r/20211027043851-mutt-send-email-mst%40kernel.org > if they aren't relevant add code comments or commit log text explaining the > design choice please. I

Re: [PATCH v4 0/3] virtio support cache indirect desc

2021-11-08 Thread Michael S. Tsirkin
On Mon, Nov 08, 2021 at 07:49:48PM +0800, Xuan Zhuo wrote: > If the VIRTIO_RING_F_INDIRECT_DESC negotiation succeeds, and the number > of sgs used for sending packets is greater than 1. We must constantly > call __kmalloc/kfree to allocate/release desc. > > In the case of extremely fast package

[PATCH v4 0/3] virtio support cache indirect desc

2021-11-08 Thread Xuan Zhuo
If the VIRTIO_RING_F_INDIRECT_DESC negotiation succeeds, and the number of sgs used for sending packets is greater than 1. We must constantly call __kmalloc/kfree to allocate/release desc. In the case of extremely fast package delivery, the overhead cannot be ignored: 27.46% [kernel] [k]