Re: [PATCHv3 3/4] qemu-kvm: vhost-net implementation

2009-08-23 Thread Avi Kivity
On 08/20/2009 08:57 PM, Mark McLoughlin wrote: - I think /dev/vhost makes more sense - we shouldn't need to add another character device if we implement kernel backends for other virtio devices I'm of the opposite opinion - vhost-net and vhost-blk are related, but they're a

Re: [PATCHv3 3/4] qemu-kvm: vhost-net implementation

2009-08-20 Thread Mark McLoughlin
Hi Michael, Some random high-level comments: - I had expected this to be available as: -net raw,ifname=eth2 -net nic,model=virtio I'd prefer it this way, because it means you can use this mode even without vhost and it's ties in better with the way all other qemu

Re: [PATCHv3 3/4] qemu-kvm: vhost-net implementation

2009-08-20 Thread Arnd Bergmann
On Thursday 20 August 2009, Mark McLoughlin wrote: - I had expected this to be available as: -net raw,ifname=eth2 -net nic,model=virtio I'd prefer it this way, because it means you can use this mode even without vhost and it's ties in better with the way all other qemu

Re: [PATCHv3 3/4] qemu-kvm: vhost-net implementation

2009-08-20 Thread Michael S. Tsirkin
On Thu, Aug 20, 2009 at 06:57:07PM +0100, Mark McLoughlin wrote: Hi Michael, Some random high-level comments: Note this code is posted very much just so that people can test vhost, not really for merging, but thanks for review! - I had expected this to be available as: -net

[PATCHv3 3/4] qemu-kvm: vhost-net implementation

2009-08-17 Thread Michael S. Tsirkin
This adds support for vhost-net virtio kernel backend. To enable (assuming device eth2): 1. enable promisc mode or program guest mac in device eth2 2. disable tso, gso, lro, jumbo frames on the card (disabling lro + jumbo frames should be sufficient, haven't tested this) 3. add vhost=eth2