Re: [PATCHv4 2/2] virtio: refactor find_vqs

2009-08-27 Thread Rusty Russell
On Tue, 25 Aug 2009 09:34:34 pm Michael S. Tsirkin wrote: That's because we didn't do the request_irq's for the per_vector case, because we don't have the names. This is what prevented me from doing a nice encapsulation. Yes. But let's split free_vectors out into free_msix_vectors and

Re: [PATCHv4 2/2] virtio: refactor find_vqs

2009-08-27 Thread Michael S. Tsirkin
On Thu, Aug 27, 2009 at 07:00:34PM +0930, Rusty Russell wrote: On Tue, 25 Aug 2009 09:34:34 pm Michael S. Tsirkin wrote: That's because we didn't do the request_irq's for the per_vector case, because we don't have the names. This is what prevented me from doing a nice encapsulation.

Re: [PATCHv4 2/2] virtio: refactor find_vqs

2009-08-27 Thread Rusty Russell
On Thu, 27 Aug 2009 07:19:26 pm Michael S. Tsirkin wrote: On Thu, Aug 27, 2009 at 07:00:34PM +0930, Rusty Russell wrote: On Tue, 25 Aug 2009 09:34:34 pm Michael S. Tsirkin wrote: That's because we didn't do the request_irq's for the per_vector case, because we don't have the names.

Re: [PATCHv4 2/2] virtio: refactor find_vqs

2009-08-27 Thread Michael S. Tsirkin
On Thu, Aug 27, 2009 at 08:32:24PM +0930, Rusty Russell wrote: On Thu, 27 Aug 2009 07:19:26 pm Michael S. Tsirkin wrote: On Thu, Aug 27, 2009 at 07:00:34PM +0930, Rusty Russell wrote: On Tue, 25 Aug 2009 09:34:34 pm Michael S. Tsirkin wrote: That's because we didn't do the request_irq's

Re: [PATCHv4 2/2] virtio: refactor find_vqs

2009-08-25 Thread Michael S. Tsirkin
Sorry it took a bit to respond to this. I kept hoping I'll have time to test it but looks like I won't before I'm on vacation. I agree it's good cleanup, and maybe we can go even further, see below. On Mon, Aug 10, 2009 at 09:07:52AM +0930, Rusty Russell wrote: On Tue, 28 Jul 2009 06:03:08 pm

Re: [PATCHv4 2/2] virtio: refactor find_vqs

2009-08-09 Thread Rusty Russell
On Tue, 28 Jul 2009 06:03:08 pm Michael S. Tsirkin wrote: On Tue, Jul 28, 2009 at 12:44:31PM +0930, Rusty Russell wrote: On Mon, 27 Jul 2009 01:17:09 am Michael S. Tsirkin wrote: This refactors find_vqs, making it more readable and robust, and fixing two regressions from 2.6.30: -

Re: [PATCHv4 2/2] virtio: refactor find_vqs

2009-07-28 Thread Michael S. Tsirkin
On Tue, Jul 28, 2009 at 12:44:31PM +0930, Rusty Russell wrote: On Mon, 27 Jul 2009 01:17:09 am Michael S. Tsirkin wrote: This refactors find_vqs, making it more readable and robust, and fixing two regressions from 2.6.30: - double free_irq causing BUG_ON on device removal - probe failure

Re: [PATCHv4 2/2] virtio: refactor find_vqs

2009-07-28 Thread Amit Shah
On (Tue) Jul 28 2009 [12:44:31], Rusty Russell wrote: On Mon, 27 Jul 2009 01:17:09 am Michael S. Tsirkin wrote: This refactors find_vqs, making it more readable and robust, and fixing two regressions from 2.6.30: - double free_irq causing BUG_ON on device removal - probe failure when vq

Re: [PATCHv4 2/2] virtio: refactor find_vqs

2009-07-28 Thread Michael S. Tsirkin
On Tue, Jul 28, 2009 at 08:00:52PM +0530, Amit Shah wrote: On (Tue) Jul 28 2009 [12:44:31], Rusty Russell wrote: On Mon, 27 Jul 2009 01:17:09 am Michael S. Tsirkin wrote: This refactors find_vqs, making it more readable and robust, and fixing two regressions from 2.6.30: - double

Re: [PATCHv4 2/2] virtio: refactor find_vqs

2009-07-27 Thread Rusty Russell
On Mon, 27 Jul 2009 01:17:09 am Michael S. Tsirkin wrote: This refactors find_vqs, making it more readable and robust, and fixing two regressions from 2.6.30: - double free_irq causing BUG_ON on device removal - probe failure when vq can't be assigned to msi-x vector (reported on old host

[PATCHv4 2/2] virtio: refactor find_vqs

2009-07-26 Thread Michael S. Tsirkin
This refactors find_vqs, making it more readable and robust, and fixing two regressions from 2.6.30: - double free_irq causing BUG_ON on device removal - probe failure when vq can't be assigned to msi-x vector (reported on old host kernels) An older version of this patch was tested by Amit