Re: [RESENDx2] [PULL] virtio: fix barriers for virtio-mmio

2011-12-28 Thread Ohad Ben-Cohen
On Thu, Dec 29, 2011 at 6:31 AM, Rusty Russell wrote: > OK, I've applied this patch; you might want to carry it in your tree > too.  You'll need to fix up your call to vring_new_virtqueue() Will do. Thanks ! ___ Virtualization mailing list Virtualiz

Re: [RESENDx2] [PULL] virtio: fix barriers for virtio-mmio

2011-12-28 Thread Rusty Russell
On Fri, 23 Dec 2011 13:35:26 +0200, Ohad Ben-Cohen wrote: > On Fri, Dec 23, 2011 at 11:35 AM, Linus Torvalds > And rpmsg is using virtio to avoid implementing another shared memory > "wire" protocol. And of course to be able to reuse all the existing > virtio drivers (e.g. net, block, console) wit

Re: [RESENDx2] [PULL] virtio: fix barriers for virtio-mmio

2011-12-23 Thread Rusty Russell
On Fri, 23 Dec 2011 13:35:26 +0200, Ohad Ben-Cohen wrote: > On Fri, Dec 23, 2011 at 11:35 AM, Linus Torvalds > wrote: > > On x86, there really is never any reason to use the heavy memory > > barriers unless you are talking to a real device. And last I saw, > > "virtio" was still about virtual IO.

Re: [RESENDx2] [PULL] virtio: fix barriers for virtio-mmio

2011-12-23 Thread Ohad Ben-Cohen
On Fri, Dec 23, 2011 at 11:35 AM, Linus Torvalds wrote: > On x86, there really is never any reason to use the heavy memory > barriers unless you are talking to a real device. And last I saw, > "virtio" was still about virtual IO. I reported this originally, so maybe I should describe our use case

Re: [RESENDx2] [PULL] virtio: fix barriers for virtio-mmio

2011-12-23 Thread Linus Torvalds
On Fri, Dec 23, 2011 at 1:31 AM, Linus Torvalds wrote: > > So the whole thing looks confused. There's never any reason to > actually use the expensive sfence/rfences at all. Afaik you still just > want smp_*mb() for all cases. But note that I haven't thought deeply about it, I just looked at the

Re: [RESENDx2] [PULL] virtio: fix barriers for virtio-mmio

2011-12-23 Thread Linus Torvalds
On Thu, Dec 22, 2011 at 9:16 PM, Rusty Russell wrote: > This one as a signed tag on github, in case the inline patch was > the reason you dropped this. No, and please why do you make your tag-names be your email address? That's just odd. It seems to be related to some broken SCM system that think

[RESENDx2] [PULL] virtio: fix barriers for virtio-mmio

2011-12-22 Thread Rusty Russell
This one as a signed tag on github, in case the inline patch was the reason you dropped this. virtio-mmio in new 3.2, and they found a corruption bug. Please apply. * [new tag] ru...@rustcorp.com.au -> ru...@rustcorp.com.au The following changes since commit b3b1b70e62a603f473619dbebc3b