Re: [RFC v2] virtio-vsock: add description for datagram type

2021-06-09 Thread Stefano Garzarella
On Tue, Jun 08, 2021 at 09:31:28PM -0700, Jiang Wang . wrote: On Tue, May 18, 2021 at 9:59 PM Jiang Wang . wrote: On Tue, May 18, 2021 at 6:02 AM Stefano Garzarella wrote: > > On Mon, May 17, 2021 at 11:33:06PM -0700, Jiang Wang . wrote: > >On Mon, May 17, 2021 at 4:02 AM Stefano Garzarella

Re: Re: [RFC v2] virtio-vsock: add description for datagram type

2021-06-08 Thread Jiang Wang .
On Tue, May 18, 2021 at 9:59 PM Jiang Wang . wrote: > > On Tue, May 18, 2021 at 6:02 AM Stefano Garzarella > wrote: > > > > On Mon, May 17, 2021 at 11:33:06PM -0700, Jiang Wang . wrote: > > >On Mon, May 17, 2021 at 4:02 AM Stefano Garzarella > > >wrote: > > >> > > >> On Fri, May 14, 2021 at

Re: Re: [RFC v2] virtio-vsock: add description for datagram type

2021-05-18 Thread Jiang Wang .
On Tue, May 18, 2021 at 6:02 AM Stefano Garzarella wrote: > > On Mon, May 17, 2021 at 11:33:06PM -0700, Jiang Wang . wrote: > >On Mon, May 17, 2021 at 4:02 AM Stefano Garzarella > >wrote: > >> > >> On Fri, May 14, 2021 at 11:55:29AM -0700, Jiang Wang . wrote: > >> >On Fri, May 14, 2021 at 8:17

Re: [RFC v2] virtio-vsock: add description for datagram type

2021-05-18 Thread Stefano Garzarella
On Mon, May 17, 2021 at 11:33:06PM -0700, Jiang Wang . wrote: On Mon, May 17, 2021 at 4:02 AM Stefano Garzarella wrote: On Fri, May 14, 2021 at 11:55:29AM -0700, Jiang Wang . wrote: >On Fri, May 14, 2021 at 8:17 AM Stefano Garzarella wrote: >> On Thu, May 13, 2021 at 04:26:03PM -0700, Jiang

Re: Re: [RFC v2] virtio-vsock: add description for datagram type

2021-05-18 Thread Jiang Wang .
On Mon, May 17, 2021 at 4:02 AM Stefano Garzarella wrote: > > On Fri, May 14, 2021 at 11:55:29AM -0700, Jiang Wang . wrote: > >On Fri, May 14, 2021 at 8:17 AM Stefano Garzarella > >wrote: > >> On Thu, May 13, 2021 at 04:26:03PM -0700, Jiang Wang . wrote: > > [...] > > >> >I see. I will add some

Re: [RFC v2] virtio-vsock: add description for datagram type

2021-05-17 Thread Stefano Garzarella
On Fri, May 14, 2021 at 11:55:29AM -0700, Jiang Wang . wrote: On Fri, May 14, 2021 at 8:17 AM Stefano Garzarella wrote: On Thu, May 13, 2021 at 04:26:03PM -0700, Jiang Wang . wrote: [...] >I see. I will add some limit to dgram packets. Also, when the >virtqueues >are shared between stream

Re: Re: [RFC v2] virtio-vsock: add description for datagram type

2021-05-14 Thread Jiang Wang .
On Fri, May 14, 2021 at 8:17 AM Stefano Garzarella wrote: > > On Thu, May 13, 2021 at 04:26:03PM -0700, Jiang Wang . wrote: > >On Mon, May 10, 2021 at 7:52 AM Stefano Garzarella > >wrote: > >> On Fri, May 07, 2021 at 09:53:19AM -0700, Jiang Wang . wrote: > > [...] > > >I was thinking if we

Re: [RFC v2] virtio-vsock: add description for datagram type

2021-05-14 Thread Stefano Garzarella
On Thu, May 13, 2021 at 04:26:03PM -0700, Jiang Wang . wrote: On Mon, May 10, 2021 at 7:52 AM Stefano Garzarella wrote: On Fri, May 07, 2021 at 09:53:19AM -0700, Jiang Wang . wrote: [...] I was thinking if we don't add two new virtqueues, then maybe we don't need to add new feature bit

Re: Re: [RFC v2] virtio-vsock: add description for datagram type

2021-05-13 Thread Jiang Wang .
On Mon, May 10, 2021 at 7:52 AM Stefano Garzarella wrote: > > On Fri, May 07, 2021 at 09:53:19AM -0700, Jiang Wang . wrote: > >Hi guys, > > > >I have one question about adding two new virtqueues for dgram. One new > >thought is that we don't add two new virtqueues but keep using existing >

Re: [External] Re: [RFC v2] virtio-vsock: add description for datagram type

2021-05-13 Thread Stefan Hajnoczi
On Mon, Apr 12, 2021 at 03:39:36PM -0700, Jiang Wang . wrote: > On Mon, Apr 12, 2021 at 6:50 AM Stefan Hajnoczi wrote: > > On Thu, Apr 01, 2021 at 04:36:02AM +, jiang.wang wrote: > > > +For the rx side, dgram also uses the \field{buf_alloc}. If it is full, > > > the packet > > > +is dropped

Re: [RFC v2] virtio-vsock: add description for datagram type

2021-05-10 Thread Stefano Garzarella
On Fri, May 07, 2021 at 09:53:19AM -0700, Jiang Wang . wrote: Hi guys, I have one question about adding two new virtqueues for dgram. One new thought is that we don't add two new virtqueues but keep using existing virtqueues for both stream and dgram. At the beginning when I first thought

Re: Re: [RFC v2] virtio-vsock: add description for datagram type

2021-05-07 Thread Jiang Wang .
Hi guys, I have one question about adding two new virtqueues for dgram. One new thought is that we don't add two new virtqueues but keep using existing virtqueues for both stream and dgram. At the beginning when I first thought about supporting dgram, I thought adding two new virtqueues would be

Re: Re: [RFC v2] virtio-vsock: add description for datagram type

2021-05-05 Thread Jiang Wang .
On Wed, May 5, 2021 at 3:49 AM Stefano Garzarella wrote: > > On Tue, May 04, 2021 at 10:06:02AM -0700, Jiang Wang . wrote: > >On Tue, May 4, 2021 at 9:16 AM Stefano Garzarella > >wrote: > >> > >> Hi Jiang, > >> > >> On Mon, May 03, 2021 at 08:40:46PM -0700, Jiang Wang . wrote: > >> >Hi Stefano,

Re: [RFC v2] virtio-vsock: add description for datagram type

2021-05-05 Thread Stefano Garzarella
On Tue, May 04, 2021 at 10:06:02AM -0700, Jiang Wang . wrote: On Tue, May 4, 2021 at 9:16 AM Stefano Garzarella wrote: Hi Jiang, On Mon, May 03, 2021 at 08:40:46PM -0700, Jiang Wang . wrote: >Hi Stefano, > >I checked the VIRTIO_NET_F_MRG_RXBUF feature bit and I think vsock >dgram can use

Re: Re: [RFC v2] virtio-vsock: add description for datagram type

2021-05-04 Thread Jiang Wang .
On Tue, May 4, 2021 at 9:16 AM Stefano Garzarella wrote: > > Hi Jiang, > > On Mon, May 03, 2021 at 08:40:46PM -0700, Jiang Wang . wrote: > >Hi Stefano, > > > >I checked the VIRTIO_NET_F_MRG_RXBUF feature bit and I think vsock > >dgram can use that feature too. > > Cool, thanks for checking! NP.

Re: [RFC v2] virtio-vsock: add description for datagram type

2021-05-04 Thread Stefano Garzarella
Hi Jiang, On Mon, May 03, 2021 at 08:40:46PM -0700, Jiang Wang . wrote: Hi Stefano, I checked the VIRTIO_NET_F_MRG_RXBUF feature bit and I think vsock dgram can use that feature too. Cool, thanks for checking! Do we want to make this feature a must-have or optional? One idea is to make it

Re: Re: [RFC v2] virtio-vsock: add description for datagram type

2021-04-14 Thread Jiang Wang .
On Wed, Apr 14, 2021 at 2:38 AM Stefano Garzarella wrote: > > On Wed, Apr 14, 2021 at 03:20:07AM -0400, Michael S. Tsirkin wrote: > >On Wed, Apr 14, 2021 at 08:57:06AM +0200, Stefano Garzarella wrote: > >> On Tue, Apr 13, 2021 at 03:58:34PM -0400, Michael S. Tsirkin wrote: > >> > On Tue, Apr 13,

Re: [RFC v2] virtio-vsock: add description for datagram type

2021-04-14 Thread Stefano Garzarella
On Wed, Apr 14, 2021 at 03:20:07AM -0400, Michael S. Tsirkin wrote: On Wed, Apr 14, 2021 at 08:57:06AM +0200, Stefano Garzarella wrote: On Tue, Apr 13, 2021 at 03:58:34PM -0400, Michael S. Tsirkin wrote: > On Tue, Apr 13, 2021 at 04:03:51PM +0200, Stefano Garzarella wrote: > > On Tue, Apr 13,

Re: [RFC v2] virtio-vsock: add description for datagram type

2021-04-14 Thread Michael S. Tsirkin
On Wed, Apr 14, 2021 at 08:57:06AM +0200, Stefano Garzarella wrote: > On Tue, Apr 13, 2021 at 03:58:34PM -0400, Michael S. Tsirkin wrote: > > On Tue, Apr 13, 2021 at 04:03:51PM +0200, Stefano Garzarella wrote: > > > On Tue, Apr 13, 2021 at 09:50:45AM -0400, Michael S. Tsirkin wrote: > > > > On

Re: [RFC v2] virtio-vsock: add description for datagram type

2021-04-14 Thread Stefano Garzarella
On Tue, Apr 13, 2021 at 03:00:50PM -0700, Jiang Wang . wrote: On Tue, Apr 13, 2021 at 12:58 PM Michael S. Tsirkin wrote: On Tue, Apr 13, 2021 at 04:03:51PM +0200, Stefano Garzarella wrote: > On Tue, Apr 13, 2021 at 09:50:45AM -0400, Michael S. Tsirkin wrote: > > On Tue, Apr 13, 2021 at

Re: [RFC v2] virtio-vsock: add description for datagram type

2021-04-14 Thread Stefano Garzarella
On Tue, Apr 13, 2021 at 03:58:34PM -0400, Michael S. Tsirkin wrote: On Tue, Apr 13, 2021 at 04:03:51PM +0200, Stefano Garzarella wrote: On Tue, Apr 13, 2021 at 09:50:45AM -0400, Michael S. Tsirkin wrote: > On Tue, Apr 13, 2021 at 03:38:52PM +0200, Stefano Garzarella wrote: > > On Tue, Apr 13,

Re: Re: [RFC v2] virtio-vsock: add description for datagram type

2021-04-13 Thread Jiang Wang .
On Tue, Apr 13, 2021 at 12:58 PM Michael S. Tsirkin wrote: > > On Tue, Apr 13, 2021 at 04:03:51PM +0200, Stefano Garzarella wrote: > > On Tue, Apr 13, 2021 at 09:50:45AM -0400, Michael S. Tsirkin wrote: > > > On Tue, Apr 13, 2021 at 03:38:52PM +0200, Stefano Garzarella wrote: > > > > On Tue, Apr

Re: [RFC v2] virtio-vsock: add description for datagram type

2021-04-13 Thread Michael S. Tsirkin
On Tue, Apr 13, 2021 at 04:03:51PM +0200, Stefano Garzarella wrote: > On Tue, Apr 13, 2021 at 09:50:45AM -0400, Michael S. Tsirkin wrote: > > On Tue, Apr 13, 2021 at 03:38:52PM +0200, Stefano Garzarella wrote: > > > On Tue, Apr 13, 2021 at 09:16:50AM -0400, Michael S. Tsirkin wrote: > > > > On

Re: [RFC v2] virtio-vsock: add description for datagram type

2021-04-13 Thread Stefano Garzarella
On Tue, Apr 13, 2021 at 09:50:45AM -0400, Michael S. Tsirkin wrote: On Tue, Apr 13, 2021 at 03:38:52PM +0200, Stefano Garzarella wrote: On Tue, Apr 13, 2021 at 09:16:50AM -0400, Michael S. Tsirkin wrote: > On Tue, Apr 13, 2021 at 02:58:53PM +0200, Stefano Garzarella wrote: > > On Mon, Apr 12,

Re: [RFC v2] virtio-vsock: add description for datagram type

2021-04-13 Thread Michael S. Tsirkin
On Tue, Apr 13, 2021 at 03:38:52PM +0200, Stefano Garzarella wrote: > On Tue, Apr 13, 2021 at 09:16:50AM -0400, Michael S. Tsirkin wrote: > > On Tue, Apr 13, 2021 at 02:58:53PM +0200, Stefano Garzarella wrote: > > > On Mon, Apr 12, 2021 at 03:42:23PM -0700, Jiang Wang . wrote: > > > > On Mon, Apr

Re: [RFC v2] virtio-vsock: add description for datagram type

2021-04-13 Thread Stefano Garzarella
On Tue, Apr 13, 2021 at 09:16:50AM -0400, Michael S. Tsirkin wrote: On Tue, Apr 13, 2021 at 02:58:53PM +0200, Stefano Garzarella wrote: On Mon, Apr 12, 2021 at 03:42:23PM -0700, Jiang Wang . wrote: > On Mon, Apr 12, 2021 at 7:21 AM Stefano Garzarella wrote: > > > > On Mon, Apr 12, 2021 at

Re: [RFC v2] virtio-vsock: add description for datagram type

2021-04-13 Thread Michael S. Tsirkin
On Tue, Apr 13, 2021 at 02:58:53PM +0200, Stefano Garzarella wrote: > On Mon, Apr 12, 2021 at 03:42:23PM -0700, Jiang Wang . wrote: > > On Mon, Apr 12, 2021 at 7:21 AM Stefano Garzarella > > wrote: > > > > > > On Mon, Apr 12, 2021 at 02:50:17PM +0100, Stefan Hajnoczi wrote: > > > >On Thu, Apr

Re: [RFC v2] virtio-vsock: add description for datagram type

2021-04-13 Thread Stefano Garzarella
On Mon, Apr 12, 2021 at 03:42:23PM -0700, Jiang Wang . wrote: On Mon, Apr 12, 2021 at 7:21 AM Stefano Garzarella wrote: On Mon, Apr 12, 2021 at 02:50:17PM +0100, Stefan Hajnoczi wrote: >On Thu, Apr 01, 2021 at 04:36:02AM +, jiang.wang wrote: >> Add supports for datagram type for

Re: Re: [RFC v2] virtio-vsock: add description for datagram type

2021-04-12 Thread Jiang Wang .
On Mon, Apr 12, 2021 at 7:21 AM Stefano Garzarella wrote: > > On Mon, Apr 12, 2021 at 02:50:17PM +0100, Stefan Hajnoczi wrote: > >On Thu, Apr 01, 2021 at 04:36:02AM +, jiang.wang wrote: > >> Add supports for datagram type for virtio-vsock. Datagram > >> sockets are connectionless and

Re: [External] Re: [RFC v2] virtio-vsock: add description for datagram type

2021-04-12 Thread Jiang Wang .
On Mon, Apr 12, 2021 at 6:50 AM Stefan Hajnoczi wrote: > > On Thu, Apr 01, 2021 at 04:36:02AM +, jiang.wang wrote: > > Add supports for datagram type for virtio-vsock. Datagram > > sockets are connectionless and unreliable. To avoid contention > > with stream and other sockets, add two more

Re: [RFC v2] virtio-vsock: add description for datagram type

2021-04-12 Thread Stefano Garzarella
On Mon, Apr 12, 2021 at 02:50:17PM +0100, Stefan Hajnoczi wrote: On Thu, Apr 01, 2021 at 04:36:02AM +, jiang.wang wrote: Add supports for datagram type for virtio-vsock. Datagram sockets are connectionless and unreliable. To avoid contention with stream and other sockets, add two more

Re: [RFC v2] virtio-vsock: add description for datagram type

2021-04-12 Thread Stefan Hajnoczi
On Thu, Apr 01, 2021 at 04:36:02AM +, jiang.wang wrote: > Add supports for datagram type for virtio-vsock. Datagram > sockets are connectionless and unreliable. To avoid contention > with stream and other sockets, add two more virtqueues and > a new feature bit to identify if those two new

[RFC v2] virtio-vsock: add description for datagram type

2021-03-31 Thread jiang.wang
Add supports for datagram type for virtio-vsock. Datagram sockets are connectionless and unreliable. To avoid contention with stream and other sockets, add two more virtqueues and a new feature bit to identify if those two new queues exist or not. Also add descriptions for resource management of