Re: [patch] virtio: console: fix error handling for debugfs_create_dir()

2013-08-01 Thread Arnd Bergmann
On Friday 19 July 2013, Dan Carpenter wrote: debugfs_create_dir() returns ERR_PTR(-ENODEV) if debugfs is disabled. Also my static checker doesn't like it when we print the error code, but it's always just NULL. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com This looks wrong.

Re: [patch] virtio: console: fix error handling for debugfs_create_dir()

2013-08-01 Thread Arnd Bergmann
On Saturday 20 July 2013, Dan Carpenter wrote: On Fri, Jul 19, 2013 at 12:28:41PM +0200, Arnd Bergmann wrote: On Friday 19 July 2013, Dan Carpenter wrote: debugfs_create_dir() returns ERR_PTR(-ENODEV) if debugfs is disabled. Also my static checker doesn't like it when we print the error

Re: [patch] virtio: console: fix error handling for debugfs_create_dir()

2013-07-21 Thread Greg Kroah-Hartman
On Sun, Jul 21, 2013 at 11:36:25AM +0200, Arnd Bergmann wrote: On Saturday 20 July 2013, Dan Carpenter wrote: On Fri, Jul 19, 2013 at 12:28:41PM +0200, Arnd Bergmann wrote: On Friday 19 July 2013, Dan Carpenter wrote: debugfs_create_dir() returns ERR_PTR(-ENODEV) if debugfs is disabled.

Re: [patch] virtio: console: fix error handling for debugfs_create_dir()

2013-07-21 Thread Dan Carpenter
I don't see where that oops would happen. In the code I'm looking at, all uses of -debugfs_dir only ever get passed into other debugfs functions that are stubbed out to empty inline functions. It's not the most obvious interface design, but this all seems intentional and correct to me. Ah.

Re: [patch] virtio: console: fix error handling for debugfs_create_dir()

2013-07-20 Thread Dan Carpenter
On Fri, Jul 19, 2013 at 12:28:41PM +0200, Arnd Bergmann wrote: On Friday 19 July 2013, Dan Carpenter wrote: debugfs_create_dir() returns ERR_PTR(-ENODEV) if debugfs is disabled. Also my static checker doesn't like it when we print the error code, but it's always just NULL.

Re: [patch] virtio: console: fix error handling for debugfs_create_dir()

2013-07-19 Thread Amit Shah
On (Fri) 19 Jul 2013 [08:50:49], Dan Carpenter wrote: debugfs_create_dir() returns ERR_PTR(-ENODEV) if debugfs is disabled. Also my static checker doesn't like it when we print the error code, but it's always just NULL. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Reviewed-by: Amit

[patch] virtio: console: fix error handling for debugfs_create_dir()

2013-07-18 Thread Dan Carpenter
debugfs_create_dir() returns ERR_PTR(-ENODEV) if debugfs is disabled. Also my static checker doesn't like it when we print the error code, but it's always just NULL. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c