Re: [virtio-dev] Re: [PATCH net-next v2 0/5] virtio: support packed ring

2018-10-11 Thread Tiwei Bie
On Thu, Oct 11, 2018 at 10:17:15AM -0400, Michael S. Tsirkin wrote: > On Thu, Oct 11, 2018 at 10:13:31PM +0800, Tiwei Bie wrote: > > On Thu, Oct 11, 2018 at 09:48:48AM -0400, Michael S. Tsirkin wrote: > > > On Thu, Oct 11, 2018 at 08:12:21PM +0800, Tiwei Bie wrote: > > > > > > But if it's not too

Re: [virtio-dev] Re: [PATCH net-next v2 0/5] virtio: support packed ring

2018-10-11 Thread Michael S. Tsirkin
On Thu, Oct 11, 2018 at 10:13:31PM +0800, Tiwei Bie wrote: > On Thu, Oct 11, 2018 at 09:48:48AM -0400, Michael S. Tsirkin wrote: > > On Thu, Oct 11, 2018 at 08:12:21PM +0800, Tiwei Bie wrote: > > > > > But if it's not too late, I second for a OUT_OF_ORDER feature. > > > > > Starting from in order

Re: [virtio-dev] Re: [PATCH net-next v2 0/5] virtio: support packed ring

2018-10-11 Thread Tiwei Bie
On Thu, Oct 11, 2018 at 09:48:48AM -0400, Michael S. Tsirkin wrote: > On Thu, Oct 11, 2018 at 08:12:21PM +0800, Tiwei Bie wrote: > > > > But if it's not too late, I second for a OUT_OF_ORDER feature. > > > > Starting from in order can have much simpler code in driver. > > > > > > > > Thanks > > >

Re: [virtio-dev] Re: [PATCH net-next v2 0/5] virtio: support packed ring

2018-10-11 Thread Michael S. Tsirkin
On Thu, Oct 11, 2018 at 08:12:21PM +0800, Tiwei Bie wrote: > > > But if it's not too late, I second for a OUT_OF_ORDER feature. > > > Starting from in order can have much simpler code in driver. > > > > > > Thanks > > > > It's tricky to change the flag polarity because of compatibility > > with

Re: [virtio-dev] Re: [PATCH net-next v2 0/5] virtio: support packed ring

2018-10-11 Thread Tiwei Bie
On Wed, Oct 10, 2018 at 10:36:26AM -0400, Michael S. Tsirkin wrote: > On Thu, Sep 13, 2018 at 05:47:29PM +0800, Jason Wang wrote: > > On 2018年09月13日 16:59, Tiwei Bie wrote: > > > > If what you say is true then we should take a careful look > > > > and not supporting these generic things with

Re: [virtio-dev] Re: [PATCH net-next v2 0/5] virtio: support packed ring

2018-10-10 Thread Michael S. Tsirkin
On Thu, Sep 13, 2018 at 05:47:29PM +0800, Jason Wang wrote: > > > On 2018年09月13日 16:59, Tiwei Bie wrote: > > > If what you say is true then we should take a careful look > > > and not supporting these generic things with packed layout. > > > Once we do support them it will be too late and we

Re: [virtio-dev] Re: [PATCH net-next v2 0/5] virtio: support packed ring

2018-09-13 Thread Jason Wang
On 2018年09月13日 16:59, Tiwei Bie wrote: If what you say is true then we should take a careful look and not supporting these generic things with packed layout. Once we do support them it will be too late and we won't be able to get performance back. I think it's a good point that we don't need

Re: [virtio-dev] Re: [PATCH net-next v2 0/5] virtio: support packed ring

2018-09-13 Thread Tiwei Bie
On Wed, Sep 12, 2018 at 12:16:32PM -0400, Michael S. Tsirkin wrote: > On Tue, Sep 11, 2018 at 01:37:26PM +0800, Tiwei Bie wrote: > > On Mon, Sep 10, 2018 at 11:33:17AM +0800, Jason Wang wrote: > > > On 2018年09月10日 11:00, Tiwei Bie wrote: > > > > On Fri, Sep 07, 2018 at 09:00:49AM -0400, Michael S.

Re: [virtio-dev] Re: [PATCH net-next v2 0/5] virtio: support packed ring

2018-09-12 Thread Michael S. Tsirkin
On Tue, Sep 11, 2018 at 01:37:26PM +0800, Tiwei Bie wrote: > On Mon, Sep 10, 2018 at 11:33:17AM +0800, Jason Wang wrote: > > On 2018年09月10日 11:00, Tiwei Bie wrote: > > > On Fri, Sep 07, 2018 at 09:00:49AM -0400, Michael S. Tsirkin wrote: > > > > On Fri, Sep 07, 2018 at 09:22:25AM +0800, Tiwei Bie

Re: [virtio-dev] Re: [PATCH net-next v2 0/5] virtio: support packed ring

2018-09-12 Thread Michael S. Tsirkin
On Mon, Sep 10, 2018 at 11:00:53AM +0800, Tiwei Bie wrote: > On Fri, Sep 07, 2018 at 09:00:49AM -0400, Michael S. Tsirkin wrote: > > On Fri, Sep 07, 2018 at 09:22:25AM +0800, Tiwei Bie wrote: > > > On Mon, Aug 27, 2018 at 05:00:40PM +0300, Michael S. Tsirkin wrote: > > > > Are there still plans to

Re: [virtio-dev] Re: [PATCH net-next v2 0/5] virtio: support packed ring

2018-09-10 Thread Tiwei Bie
On Mon, Sep 10, 2018 at 11:33:17AM +0800, Jason Wang wrote: > On 2018年09月10日 11:00, Tiwei Bie wrote: > > On Fri, Sep 07, 2018 at 09:00:49AM -0400, Michael S. Tsirkin wrote: > > > On Fri, Sep 07, 2018 at 09:22:25AM +0800, Tiwei Bie wrote: > > > > On Mon, Aug 27, 2018 at 05:00:40PM +0300, Michael S.

Re: [virtio-dev] Re: [PATCH net-next v2 0/5] virtio: support packed ring

2018-09-09 Thread Jason Wang
On 2018年09月10日 11:00, Tiwei Bie wrote: On Fri, Sep 07, 2018 at 09:00:49AM -0400, Michael S. Tsirkin wrote: On Fri, Sep 07, 2018 at 09:22:25AM +0800, Tiwei Bie wrote: On Mon, Aug 27, 2018 at 05:00:40PM +0300, Michael S. Tsirkin wrote: Are there still plans to test the performance with vost

Re: [virtio-dev] Re: [PATCH net-next v2 0/5] virtio: support packed ring

2018-09-09 Thread Tiwei Bie
On Fri, Sep 07, 2018 at 09:00:49AM -0400, Michael S. Tsirkin wrote: > On Fri, Sep 07, 2018 at 09:22:25AM +0800, Tiwei Bie wrote: > > On Mon, Aug 27, 2018 at 05:00:40PM +0300, Michael S. Tsirkin wrote: > > > Are there still plans to test the performance with vost pmd? > > > vhost doesn't seem to

Re: [virtio-dev] Re: [PATCH net-next v2 0/5] virtio: support packed ring

2018-09-07 Thread Michael S. Tsirkin
On Fri, Sep 07, 2018 at 09:22:25AM +0800, Tiwei Bie wrote: > On Mon, Aug 27, 2018 at 05:00:40PM +0300, Michael S. Tsirkin wrote: > > Are there still plans to test the performance with vost pmd? > > vhost doesn't seem to show a performance gain ... > > > > I tried some performance tests with

Re: [virtio-dev] Re: [PATCH net-next v2 0/5] virtio: support packed ring

2018-09-06 Thread Tiwei Bie
On Mon, Aug 27, 2018 at 05:00:40PM +0300, Michael S. Tsirkin wrote: > Are there still plans to test the performance with vost pmd? > vhost doesn't seem to show a performance gain ... > I tried some performance tests with vhost PMD. In guest, the XDP program will return XDP_DROP directly. And in