Re: [virtio-dev] Re: [RFC PATCH 1/1] virtio: write back features before verify

2021-10-05 Thread Cornelia Huck
On Tue, Oct 05 2021, "Michael S. Tsirkin" wrote: > On Tue, Oct 05, 2021 at 01:17:51PM +0200, Halil Pasic wrote: >> On Mon, 4 Oct 2021 16:01:12 -0400 >> "Michael S. Tsirkin" wrote: >> >> > > >> > > Ok, so what about something like >> > > >> > > "If FEATURES_OK is not set, the driver MAY

Re: [virtio-dev] Re: [RFC PATCH 1/1] virtio: write back features before verify

2021-10-05 Thread Michael S. Tsirkin
On Tue, Oct 05, 2021 at 01:17:51PM +0200, Halil Pasic wrote: > On Mon, 4 Oct 2021 16:01:12 -0400 > "Michael S. Tsirkin" wrote: > > > > > > > Ok, so what about something like > > > > > > "If FEATURES_OK is not set, the driver MAY change the set of features it > > > accepts." > > > > > > in the

Re: [virtio-dev] Re: [RFC PATCH 1/1] virtio: write back features before verify

2021-10-05 Thread Halil Pasic
On Mon, 4 Oct 2021 16:01:12 -0400 "Michael S. Tsirkin" wrote: > > > > Ok, so what about something like > > > > "If FEATURES_OK is not set, the driver MAY change the set of features it > > accepts." > > > > in the device initialization section? > > Maybe "as long as". However Halil implied

Re: [virtio-dev] Re: [RFC PATCH 1/1] virtio: write back features before verify

2021-10-05 Thread Cornelia Huck
On Mon, Oct 04 2021, "Michael S. Tsirkin" wrote: > On Mon, Oct 04, 2021 at 05:45:06PM +0200, Cornelia Huck wrote: >> On Mon, Oct 04 2021, "Michael S. Tsirkin" wrote: >> >> > On Mon, Oct 04, 2021 at 04:27:23PM +0200, Cornelia Huck wrote: >> >> On Mon, Oct 04 2021, "Michael S. Tsirkin" wrote:

Re: [virtio-dev] Re: [RFC PATCH 1/1] virtio: write back features before verify

2021-10-04 Thread Michael S. Tsirkin
On Mon, Oct 04, 2021 at 05:45:06PM +0200, Cornelia Huck wrote: > On Mon, Oct 04 2021, "Michael S. Tsirkin" wrote: > > > On Mon, Oct 04, 2021 at 04:27:23PM +0200, Cornelia Huck wrote: > >> On Mon, Oct 04 2021, "Michael S. Tsirkin" wrote: > >> > >> > On Mon, Oct 04, 2021 at 02:01:14PM +0200,

Re: [virtio-dev] Re: [RFC PATCH 1/1] virtio: write back features before verify

2021-10-04 Thread Cornelia Huck
On Mon, Oct 04 2021, "Michael S. Tsirkin" wrote: > On Mon, Oct 04, 2021 at 04:27:23PM +0200, Cornelia Huck wrote: >> On Mon, Oct 04 2021, "Michael S. Tsirkin" wrote: >> >> > On Mon, Oct 04, 2021 at 02:01:14PM +0200, Cornelia Huck wrote: >> >> On Sun, Oct 03 2021, "Michael S. Tsirkin" wrote: