RE: [PATCH] staging: hv: Fix GARP not sent after Quick Migration

2011-04-05 Thread Haiyang Zhang
> -Original Message- > From: Greg KH [mailto:g...@kroah.com] > Sent: Tuesday, April 05, 2011 12:23 PM > Instead, use a proper timer as you do know how long you need to wait, > right? Don't abuse workqueues for something they were not designed for. Thanks for the suggestion, I will add an

Re: [PATCH] staging: hv: Fix GARP not sent after Quick Migration

2011-04-05 Thread Greg KH
On Tue, Apr 05, 2011 at 09:24:15AM -0700, Haiyang Zhang wrote: > After Quick Migration, the network is not immediately operational in the > current context when receiving RNDIS_STATUS_MEDIA_CONNECT event. So, I put > the netif_notify_peers() into a scheduled work, otherwise GARP packet will > not b

Re: [PATCH] staging: hv: Fix GARP not sent after Quick Migration

2011-04-05 Thread Greg KH
On Tue, Apr 05, 2011 at 03:54:54PM +, Haiyang Zhang wrote: > > -Original Message- > > From: Greg KH [mailto:gre...@suse.de] > > Sent: Tuesday, April 05, 2011 11:42 AM > > But that's a hypervisor bug, right? It shouldn't be sending a "connect" > > event on the ethernet device if the net

RE: [PATCH] staging: hv: Fix GARP not sent after Quick Migration

2011-04-05 Thread Haiyang Zhang
> -Original Message- > From: Greg KH [mailto:gre...@suse.de] > Sent: Tuesday, April 05, 2011 11:42 AM > But that's a hypervisor bug, right? It shouldn't be sending a "connect" > event on the ethernet device if the network really isn't present. How > about getting it fixed there, which wil

Re: [PATCH] staging: hv: Fix GARP not sent after Quick Migration

2011-04-05 Thread Greg KH
On Tue, Apr 05, 2011 at 08:27:48AM -0700, Haiyang Zhang wrote: > After Quick Migration, the network is not immediately operational in the > current context when receiving RNDIS_STATUS_MEDIA_CONNECT event. So, I put > the netif_notify_peers() into a scheduled work, otherwise GARP packet will > not b