RE: [PATCH 05/10] staging: hv: Convert camel cased functions in hv.c to lower cases

2010-11-03 Thread Haiyang Zhang
From: Greg KH [g...@kroah.com] Sent: Wednesday, November 03, 2010 7:36 AM > But you should. Remember, be consistent. > Care to redo these again? Sure, I will update the patches. Thanks, - Haiyang ___ Virtualization mailing list Virtualization@lists.lin

Re: [PATCH 05/10] staging: hv: Convert camel cased functions in hv.c to lower cases

2010-11-03 Thread Brandon Philips
On 13:46 Mon 01 Nov 2010, Haiyang Zhang wrote: > -static int HvQueryHypervisorInfo(void) > +static int hvquery_hypervisor_info(void) > -static u64 HvDoHypercall(u64 control, void *input, void *output) > +static u64 hvdo_hypercall(u64 control, void *input, void *output) Should these be hv_do_hyperc

Re: [PATCH 05/10] staging: hv: Convert camel cased functions in hv.c to lower cases

2010-11-03 Thread Greg KH
On Tue, Nov 02, 2010 at 09:06:56PM +, Haiyang Zhang wrote: > > From: Brandon Philips [mailto:bran...@ifup.org] > > Sent: Tuesday, November 02, 2010 1:04 PM > > > -static int HvQueryHypervisorInfo(void) > > > +static int hvquery_hypervisor_info(void) > > > -static u64 HvDoHypercall(u64 control,

RE: [PATCH 05/10] staging: hv: Convert camel cased functions in hv.c to lower cases

2010-11-02 Thread Haiyang Zhang
> From: Brandon Philips [mailto:bran...@ifup.org] > Sent: Tuesday, November 02, 2010 1:04 PM > > -static int HvQueryHypervisorInfo(void) > > +static int hvquery_hypervisor_info(void) > > -static u64 HvDoHypercall(u64 control, void *input, void *output) > > +static u64 hvdo_hypercall(u64 control, vo