RE: [PATCH 41/46] Staging: hv: vmbus: Fix a bug in error handling in vmbus_bus_init()

2011-08-31 Thread KY Srinivasan
-Original Message- From: Greg KH [mailto:g...@kroah.com] Sent: Monday, August 29, 2011 2:09 PM To: KY Srinivasan Cc: gre...@suse.de; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; virtualizat...@lists.osdl.org; Haiyang Zhang Subject: Re: [PATCH 41/46] Staging: hv:

RE: [PATCH 41/46] Staging: hv: vmbus: Fix a bug in error handling in vmbus_bus_init()

2011-08-31 Thread KY Srinivasan
-Original Message- From: Greg KH [mailto:g...@kroah.com] Sent: Tuesday, August 30, 2011 10:07 AM To: Dan Carpenter Cc: KY Srinivasan; de...@linuxdriverproject.org; Haiyang Zhang; gre...@suse.de; linux-ker...@vger.kernel.org; virtualizat...@lists.osdl.org Subject: Re: [PATCH

Re: [PATCH 41/46] Staging: hv: vmbus: Fix a bug in error handling in vmbus_bus_init()

2011-08-30 Thread Dan Carpenter
err3: free_irq(irq, hv_acpi_dev); err2: bus_unregister(hv_bus); err1: hv_cleanup(); Also here is an oldbie trick. You could use multiples of ten like err30, err20, and err10. That way if you can add more error handling in the middle without changing the numbering. I

Re: [PATCH 41/46] Staging: hv: vmbus: Fix a bug in error handling in vmbus_bus_init()

2011-08-30 Thread Greg KH
On Tue, Aug 30, 2011 at 01:29:49PM +0300, Dan Carpenter wrote: err3: free_irq(irq, hv_acpi_dev); err2: bus_unregister(hv_bus); err1: hv_cleanup(); Also here is an oldbie trick. You could use multiples of ten like err30, err20, and err10. That way if you can add more

Re: [PATCH 41/46] Staging: hv: vmbus: Fix a bug in error handling in vmbus_bus_init()

2011-08-29 Thread Greg KH
On Sat, Aug 27, 2011 at 11:31:40AM -0700, K. Y. Srinivasan wrote: Fix a bug in error handling in vmbus_bus_init(). Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com --- drivers/staging/hv/vmbus_drv.c | 21 ++--- 1