Re: [PATCH net v3] virtio_net: Fix error unwinding of XDP initialization

2023-05-11 Thread Xuan Zhuo
On Thu, 11 May 2023 21:54:40 -0400, Feng Liu wrote: > > > On 2023-05-10 a.m.1:00, Jason Wang wrote: > > External email: Use caution opening links or attachments > > > > > > 在 2023/5/9 09:43, Xuan Zhuo 写道: > >> On Mon, 8 May 2023 11:00:10 -0400, Feng Liu wrote: > >>> > >>> On 2023-05-07 p.m.9:45,

Re: [PATCH net v3] virtio_net: Fix error unwinding of XDP initialization

2023-05-11 Thread Feng Liu via Virtualization
On 2023-05-10 a.m.1:00, Jason Wang wrote: External email: Use caution opening links or attachments 在 2023/5/9 09:43, Xuan Zhuo 写道: On Mon, 8 May 2023 11:00:10 -0400, Feng Liu wrote: On 2023-05-07 p.m.9:45, Xuan Zhuo wrote: External email: Use caution opening links or attachments On

Re: [PATCH net v3] virtio_net: Fix error unwinding of XDP initialization

2023-05-10 Thread Feng Liu via Virtualization
On 2023-05-10 a.m.1:00, Jason Wang wrote: External email: Use caution opening links or attachments 在 2023/5/9 09:43, Xuan Zhuo 写道: On Mon, 8 May 2023 11:00:10 -0400, Feng Liu wrote: On 2023-05-07 p.m.9:45, Xuan Zhuo wrote: External email: Use caution opening links or attachments On

Re: [PATCH net v3] virtio_net: Fix error unwinding of XDP initialization

2023-05-09 Thread Jason Wang
在 2023/5/9 09:43, Xuan Zhuo 写道: On Mon, 8 May 2023 11:00:10 -0400, Feng Liu wrote: On 2023-05-07 p.m.9:45, Xuan Zhuo wrote: External email: Use caution opening links or attachments On Sat, 6 May 2023 08:08:02 -0400, Feng Liu wrote: On 2023-05-05 p.m.10:33, Xuan Zhuo wrote: External

Re: [PATCH net v3] virtio_net: Fix error unwinding of XDP initialization

2023-05-08 Thread Xuan Zhuo
On Mon, 8 May 2023 11:00:10 -0400, Feng Liu wrote: > > > On 2023-05-07 p.m.9:45, Xuan Zhuo wrote: > > External email: Use caution opening links or attachments > > > > > > On Sat, 6 May 2023 08:08:02 -0400, Feng Liu wrote: > >> > >> > >> On 2023-05-05 p.m.10:33, Xuan Zhuo wrote: > >>> External

Re: [PATCH net v3] virtio_net: Fix error unwinding of XDP initialization

2023-05-08 Thread Feng Liu via Virtualization
On 2023-05-07 p.m.9:45, Xuan Zhuo wrote: External email: Use caution opening links or attachments On Sat, 6 May 2023 08:08:02 -0400, Feng Liu wrote: On 2023-05-05 p.m.10:33, Xuan Zhuo wrote: External email: Use caution opening links or attachments On Tue, 2 May 2023 20:35:25 -0400,

Re: [PATCH net v3] virtio_net: Fix error unwinding of XDP initialization

2023-05-07 Thread Xuan Zhuo
On Sat, 6 May 2023 08:08:02 -0400, Feng Liu wrote: > > > On 2023-05-05 p.m.10:33, Xuan Zhuo wrote: > > External email: Use caution opening links or attachments > > > > > > On Tue, 2 May 2023 20:35:25 -0400, Feng Liu wrote: > >> When initializing XDP in virtnet_open(), some rq xdp initialization

Re: [PATCH net v3] virtio_net: Fix error unwinding of XDP initialization

2023-05-06 Thread Feng Liu via Virtualization
On 2023-05-05 p.m.10:33, Xuan Zhuo wrote: External email: Use caution opening links or attachments On Tue, 2 May 2023 20:35:25 -0400, Feng Liu wrote: When initializing XDP in virtnet_open(), some rq xdp initialization may hit an error causing net device open failed. However, previous rqs

Re: [PATCH net v3] virtio_net: Fix error unwinding of XDP initialization

2023-05-05 Thread Xuan Zhuo
On Tue, 2 May 2023 20:35:25 -0400, Feng Liu wrote: > When initializing XDP in virtnet_open(), some rq xdp initialization > may hit an error causing net device open failed. However, previous > rqs have already initialized XDP and enabled NAPI, which is not the > expected behavior. Need to roll

Re: [PATCH net v3] virtio_net: Fix error unwinding of XDP initialization

2023-05-03 Thread Feng Liu via Virtualization
On 2023-05-02 p.m.11:14, Parav Pandit wrote: From: Feng Liu Sent: Tuesday, May 2, 2023 8:35 PM Issue: 3383038 Remove this internal garbage. Fixes: 754b8a21a96d ("virtio_net: setup xdp_rxq_info") Signed-off-by: Feng Liu Reviewed-by: William Tu Reviewed-by: Parav Pandit Reviewed-by:

RE: [PATCH net v3] virtio_net: Fix error unwinding of XDP initialization

2023-05-02 Thread Parav Pandit via Virtualization
> From: Feng Liu > Sent: Tuesday, May 2, 2023 8:35 PM > Issue: 3383038 Remove this internal garbage. > Fixes: 754b8a21a96d ("virtio_net: setup xdp_rxq_info") > Signed-off-by: Feng Liu > Reviewed-by: William Tu > Reviewed-by: Parav Pandit > Reviewed-by: Simon Horman > Acked-by: Michael S.