Re: [PATCH v2] virtio-blk: add DISCARD support to virtio-blk driver

2017-07-05 Thread Michael S. Tsirkin
on.org > > Cc: stefa...@gmail.com; h...@lst.de; m...@redhat.com > > Subject: Re: [PATCH v2] virtio-blk: add DISCARD support to virtio-blk driver > > > > > > > > On 05/07/2017 10:44, Changpeng Liu wrote: > > > Currently virtio-blk driver does not provi

Re: [PATCH v2] virtio-blk: add DISCARD support to virtio-blk driver

2017-07-05 Thread Paolo Bonzini
On 05/07/2017 09:57, Liu, Changpeng wrote: >> Please include a patch for the specification. Since we are at it, I > Thanks Paolo, do you mean include a text file which describe the changes for > the specification? The specification is hosted in an svn (Subversion) repository at https://tools.o

RE: [PATCH v2] virtio-blk: add DISCARD support to virtio-blk driver

2017-07-05 Thread Liu, Changpeng
> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Tuesday, July 4, 2017 5:24 PM > To: Liu, Changpeng ; virtualization@lists.linux- > foundation.org > Cc: stefa...@gmail.com; h...@lst.de; m...@redhat.com > Subject: Re: [PATCH v2] vi

Re: [PATCH v2] virtio-blk: add DISCARD support to virtio-blk driver

2017-07-04 Thread Michael S. Tsirkin
On Tue, Jul 04, 2017 at 11:24:01AM +0200, Paolo Bonzini wrote: > > > On 05/07/2017 10:44, Changpeng Liu wrote: > > Currently virtio-blk driver does not provide discard feature flag, so the > > filesystems which built on top of the block device will not send discard > > command. This is okay for H

Re: [PATCH v2] virtio-blk: add DISCARD support to virtio-blk driver

2017-07-04 Thread Paolo Bonzini
On 05/07/2017 10:44, Changpeng Liu wrote: > Currently virtio-blk driver does not provide discard feature flag, so the > filesystems which built on top of the block device will not send discard > command. This is okay for HDD backend, but it will impact the performance > for SSD backend. > > Add