RE: [virtio-dev] Re: [PATCH v3] crypto: add virtio-crypto driver

2016-11-29 Thread Gonglei (Arei)
> > Subject: Re: [virtio-dev] Re: [PATCH v3] crypto: add virtio-crypto driver > > On Tue, 29 Nov 2016 01:37:44 + > "Gonglei (Arei)" <arei.gong...@huawei.com> wrote: > > > > On Mon, 28 Nov 2016 20:08:23 +0800 > > > Gonglei <ar

RE: [PATCH v3] crypto: add virtio-crypto driver

2016-11-29 Thread Gonglei (Arei)
> > > On Tue, Nov 29, 2016 at 08:22:58AM +, Gonglei (Arei) wrote: > > > Hi, > > > > > > > > > > +source "drivers/crypto/virtio/Kconfig" > > > > > > > + > > > > > > > endif # CRYPTO_HW > > > > > > > diff --git a/drivers/crypto/Makefile b/drivers/crypto/Makefile > > > > > > > index

Re: [virtio-dev] Re: [PATCH v3] crypto: add virtio-crypto driver

2016-11-29 Thread Cornelia Huck
On Tue, 29 Nov 2016 01:37:44 + "Gonglei (Arei)" wrote: > > On Mon, 28 Nov 2016 20:08:23 +0800 > > Gonglei wrote: > > > > > +static int virtcrypto_update_status(struct virtio_crypto *vcrypto) > > > +{ > > > + u32 status; > > > + int err; > >

RE: [PATCH v3] crypto: add virtio-crypto driver

2016-11-29 Thread Gonglei (Arei)
> > On Tue, Nov 29, 2016 at 08:22:58AM +, Gonglei (Arei) wrote: > > Hi, > > > > > > > > +source "drivers/crypto/virtio/Kconfig" > > > > > > + > > > > > > endif # CRYPTO_HW > > > > > > diff --git a/drivers/crypto/Makefile b/drivers/crypto/Makefile > > > > > > index ad7250f..bc53cb8 100644 > >

Re: [PATCH v3] crypto: add virtio-crypto driver

2016-11-29 Thread Cornelia Huck
On Tue, 29 Nov 2016 09:25:49 + Stefan Hajnoczi wrote: > On Tue, Nov 29, 2016 at 08:22:58AM +, Gonglei (Arei) wrote: > > Hi, > > > > > > > > +source "drivers/crypto/virtio/Kconfig" > > > > > > + > > > > > > endif # CRYPTO_HW > > > > > > diff --git

Re: [PATCH v3] crypto: add virtio-crypto driver

2016-11-29 Thread Stefan Hajnoczi
On Tue, Nov 29, 2016 at 08:22:58AM +, Gonglei (Arei) wrote: > Hi, > > > > > > +source "drivers/crypto/virtio/Kconfig" > > > > > + > > > > > endif # CRYPTO_HW > > > > > diff --git a/drivers/crypto/Makefile b/drivers/crypto/Makefile > > > > > index ad7250f..bc53cb8 100644 > > > > > ---

RE: [PATCH v3] crypto: add virtio-crypto driver

2016-11-29 Thread Gonglei (Arei)
Hi, > > > > +source "drivers/crypto/virtio/Kconfig" > > > > + > > > > endif # CRYPTO_HW > > > > diff --git a/drivers/crypto/Makefile b/drivers/crypto/Makefile > > > > index ad7250f..bc53cb8 100644 > > > > --- a/drivers/crypto/Makefile > > > > +++ b/drivers/crypto/Makefile > > > > @@ -32,3 +32,4

RE: [PATCH v3] crypto: add virtio-crypto driver

2016-11-28 Thread Gonglei (Arei)
> > > > > + > > > > +/* Note: kernel crypto API realization */ > > > > +static int virtio_crypto_ablkcipher_setkey(struct crypto_ablkcipher > > > > *tfm, > > > > +const uint8_t *key, > > > > +unsigned int keylen) > >

RE: [PATCH v3] crypto: add virtio-crypto driver

2016-11-28 Thread Gonglei (Arei)
Hi Halil, > > On 11/28/2016 06:19 PM, Michael S. Tsirkin wrote: > >>> +static int virtio_crypto_alg_ablkcipher_init_session( > >>> > > + struct virtio_crypto_ablkcipher_ctx *ctx, > >>> > > + uint32_t alg, const uint8_t *key, > >>> > > + unsigned int keylen, >

RE: [PATCH v3] crypto: add virtio-crypto driver

2016-11-28 Thread Gonglei (Arei)
Hi Michael and Stefan, > > Subject: Re: [PATCH v3] crypto: add virtio-crypto driver > > On Mon, Nov 28, 2016 at 04:20:55PM +, Stefan Hajnoczi wrote: > > On Mon, Nov 28, 2016 at 08:08:23PM +0800, Gonglei wrote: > > > This patch introduces virtio-cry

RE: [virtio-dev] Re: [PATCH v3] crypto: add virtio-crypto driver

2016-11-28 Thread Gonglei (Arei)
> > Subject: [virtio-dev] Re: [PATCH v3] crypto: add virtio-crypto driver > > On Mon, 28 Nov 2016 20:08:23 +0800 > Gonglei <arei.gong...@huawei.com> wrote: > > > +static int virtcrypto_update_status(struct virtio_crypto *vcrypto) > > +{

Re: [PATCH v3] crypto: add virtio-crypto driver

2016-11-28 Thread Halil Pasic
On 11/28/2016 06:19 PM, Michael S. Tsirkin wrote: >>> +static int virtio_crypto_alg_ablkcipher_init_session( >>> > > + struct virtio_crypto_ablkcipher_ctx *ctx, >>> > > + uint32_t alg, const uint8_t *key, >>> > > + unsigned int keylen, >>> > > +

Re: [PATCH v3] crypto: add virtio-crypto driver

2016-11-28 Thread Michael S. Tsirkin
On Mon, Nov 28, 2016 at 04:20:55PM +, Stefan Hajnoczi wrote: > On Mon, Nov 28, 2016 at 08:08:23PM +0800, Gonglei wrote: > > This patch introduces virtio-crypto driver for Linux Kernel. > > > > The virtio crypto device is a virtual cryptography device > > as well as a kind of virtual hardware

Re: [PATCH v3] crypto: add virtio-crypto driver

2016-11-28 Thread Stefan Hajnoczi
On Mon, Nov 28, 2016 at 08:08:23PM +0800, Gonglei wrote: > This patch introduces virtio-crypto driver for Linux Kernel. > > The virtio crypto device is a virtual cryptography device > as well as a kind of virtual hardware accelerator for > virtual machines. The encryption anddecryption requests >

Re: [PATCH v3] crypto: add virtio-crypto driver

2016-11-28 Thread kbuild test robot
Hi Gonglei, [auto build test ERROR on cryptodev/master] [also build test ERROR on v4.9-rc7 next-20161128] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v3] crypto: add virtio-crypto driver

2016-11-28 Thread Cornelia Huck
On Mon, 28 Nov 2016 20:08:23 +0800 Gonglei wrote: > +static int virtcrypto_update_status(struct virtio_crypto *vcrypto) > +{ > + u32 status; > + int err; > + > + virtio_cread(vcrypto->vdev, > + struct virtio_crypto_config, status, ); > + > + /*